GNU bug report logs - #15500
24.3.50; NS variant does not build 32-bit on Snow Leopard due to parameter of incompatible type 'CGRect'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 15500 in the body.
You can then email your comments to 15500 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Peter Dyballa <Peter_Dyballa <at> Freenet.DE>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50;
 NS variant does not build 32-bit on Snow Leopard due to parameter of
 incompatible type 'CGRect'
Date: Tue, 1 Oct 2013 13:02:56 +0200

Hello!

This is the error:

	clang -c  -Demacs  -I. -I.../emacs-24.3.50/src -I../lib -I.../emacs-24.3.50/src/../lib   -I/usr/X11/include   -I/sw/include/librsvg-2 -I/sw/include/glib-2.0 -I/sw/lib/glib-2.0/include -I/sw/include/gtk-2.0 -I/sw/include/cairo -I/sw/include -I/sw/include/freetype2 -I/usr/X11/include  -I/sw/include/libxml2 -I/sw/include         -MMD -MF deps/macfont.d -MP -I/sw/include    -Wno-switch -Wno-pointer-sign  -g -H -pipe -fPIC -fno-common -Os -march=core2 -mtune=core2 -m32 -fomit-frame-pointer -msse4.2   macfont.m
	macfont.m:2711:5: error: passing 'NSRect' (aka 'struct _NSRect') to parameter of incompatible type 'CGRect'
	      (aka 'struct CGRect')
	                         NSMakeRect (x, y,
	                         ^~~~~~~~~~~~~~~~~
	In file included from macfont.m:25:
	In file included from ./dispextern.h:76:
	In file included from ./nsgui.h:34:
	In file included from /System/Library/Frameworks/AppKit.framework/Headers/AppKit.h:10:
	In file included from /System/Library/Frameworks/Foundation.framework/Headers/Foundation.h:114:
	In file included from /System/Library/Frameworks/Foundation.framework/Headers/NSAppleEventDescriptor.h:8:
	In file included from /System/Library/Frameworks/ApplicationServices.framework/Headers/ApplicationServices.h:30:
	In file included from /System/Library/Frameworks/ApplicationServices.framework/Frameworks/QD.framework/Headers/QD.h:25:
	In file included from /System/Library/Frameworks/ApplicationServices.framework/Frameworks/CoreGraphics.framework/Headers/CoreGraphics.h:11:
	In file included from /System/Library/Frameworks/ApplicationServices.framework/Frameworks/CoreGraphics.framework/Headers/CGBitmapContext.h:9:
	/System/Library/Frameworks/ApplicationServices.framework/Frameworks/CoreGraphics.framework/Headers/CGContext.h:402:57: note: 
	      passing argument to parameter 'rect' here
	CG_EXTERN void CGContextFillRect(CGContextRef c, CGRect rect)
	                                                        ^
	1 error generated.
	make[2]: *** [macfont.o] Error 1
	make[1]: *** [src] Error 2
	make: *** [bootstrap] Error 2

At bzr revno: 114488

--
Greetings

  Pete

My sister opened a computer store in Hawaii.  She sells C shells down by the seashore.

Message #8 received at 15500 <at> debbugs.gnu.org (full text, mbox):

From: Alp Aker <alptekin.aker <at> gmail.com>
To: Peter Dyballa <Peter_Dyballa <at> freenet.de>
Cc: 15500 <at> debbugs.gnu.org
Subject: Re: bug#15500: 24.3.50; NS variant does not build 32-bit on Snow
 Leopard due to parameter of incompatible type 'CGRect'
Date: Tue, 1 Oct 2013 11:27:03 -0400

[Message part 1 (text/plain, inline)]

Does the following patch fix that?

=== modified file 'src/macfont.m'
--- src/macfont.m 2013-09-22 09:31:55 +0000
+++ src/macfont.m 2013-10-01 15:21:23 +0000
@@ -2708,7 +2708,7 @@
     {
       CG_SET_FILL_COLOR_WITH_GC_BACKGROUND (context, s);
       CGContextFillRect (context,
-  NSMakeRect (x, y,
+  CGRectMake (x, y,
                                      s->width, FONT_HEIGHT (s->font)));
     }

[Message part 2 (text/html, inline)]

Message #13 received at 15500-done <at> debbugs.gnu.org (full text, mbox):

From: Alp Aker <alptekin.aker <at> gmail.com>
To: Peter Dyballa <Peter_Dyballa <at> freenet.de>
Cc: 15500-done <at> debbugs.gnu.org
Subject: Re: bug#15500: 24.3.50; NS variant does not build 32-bit on Snow
 Leopard due to parameter of incompatible type 'CGRect'
Date: Tue, 1 Oct 2013 23:30:01 -0400

[Message part 1 (text/plain, inline)]

Fixed in r114493.

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.