GNU bug report logs - #15562
[PATCH] Text Mode Menu

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 15562 in the body.
You can then email your comments to 15562 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Anthony <john <at> jo.hnanthony.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Text Mode Menu
Date: Tue, 8 Oct 2013 18:53:05 +0400

[Message part 1 (text/plain, inline)]

Hey there, everybody. My first patch here. I noticed in etc/TODO that
all major modes should really have an appropriate menu, so I thought
I'd run through them and add all the missing ones.

I'm a first-time contributor and have been informed (through
etc/CONTRIBUTE) that if I'm intending to supply over ~15LOC I will
need to sign some paperwork and return it - I am interested in doing
this and continuing to contribute to Emacs as a steady thing for a
long time. I don't know how to go about requesting this. Should I
continue to supply patches here even whilst this is not sorted?

Patch is attached for Text Mode and I hope it's acceptable. I
completely aped the existing implementations from modes that manually
make the menu (rather than use easy-menu-define) so hopefully it's
nothing too controversial.

  * lisp/textmode/text-mode.el: Added menu bindings to text-mode-map

--
John Anthony

[text-mode-menu.patch (text/x-diff, attachment)]

Message #8 received at 15562 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: John Anthony <john <at> jo.hnanthony.com>
Cc: 15562 <at> debbugs.gnu.org
Subject: Re: bug#15562: [PATCH] Text Mode Menu
Date: Tue, 08 Oct 2013 13:19:45 -0400

John Anthony wrote:

> I'm a first-time contributor and have been informed (through
> etc/CONTRIBUTE) that if I'm intending to supply over ~15LOC I will
> need to sign some paperwork and return it - I am interested in doing
> this and continuing to contribute to Emacs as a steady thing for a
> long time. I don't know how to go about requesting this.

Thanks and welcome! I will send you a form off-list to get started with
this.

>  Should I continue to supply patches here even whilst this is not
> sorted?

Yes please.

(IMO, bug-gnu-emacs is better for (finished) patches than emacs-devel,
since they are less likely to get lost here.)

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Anthony <john <at> jo.hnanthony.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#15562: [PATCH] Text Mode Menu
Date: Tue, 8 Oct 2013 21:45:57 +0400

> Thanks and welcome! I will send you a form off-list to get started with
> this.

Thankyou -- I've completed and sent the form. Glad to be involved.

> (IMO, bug-gnu-emacs is better for (finished) patches than emacs-devel,
> since they are less likely to get lost here.)

I thought as much. I did take some time to try and become more
familiar with the lists before contributing and I think I have a feel
for how each should be used. I went to emacs-devel in an attempt to be
too cautious rather than too brash.

-- 
John Anthony

Message #16 received at 15562-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 15562-done <at> debbugs.gnu.org
Subject: Re: bug#15562: [PATCH] Text Mode Menu
Date: Wed, 09 Oct 2013 20:28:34 -0400

Version: 24.4

Applied, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.