GNU bug report logs - #15678
[PATCH] compile.el: support GNU Make-4.0 directory quoting

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 15678 in the body.
You can then email your comments to 15678 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jed Brown <jed <at> 59A2.org>
To: bug-gnu-emacs <at> gnu.org
Cc: Jed Brown <jed <at> 59A2.org>
Subject: [PATCH] compile.el: support GNU Make-4.0 directory quoting
Date: Mon, 21 Oct 2013 21:04:00 -0500

GNU Make commit 23c2b99e9d23e726 is part of make-4.0:

  Convert all "`'" quotes to "''" per new GNU Coding Standard guidelines.

This changes the output from

  make: Entering directory `/path/to/src'

to

  make: Entering directory '/path/to/src'

This patch teaches compile.el about the latter.
---
 lisp/progmodes/compile.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index 3b86ddc..54f0372 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -513,7 +513,7 @@ listed text properties PROP# are given values VAL# as well."
   "Directory to restore to when doing `recompile'.")
 
 (defvar compilation-directory-matcher
-  '("\\(?:Entering\\|Leavin\\(g\\)\\) directory `\\(.+\\)'$" (2 . 1))
+  '("\\(?:Entering\\|Leavin\\(g\\)\\) directory [`']\\(.+\\)'$" (2 . 1))
   "A list for tracking when directories are entered or left.
 If nil, do not track directories, e.g. if all file names are absolute.  The
 first element is the REGEXP matching these messages.  It can match any number
@@ -526,7 +526,7 @@ directory we were in before the last entering message.  If you change this,
 you may also want to change `compilation-page-delimiter'.")
 
 (defvar compilation-page-delimiter
-  "^\\(?:\f\\|.*\\(?:Entering\\|Leaving\\) directory `.+'\n\\)+"
+  "^\\(?:\f\\|.*\\(?:Entering\\|Leaving\\) directory [`'].+'\n\\)+"
   "Value of `page-delimiter' in Compilation mode.")
 
 (defvar compilation-mode-font-lock-keywords
-- 
1.8.4.1

Message #10 received at 15678-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 15678-done <at> debbugs.gnu.org
Subject: Re: bug#15678: [PATCH] compile.el: support GNU Make-4.0 directory
 quoting
Date: Wed, 23 Oct 2013 12:26:27 -0400

Version: 24.4

Thanks; applied.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.