GNU bug report logs - #15775
24.3.50; "WARNING: terminal is not fully functional" in Comint and Eshell

Previous Next

To reply to this bug, email your comments to 15775 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50;
 "WARNING: terminal is not fully functional" in Comint and Eshell
Date: Fri, 01 Nov 2013 05:58:15 +0400

It has been a somewhat common problem with calling external processes
from Emacs. Some references:

http://david.rothlis.net/emacs/customize_general.html#shell

https://github.com/nonsequitur/inf-ruby/issues/33

https://github.com/dgutov/robe/issues/9

The common recommendation is to change the PAGER environment var, and it
works, but why isn't Emacs doing it by default (like with TERM, for
example)?

Can packages just go ahead and set it, without having to leave it to
users? Should they limit the change only to buffers they work with? I
looked at how that could be done with Comint (and a mode deriving from
it), but `make-comint' creates a new buffer, so it's not like I can
change the local value of `process-environment' before the external
process is launched.


In GNU Emacs 24.3.50.3 (x86_64-unknown-linux-gnu, GTK+ Version 3.6.4)
 of 2013-10-30 on axl
Bzr revision: 114852 monnier <at> iro.umontreal.ca-20131030012836-rxvpx3me7vn7gnkw
Windowing system distributor `The X.Org Foundation', version 11.0.11303000
System Description:	Ubuntu 13.04

Message #14 received at 15775 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Dan Nicolaescu <dann <at> gnu.org>
Cc: 15775 <at> debbugs.gnu.org,
 Jan Djärv <jan.h.d <at> swipnet.se>,
 schwab <at> linux-m68k.org, Ulrich Neumerkel <ulrich <at> complang.tuwien.ac.at>,
 4359 <at> debbugs.gnu.org
Subject: Re: bug#15775: 24.3.50; "WARNING: terminal is not fully functional"
 in Comint and Eshell
Date: Thu, 05 May 2022 14:42:49 +0200

This change makes "git grep" work as a grep command with `M-x grep' (if
you remove --null).  It's shouldn't have a negative impact on much
anything else (because no pagers should be used anywhere here), but
perhaps it should be done in grep.el instead of compile.el...

Anybody got any comments?

diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index 6753cf0b02..c88eb10693 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -1895,6 +1895,9 @@ compilation-start
               (and (derived-mode-p 'comint-mode)
                    (comint-term-environment))
 	      (list (format "INSIDE_EMACS=%s,compile" emacs-version))
+              ;; Some external programs (like "git grep") use a pager;
+              ;; defeat that.
+              (list "PAGER=")
 	      (copy-sequence process-environment))))
         (setq-local compilation-arguments
                     (list command mode name-function highlight-regexp))


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #19 received at 15775 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Dan Nicolaescu <dann <at> gnu.org>
Cc: 4359 <at> debbugs.gnu.org, 15775 <at> debbugs.gnu.org,
 Jan Djärv <jan.h.d <at> swipnet.se>, schwab <at> linux-m68k.org,
 Ulrich Neumerkel <ulrich <at> complang.tuwien.ac.at>
Subject: Re: bug#15775: 24.3.50; "WARNING: terminal is not fully functional"
 in Comint and Eshell
Date: Thu, 02 Jun 2022 15:07:06 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> This change makes "git grep" work as a grep command with `M-x grep' (if
> you remove --null).  It's shouldn't have a negative impact on much
> anything else (because no pagers should be used anywhere here), but
> perhaps it should be done in grep.el instead of compile.el...
>
> Anybody got any comments?

[...]

> +              ;; Some external programs (like "git grep") use a pager;
> +              ;; defeat that.
> +              (list "PAGER=")

Nobody had any comments, and it doesn't seem likely that this will
regress anything, so I've now pushed this to Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #24 received at 15775 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Lars Ingebrigtsen <larsi <at> gnus.org>, Dan Nicolaescu <dann <at> gnu.org>
Cc: 15775 <at> debbugs.gnu.org, Jan Djärv <jan.h.d <at> swipnet.se>,
 schwab <at> linux-m68k.org, Ulrich Neumerkel <ulrich <at> complang.tuwien.ac.at>,
 4359 <at> debbugs.gnu.org
Subject: Re: bug#15775: 24.3.50; "WARNING: terminal is not fully functional"
 in Comint and Eshell
Date: Sat, 4 Jun 2022 20:37:31 +0300

On 02.06.2022 16:07, Lars Ingebrigtsen wrote:
> Lars Ingebrigtsen<larsi <at> gnus.org>  writes:
> 
>> This change makes "git grep" work as a grep command with `M-x grep' (if
>> you remove --null).  It's shouldn't have a negative impact on much
>> anything else (because no pagers should be used anywhere here), but
>> perhaps it should be done in grep.el instead of compile.el...
>>
>> Anybody got any comments?
> [...]
> 
>> +              ;; Some external programs (like "git grep") use a pager;
>> +              ;; defeat that.
>> +              (list "PAGER=")
> Nobody had any comments, and it doesn't seem likely that this will
> regress anything, so I've now pushed this to Emacs 29.

Hi Lars,

Back when I filed bug#15775, Glenn merged it with bug#4359.

Looks like you are fixing only the latter bug here.

The package I mentioned in the original report, inf-ruby, derives from 
comint-mode.

It doesn't derive from compilation-mode, so the pushed change can't 
affect it or fix the problem there.

N.B.: Even a decade later, I still have

  (setenv "PAGER" (executable-find "cat"))

in my init script.

Message #31 received at 15775 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: schwab <at> linux-m68k.org, Ulrich Neumerkel <ulrich <at> complang.tuwien.ac.at>,
 Dan Nicolaescu <dann <at> gnu.org>, 15775 <at> debbugs.gnu.org,
 Jan Djärv <jan.h.d <at> swipnet.se>, 4359 <at> debbugs.gnu.org
Subject: Re: bug#15775: 24.3.50; "WARNING: terminal is not fully functional"
 in Comint and Eshell
Date: Sun, 05 Jun 2022 16:15:06 +0200

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> Back when I filed bug#15775, Glenn merged it with bug#4359.
>
> Looks like you are fixing only the latter bug here.

Sorry; didn't catch that.  I've now unmerged the bug reports, and
reopened bug#15775.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.