GNU bug report logs - #15939
[PATCH] nndoc.el: Add new debbugs-db nndoc type

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 15939 in the body.
You can then email your comments to 15939 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ivan Shmakov <ivan <at> siamics.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] nndoc.el: Add new debbugs-db nndoc type 
Date: Wed, 20 Nov 2013 20:07:54 +0000

	Given that Debbugs is used for Emacs development itself, it
	seems quite appropriate to add Debbugs .log file support to the
	nndoc Gnus’ select method.  Please thus consider the following
	patch.

	An example Debbugs .log file to test the patched nndoc against
	could be retrieved with, say:

$ rsync -t -- \
      rsync://bugs-mirror.debian.org/bts-spool-db/83/688283.log \
      688283.log 

	(Then: G f 688283.log RET in the *Group* buffer.)

--- lisp/gnus/nndoc.el.~1~
+++ lisp/gnus/nndoc.el	2013-11-20 19:58:04.000000000 +0000
@@ -56,6 +56,10 @@ from the document.")
   `((mmdf
      (article-begin .  "^\^A\^A\^A\^A\n")
      (body-end .  "^\^A\^A\^A\^A\n"))
+    (debbugs-db
+     (file-begin    . "^\005")
+     (article-begin . "^[\005\007]\n")
+     (body-end      . "^\003"))
     (mime-digest
      (article-begin . "")
      (head-begin . "^ ?\n")
@@ -460,6 +464,10 @@ from the document.")
   (when (looking-at "\^A\^A\^A\^A$")
     t))
 
+(defun nndoc-debbugs-db-type-p ()
+  (when (looking-at "\006$")
+    t))
+
 (defun nndoc-news-type-p ()
   (when (looking-at "^Path:.*\n")
     t))

-- 
FSF associate member #7257

Message #8 received at 15939 <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Ivan Shmakov <ivan <at> siamics.net>
Cc: 15939 <at> debbugs.gnu.org
Subject: Re: bug#15939: [PATCH] nndoc.el: Add new debbugs-db nndoc type
Date: Thu, 21 Nov 2013 11:19:33 -0500

On Wed, 20 Nov 2013 20:07:54 +0000 Ivan Shmakov <ivan <at> siamics.net> wrote: 

IS> Given that Debbugs is used for Emacs development itself, it
IS> seems quite appropriate to add Debbugs .log file support to the
IS> nndoc Gnus’ select method.	Please thus consider the following
IS> patch.

This looks good to me.  I don't know if this qualifies as a tiny change,
though.  I see only one tiny change from you (from an older address, I
assume):

lisp/ChangeLog.14:2008-11-21  Ivan Shmakov  <oneingray <at> gmail.com>  (tiny change)

so I need to know if this is a tiny change and if not, if you have
assignment papers on file.

Thanks
Ted

Message #11 received at 15939 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Ivan Shmakov <ivan <at> siamics.net>
Cc: 15939 <at> debbugs.gnu.org
Subject: Re: bug#15939: [PATCH] nndoc.el: Add new debbugs-db nndoc type
Date: Thu, 21 Nov 2013 11:27:52 -0500

Ted Zlatanov wrote:

> I don't know if this qualifies as a tiny change, though.

By itself, it does. (It's 7 fairly trivial lines of code, surely this is
obvious?)

Message #14 received at 15939 <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 15939 <at> debbugs.gnu.org, Ivan Shmakov <ivan <at> siamics.net>
Subject: Re: bug#15939: [PATCH] nndoc.el: Add new debbugs-db nndoc type
Date: Thu, 21 Nov 2013 12:14:34 -0500

On Thu, 21 Nov 2013 11:27:52 -0500 Glenn Morris <rgm <at> gnu.org> wrote: 

GM> Ted Zlatanov wrote:
>> I don't know if this qualifies as a tiny change, though.

GM> By itself, it does. (It's 7 fairly trivial lines of code, surely this is
GM> obvious?)

Thanks for confirming, I wasn't sure.  Pushed to the Gnus Git repo, from
where it will be synchronized to Emacs.

Thanks!
Ted

commit 852d65fb565743a193d30838cc8e5dde64bbbb3c
Author: Ted Zlatanov <tzz <at> lifelogs.com>
Date:   Thu Nov 21 12:11:43 2013 -0500

    * nndoc.el (nndoc-type-alist): Support debbugs .log files.

Message #19 received at 15939-done <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 15939-done <at> debbugs.gnu.org, Ivan Shmakov <ivan <at> siamics.net>
Subject: Re: bug#15939: [PATCH] nndoc.el: Add new debbugs-db nndoc type
Date: Thu, 21 Nov 2013 13:52:18 -0500

Marking as done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.