GNU bug report logs - #16001
[5ef95e85] fails to build with --enable-gcc-warnings in some configurations

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16001 in the body.
You can then email your comments to 16001 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ivan Shmakov <oneingray <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Ivan Shmakov <oneingray <at> gmail.com>
Subject: [5ef95e85] fails to build with --enable-gcc-warnings in some
 configurations
Date: Fri, 29 Nov 2013 17:02:24 +0000

	As of 5ef95e85, building with GCC 4.8.2, --enable-gcc-warnings,
	--without-x-toolkit, and GnuTLS 2, fails with:

../../src/xfaces.c:914:0: error: macro "NEAR_SAME_COLOR_THRESHOLD" is not used [-Werror=unused-macros]
 #define NEAR_SAME_COLOR_THRESHOLD 30000
 ^
cc1: all warnings being treated as errors

../../src/gnutls.c:266:1: error: 'gnutls_audit_log_function' defined but not used [-Werror=unused-function]
 gnutls_audit_log_function (gnutls_session_t session, const char* string)
 ^
cc1: all warnings being treated as errors

	The causes are:

	• the NEAR_SAME_COLOR_THRESHOLD macro’s definition is not
	  properly guarded with #ifdef HAVE_WINDOW_SYSTEM;

	• both the declaration and the definition of
	  gnutls_audit_log_function () are not properly guarded with
	  #ifdef HAVE_GNUTLS3.

	Adding the respective guards fixes both of the GCC errors.

	The issue seem not to be fixed in e7203144, either.

-- 
FSF associate member #7257

Message #10 received at 16001-done <at> debbugs.gnu.org (full text, mbox):

From: Jan Djärv <jan.h.d <at> swipnet.se>
To: Ivan Shmakov <oneingray <at> gmail.com>
Cc: 16001-done <at> debbugs.gnu.org
Subject: Re: bug#16001: [5ef95e85] fails to build with --enable-gcc-warnings
 in some configurations
Date: Sat, 30 Nov 2013 14:32:30 +0100

Hello.

There are lot of new errors in window.c, xterm.c and xdisp.c after the pixelwise resize checkin, so this report is kind of obsolete.  But I checked in fixes for the issues below.

	Jan D.

29 nov 2013 kl. 18:02 skrev Ivan Shmakov <oneingray <at> gmail.com>:

> 	As of 5ef95e85, building with GCC 4.8.2, --enable-gcc-warnings,
> 	--without-x-toolkit, and GnuTLS 2, fails with:
> 
> ../../src/xfaces.c:914:0: error: macro "NEAR_SAME_COLOR_THRESHOLD" is not used [-Werror=unused-macros]
> #define NEAR_SAME_COLOR_THRESHOLD 30000
> ^
> cc1: all warnings being treated as errors
> 
> ../../src/gnutls.c:266:1: error: 'gnutls_audit_log_function' defined but not used [-Werror=unused-function]
> gnutls_audit_log_function (gnutls_session_t session, const char* string)
> ^
> cc1: all warnings being treated as errors
> 
> 	The causes are:
> 
> 	• the NEAR_SAME_COLOR_THRESHOLD macro’s definition is not
> 	  properly guarded with #ifdef HAVE_WINDOW_SYSTEM;
> 
> 	• both the declaration and the definition of
> 	  gnutls_audit_log_function () are not properly guarded with
> 	  #ifdef HAVE_GNUTLS3.
> 
> 	Adding the respective guards fixes both of the GCC errors.
> 
> 	The issue seem not to be fixed in e7203144, either.
> 
> -- 
> FSF associate member #7257
> 
> 

Message #13 received at 16001 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: 16001 <at> debbugs.gnu.org, jan.h.d <at> swipnet.se, oneingray <at> gmail.com
Subject: Re: bug#16001: [5ef95e85] fails to build with --enable-gcc-warnings
 in	some configurations
Date: Sat, 30 Nov 2013 17:26:56 +0100

> There are lot of new errors in window.c, xterm.c and xdisp.c after the pixelwise resize checkin, so this report is kind of obsolete.

Juanma already fixed some of them, I tried to fix the rest.  Please have a look.

Thanks, martin

Message #16 received at 16001 <at> debbugs.gnu.org (full text, mbox):

From: Ivan Shmakov <oneingray <at> gmail.com>
To: 16001 <at> debbugs.gnu.org
Cc: Ivan Shmakov <oneingray <at> gmail.com>
Subject: Re: bug#16001: [5ef95e85] fails to build with --enable-gcc-warnings
 in some configurations
Date: Sat, 30 Nov 2013 18:15:45 +0000

>>>>> Jan Djärv <jan.h.d <at> swipnet.se> writes:
>>>>> 29 nov 2013 kl. 18:02 skrev Ivan Shmakov <oneingray <at> gmail.com>:

 >> As of 5ef95e85, building with GCC 4.8.2, --enable-gcc-warnings,
 >> --without-x-toolkit, and GnuTLS 2, fails with:

[…]

 > There are lot of new errors in window.c, xterm.c and xdisp.c after
 > the pixelwise resize checkin, so this report is kind of obsolete.

	JFTR, while I didn’t look at the current state of the code,
	“pixelwise resize” seem to be something related to the Emacs
	support for graphical terminals.  However, the xfaces.c issue is
	likely to only manifest itself when building Emacs with no such
	support enabled (IOW, character cell only; which is what I did.)

	The gnutls.c issue isn’t entirely dissimilar, as it’s likely to
	arise only in some configurations, but not the others.

 > But I checked in fixes for the issues below.

	ACK, thanks.

-- 
FSF associate member #7257

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.