GNU bug report logs - #16121
24.3.50; Type error in ERT

Previous Next

Package: emacs;

Reported by: Sebastian Wiesner <lunaryorn <at> gmail.com>

Date: Thu, 12 Dec 2013 12:25:01 UTC

Severity: normal

Tags: patch

Found in version 24.3.50

Fixed in version 24.4

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16121 in the body.
You can then email your comments to 16121 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#16121; Package emacs. (Thu, 12 Dec 2013 12:25:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Sebastian Wiesner <lunaryorn <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 12 Dec 2013 12:25:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sebastian Wiesner <lunaryorn <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; Type error in ERT
Date: Thu, 12 Dec 2013 13:23:45 +0100

`ert-select-tests' tries to match a symbol against a string with
`string-match', causing a `wrong-type-argument' error.

The culprit is in the `string' branch of the `cl-etypecase' expression,
where the following expression is used as predicate for
`cl-remove-if-not':

(and (ert-test-name test)
     (string-match selector (ert-test-name test)))

However, `ert-test-name' returns a *symbol* with the name of the test.

The error is fixed by applying `symbol-name' to the return value of
`ert-test-name':

(and (ert-test-name test)
     (string-match selector (symbol-name (ert-test-name test))))
Reply sent to Glenn Morris <rgm <at> gnu.org>:
You have taken responsibility. (Thu, 19 Dec 2013 08:16:02 GMT) Full text and rfc822 format available.
Notification sent to Sebastian Wiesner <lunaryorn <at> gmail.com>:
bug acknowledged by developer. (Thu, 19 Dec 2013 08:16:06 GMT) Full text and rfc822 format available.

Message #10 received at 16121-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 16121-done <at> debbugs.gnu.org
Subject: Re: bug#16121: 24.3.50; Type error in ERT
Date: Thu, 19 Dec 2013 03:15:12 -0500

Version: 24.4

Thanks.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 16 Jan 2014 12:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 10 years and 123 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.