GNU bug report logs - #16138
24.3; skeleton-end-hook not run

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16138 in the body.
You can then email your comments to 16138 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3; skeleton-end-hook not run
Date: Sat, 14 Dec 2013 15:20:32 +0800

I had to make use of skeleton-end-hook and was surprised to find that it
actually doesn't work.

1. Emacs -q
2. (setq skeleton-pair t)
3. (global-set-key "(" 'skeleton-pair-insert-maybe)
4. (add-hook 'skeleton-end-hook (lambda () (error "bomb!!!")))

now try ( to trigger skeleton-pair-insert-maybe in some buffer and
nothing should happen.

Leo

Message #8 received at 16138 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Leo Liu <sdl.web <at> gmail.com>
Cc: 16138 <at> debbugs.gnu.org
Subject: Re: bug#16138: 24.3; skeleton-end-hook not run
Date: Wed, 18 Dec 2013 13:39:42 -0500

skeleton-pair-insert-maybe explicitly ignores skeleton-end-hook.
If you want to change that, I imagine you have to factor out the default
non-nil value of skeleton-end-hook.

Message #11 received at 16138 <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 16138 <at> debbugs.gnu.org
Subject: Re: bug#16138: 24.3; skeleton-end-hook not run
Date: Thu, 19 Dec 2013 10:54:38 +0800

On 2013-12-19 02:39 +0800, Glenn Morris wrote:
> skeleton-pair-insert-maybe explicitly ignores skeleton-end-hook.
> If you want to change that, I imagine you have to factor out the default
> non-nil value of skeleton-end-hook.

I see. It was let-bound to nil. Any idea why it was disabled there?

Leo

Message #14 received at 16138 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Leo Liu <sdl.web <at> gmail.com>
Cc: Glenn Morris <rgm <at> gnu.org>, 16138 <at> debbugs.gnu.org
Subject: Re: bug#16138: 24.3; skeleton-end-hook not run
Date: Thu, 19 Dec 2013 08:38:31 -0500

>> skeleton-pair-insert-maybe explicitly ignores skeleton-end-hook.
>> If you want to change that, I imagine you have to factor out the default
>> non-nil value of skeleton-end-hook.
> I see. It was let-bound to nil. Any idea why it was disabled there?

Because the default value inserts a newline, which is not desired for
paren-pairs.


        Stefan

Message #19 received at 16138-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: Glenn Morris <rgm <at> gnu.org>, 16138-done <at> debbugs.gnu.org
Subject: Re: bug#16138: 24.3; skeleton-end-hook not run
Date: Fri, 20 Dec 2013 08:41:56 +0800

Version: 24.4

On 2013-12-19 21:38 +0800, Stefan Monnier wrote:
> Because the default value inserts a newline, which is not desired for
> paren-pairs.

I fix it by let-binding skeleton-end-newline to nil instead. It is odd
that skeleton-end-hook is not called at all.

Leo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.