GNU bug report logs - #16144
24.3.50; [PATCH] eww: Don't hide windows with browsing bookmark list.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16144 in the body.
You can then email your comments to 16144 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; [PATCH] eww: Don't hide windows with browsing bookmark list.
Date: Sat, 14 Dec 2013 23:18:27 +0900

I changed bookmark-browse's behavior. This problem gets more serious, if
many many windows are opend...

* Reproduce the problem.
 Step1. Open two windows, one is *eww* and the other is not eww.
 Step2. In the *eww*, open the bookmark list with "B" key. (Now one is *eww*, the other is *eww bookmarks*)
 Step3. Select one URL in the bookmarklist(eww-bookmark-browse).
 Step4. Now emacs window is only *eww*. <- #This is the problem.


Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>

        * net/eww.el (eww-bookmark-browse): Don't hide windows with
          browsing bookmark list.

---
 lisp/net/eww.el | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 34c6728..c4e948b 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -1179,10 +1179,8 @@ Differences in #targets are ignored."
   (let ((bookmark (get-text-property (line-beginning-position) 'eww-bookmark)))
     (unless bookmark
       (error "No bookmark on the current line"))
-    ;; We wish to leave this window, but if it's the only window here,
-    ;; just let it remain.
-    (ignore-errors
-      (delete-window))
+    (eww-bookmark-quit)
+    (pop-to-buffer "*eww*")
     (eww-browse-url (plist-get bookmark :url))))

 (defun eww-next-bookmark ()
-- 
1.8.3.1

Message #8 received at 16144 <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
Cc: 16144 <at> debbugs.gnu.org, Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Subject: Re: bug#16144: 24.3.50;
 [PATCH] eww: Don't hide windows with browsing bookmark list.
Date: Sat, 21 Dec 2013 15:45:52 -0500

On Sat, 14 Dec 2013 23:18:27 +0900 Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com> wrote: 

KN> I changed bookmark-browse's behavior. This problem gets more serious, if
KN> many many windows are opend...

KN> * Reproduce the problem.
KN>  Step1. Open two windows, one is *eww* and the other is not eww.
KN>  Step2. In the *eww*, open the bookmark list with "B" key. (Now one is *eww*, the other is *eww bookmarks*)
KN>  Step3. Select one URL in the bookmarklist(eww-bookmark-browse).
KN>  Step4. Now emacs window is only *eww*. <- #This is the problem.

I like the suggestion but am not sure if this should a defcustom.  I
actually would like, when selecting a bookmark, to have the option to go
into a full-screen (single window) configuration for eww.  Leaving for Lars.

Ted

Message #11 received at 16144 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
Cc: 16144 <at> debbugs.gnu.org
Subject: Re: bug#16144: 24.3.50;
 [PATCH] eww: Don't hide windows with browsing bookmark list.
Date: Tue, 24 Dec 2013 08:02:31 +0100

Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com> writes:

>         * net/eww.el (eww-bookmark-browse): Don't hide windows with
>           browsing bookmark list.

This doesn't really help much.  If you're starting with one window, the
patch will leave you with two windows, which isn't what you want.  I
don't think it makes sense for the pop-up-a-new-buffer functions to
necessarily restore the original window layout after the buffer goes
away, anyway.  It's not a "modal" extra buffer like hitting TAB when
doing file completion...

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Message #14 received at 16144 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
Cc: 16144 <at> debbugs.gnu.org
Subject: Re: bug#16144: 24.3.50;
 [PATCH] eww: Don't hide windows with browsing bookmark list.
Date: Tue, 24 Dec 2013 08:27:19 +0100

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> I don't think it makes sense for the pop-up-a-new-buffer functions to
> necessarily restore the original window layout after the buffer goes
> away, anyway.

Or perhaps it should.  I've now made it just save the window
configuration and restore it.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Message #21 received at 16144 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 16144 <at> debbugs.gnu.org, Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
Subject: Re: bug#16144: 24.3.50;
 [PATCH] eww: Don't hide windows with browsing bookmark list.
Date: Tue, 24 Dec 2013 09:48:25 -0500

>> I don't think it makes sense for the pop-up-a-new-buffer functions to
>> necessarily restore the original window layout after the buffer goes
>> away, anyway.
> Or perhaps it should.  I've now made it just save the window
> configuration and restore it.

Don't.  This is the wrong way to go about it.
Nowadays, quit-window tries to undo the effect of pop-to-buffer, so try
to get this to work instead.  In the "quickly look at something case" it
should work just as well as saving/restoring the window config, but in
the more complex cases (e.g. pop to a new frame, or stick around for
a long time with lots of other window/buffer movements) it will
behave better.


        Stefan

Message #24 received at 16144 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: 16144 <at> debbugs.gnu.org, Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
Subject: Re: bug#16144: 24.3.50;
 [PATCH] eww: Don't hide windows with browsing bookmark list.
Date: Tue, 24 Dec 2013 19:08:47 +0100

Stefan Monnier <monnier <at> IRO.UMontreal.CA> writes:

> Nowadays, quit-window tries to undo the effect of pop-to-buffer, so try
> to get this to work instead.

Nice.  I've now made it just call `quit-window' instead.  Seems to work
for me.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.