GNU bug report logs - #16222
Installing ELPA packages complains about :keywords in define-package

Previous Next

Package: emacs;

Reported by: Juanma Barranquero <lekktu <at> gmail.com>

Date: Mon, 23 Dec 2013 01:45:02 UTC

Severity: important

Merged with 16441

Found in version 24.3

Done: Dmitry Gutov <dgutov <at> yandex.ru>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16222 in the body.
You can then email your comments to 16222 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#16222; Package emacs. (Mon, 23 Dec 2013 01:45:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Juanma Barranquero <lekktu <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 23 Dec 2013 01:45:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Bug-Gnu-Emacs <bug-gnu-emacs <at> gnu.org>
Subject: Installing ELPA packages complains about :keywords in define-package
Date: Mon, 23 Dec 2013 02:42:57 +0100
On Tue, Dec 17, 2013 at 10:06 PM, Stephen Berman <stephen.berman <at> gmx.net> wrote:

> Leaving directory `/home/steve/.emacs.d/elpa/nlinum-1.1'
> Compiling file /home/steve/.emacs.d/elpa/nlinum-1.1/nlinum-pkg.el at Tue Dec
> 17 13:33:54 2013
> Entering directory `/home/steve/.emacs.d/elpa/nlinum-1.1/'
> nlinum-pkg.el:1:1:Warning: `"convenience"' is a malformed function
> Compiling file /home/steve/.emacs.d/elpa/nlinum-1.1/nlinum.el at Tue Dec 17
> 13:33:54 2013
> Compiling no file at Tue Dec 17 13:36:31 2013

The problem is not nlinum-specific. Installing anything from ELPA
complains about the :keywords in the define-package:

In toplevel form:
debbugs-pkg.el:1:1:Warning: `"comm"' is a malformed function

In toplevel form:
rainbow-mode-pkg.el:1:1:Warning: `"faces"' is a malformed function

etc.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#16222; Package emacs. (Mon, 23 Dec 2013 15:02:02 GMT) Full text and rfc822 format available.

Message #8 received at 16222 <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 16222 <at> debbugs.gnu.org
Subject: Re: bug#16222: Installing ELPA packages complains about :keywords in
 define-package
Date: Mon, 23 Dec 2013 10:02:42 -0500
On Mon, 23 Dec 2013 02:42:57 +0100 Juanma Barranquero <lekktu <at> gmail.com> wrote: 

JB> On Tue, Dec 17, 2013 at 10:06 PM, Stephen Berman <stephen.berman <at> gmx.net> wrote:
>> Leaving directory `/home/steve/.emacs.d/elpa/nlinum-1.1'
>> Compiling file /home/steve/.emacs.d/elpa/nlinum-1.1/nlinum-pkg.el at Tue Dec
>> 17 13:33:54 2013
>> Entering directory `/home/steve/.emacs.d/elpa/nlinum-1.1/'
>> nlinum-pkg.el:1:1:Warning: `"convenience"' is a malformed function
>> Compiling file /home/steve/.emacs.d/elpa/nlinum-1.1/nlinum.el at Tue Dec 17
>> 13:33:54 2013
>> Compiling no file at Tue Dec 17 13:36:31 2013

JB> The problem is not nlinum-specific. Installing anything from ELPA
JB> complains about the :keywords in the define-package:

JB> In toplevel form:
JB> debbugs-pkg.el:1:1:Warning: `"comm"' is a malformed function

JB> In toplevel form:
JB> rainbow-mode-pkg.el:1:1:Warning: `"faces"' is a malformed function

JB> etc.

Can you provide a full bug description, Emacs version, etc.?  I can't
find it here (I know there's an emacs-devel discussion but the bug
report is incomplete as is).

Thanks
Ted




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#16222; Package emacs. (Mon, 23 Dec 2013 15:15:01 GMT) Full text and rfc822 format available.

Message #11 received at 16222 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Ted Zlatanov <tzz <at> lifelogs.com>
Cc: 16222 <at> debbugs.gnu.org
Subject: Re: bug#16222: Installing ELPA packages complains about :keywords in
 define-package
Date: Mon, 23 Dec 2013 16:13:32 +0100
On Mon, Dec 23, 2013 at 4:02 PM, Ted Zlatanov <tzz <at> lifelogs.com> wrote:

> Can you provide a full bug description, Emacs version, etc.?  I can't
> find it here (I know there's an emacs-devel discussion but the bug
> report is incomplete as is).

With an Emacs from trunk, of a few days ago, I just did M-x
list-packages, then U (packages to update where debbugs and
rainbow-mode), then x, and voilĂ .

Aren't you able to reproduce it?

   J




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#16222; Package emacs. (Mon, 23 Dec 2013 22:57:02 GMT) Full text and rfc822 format available.

Message #14 received at 16222 <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 16222 <at> debbugs.gnu.org
Subject: Re: bug#16222: Installing ELPA packages complains about :keywords in
 define-package
Date: Mon, 23 Dec 2013 17:57:52 -0500
On Mon, 23 Dec 2013 16:13:32 +0100 Juanma Barranquero <lekktu <at> gmail.com> wrote: 

JB> On Mon, Dec 23, 2013 at 4:02 PM, Ted Zlatanov <tzz <at> lifelogs.com> wrote:
>> Can you provide a full bug description, Emacs version, etc.?  I can't
>> find it here (I know there's an emacs-devel discussion but the bug
>> report is incomplete as is).

JB> With an Emacs from trunk, of a few days ago, I just did M-x
JB> list-packages, then U (packages to update where debbugs and
JB> rainbow-mode), then x, and voilĂ .

JB> Aren't you able to reproduce it?

I can reproduce it but don't see why you couldn't make a proper bug
report with a version (for the record, mine is 24.3.50.1, compiled today).

Stefan: I think the problem is `package--alist-to-plist'.  The generated
PACKAGE-pkg.el has, for example:

(define-package "ack" "1.3" "Interface to ack-like source code search tools" 'nil :keywords ("tools" "processes" "convenience") :url "https://github.com/leoliu/ack-el")

(define-package "nlinum" "1.1" "Show line numbers in the margin" 'nil :url "http://elpa.gnu.org/packages/nlinum.html" :keywords ("convenience"))

If I quote the keywords, e.g.

  :keywords '("convenience")

then the function call works but I don't really understand the creative
mix of `defstruct' and the `define-package' funcall that errors out, so
I couldn't write the fix and test it.  I hope you or someone else has a
chance to do it... I may try it again tomorrow if no one else does.

Ted




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#16222; Package emacs. (Tue, 24 Dec 2013 00:03:01 GMT) Full text and rfc822 format available.

Message #17 received at 16222 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Ted Zlatanov <tzz <at> lifelogs.com>
Cc: 16222 <at> debbugs.gnu.org
Subject: Re: bug#16222: Installing ELPA packages complains about :keywords in
 define-package
Date: Tue, 24 Dec 2013 01:01:56 +0100
On Mon, Dec 23, 2013 at 11:57 PM, Ted Zlatanov <tzz <at> lifelogs.com> wrote:

> don't see why you couldn't make a proper bug
> report with a version

I dislike report-emacs-bug. Anyway, as I usually hang 'round
emacs-devel, bugs I report are for the trunk unless I say otherwise.
And I'm available to provide any further information requested.

> (for the record, mine is 24.3.50.1, compiled today).

So is mine.

    J




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#16222; Package emacs. (Tue, 24 Dec 2013 03:44:02 GMT) Full text and rfc822 format available.

Message #20 received at 16222 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 16222 <at> debbugs.gnu.org
Subject: Re: bug#16222: Installing ELPA packages complains about :keywords in
 define-package
Date: Mon, 23 Dec 2013 22:43:17 -0500
> Stefan: I think the problem is `package--alist-to-plist'.  The generated
> PACKAGE-pkg.el has, for example:

No, the problem is that *-pkg.el should not be compiled (it's not
"load"ed either): it's a file using the Elisp `sexp' syntax, but it's
not a file written in Elisp.


        Stefan




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#16222; Package emacs. (Tue, 24 Dec 2013 13:37:01 GMT) Full text and rfc822 format available.

Message #23 received at 16222 <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: Juanma Barranquero <lekktu <at> gmail.com>, 16222 <at> debbugs.gnu.org
Subject: Re: bug#16222: Installing ELPA packages complains about :keywords in
 define-package
Date: Tue, 24 Dec 2013 08:37:22 -0500
On Mon, 23 Dec 2013 22:43:17 -0500 Stefan Monnier <monnier <at> IRO.UMontreal.CA> wrote: 

>> Stefan: I think the problem is `package--alist-to-plist'.  The generated
>> PACKAGE-pkg.el has, for example:

SM> No, the problem is that *-pkg.el should not be compiled (it's not
SM> "load"ed either): it's a file using the Elisp `sexp' syntax, but it's
SM> not a file written in Elisp.

OK, is it fixable?

Ted




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#16222; Package emacs. (Tue, 24 Dec 2013 14:56:02 GMT) Full text and rfc822 format available.

Message #26 received at 16222 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 16222 <at> debbugs.gnu.org
Subject: Re: bug#16222: Installing ELPA packages complains about :keywords in
 define-package
Date: Tue, 24 Dec 2013 09:55:00 -0500
>>> Stefan: I think the problem is `package--alist-to-plist'.  The generated
>>> PACKAGE-pkg.el has, for example:
SM> No, the problem is that *-pkg.el should not be compiled (it's not
SM> "load"ed either): it's a file using the Elisp `sexp' syntax, but it's
SM> not a file written in Elisp.
> OK, is it fixable?

Of course: get the byte-compiler to skip those files.


        Stefan





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#16222; Package emacs. (Tue, 24 Dec 2013 15:22:02 GMT) Full text and rfc822 format available.

Message #29 received at 16222 <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: Juanma Barranquero <lekktu <at> gmail.com>, 16222 <at> debbugs.gnu.org
Subject: Re: bug#16222: Installing ELPA packages complains about :keywords in
 define-package
Date: Tue, 24 Dec 2013 10:23:04 -0500
On Tue, 24 Dec 2013 09:55:00 -0500 Stefan Monnier <monnier <at> IRO.UMontreal.CA> wrote: 

>>>> Stefan: I think the problem is `package--alist-to-plist'.  The generated
>>>> PACKAGE-pkg.el has, for example:
SM> No, the problem is that *-pkg.el should not be compiled (it's not
SM> "load"ed either): it's a file using the Elisp `sexp' syntax, but it's
SM> not a file written in Elisp.
>> OK, is it fixable?

SM> Of course: get the byte-compiler to skip those files.

1) Why is *-pkg.el written in this bizarro syntax and not something that
compiles cleanly?  IOW if it's going to be pure data, why pretend it's a
funcall?  I'd rather rename it to *-pkg.data or something and eliminate
any chance of this problem recurring.  The .el extension is wrong,
either way.

2) If you'd rather keep it as a confusingly-almost-ELisp file, can the
problem be solved by ";; no-byte-compile: t" in the local variables, or
does this function have to be changed?

#+begin_src lisp
(defun package--compile (pkg-desc)
  "Byte-compile installed package PKG-DESC."
  (package-activate-1 pkg-desc)
  (byte-recompile-directory (package-desc-dir pkg-desc) 0 t))
#+end_src

Thanks
Ted




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#16222; Package emacs. (Tue, 24 Dec 2013 16:24:01 GMT) Full text and rfc822 format available.

Message #32 received at 16222 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 16222 <at> debbugs.gnu.org
Subject: Re: bug#16222: Installing ELPA packages complains about :keywords in
 define-package
Date: Tue, 24 Dec 2013 11:23:10 -0500
> 1) Why is *-pkg.el written in this bizarro syntax and not something that
> compiles cleanly?

Hysterical raisins!

> IOW if it's going to be pure data, why pretend it's a funcall?
> I'd rather rename it to *-pkg.data or something and eliminate any
> chance of this problem recurring.  The .el extension is wrong,
> either way.

If you ask me, the <foo>-autoloads.el and <foo>-pkg.el should be combined
into a single file whose name is constant (i.e. does not include <foo>).
But that's a change in the format of ELPA packages, so it's a bit
delicate to do: it will have to be done in steps (first add the new
combined file in the packages, add support for it in package.el, then
wait for everyone to start using the newer package.el, then start
getting rid of the old redundant files).

By the way, I didn't notice that the problem was introduced by the new
":keywords" argument, so we should change it so that its argument is
quoted (so it works like a function call again).

> (defun package--compile (pkg-desc)
>   "Byte-compile installed package PKG-DESC."
>   (package-activate-1 pkg-desc)
>   (byte-recompile-directory (package-desc-dir pkg-desc) 0 t))

Yes, this should skip the *-pkg.el files.


        Stefan




Merged 16222 16441. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Tue, 14 Jan 2014 17:01:02 GMT) Full text and rfc822 format available.

Severity set to 'important' from 'normal' Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Tue, 14 Jan 2014 17:01:03 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#16222; Package emacs. (Tue, 14 Jan 2014 18:20:02 GMT) Full text and rfc822 format available.

Message #39 received at 16222 <at> debbugs.gnu.org (full text, mbox):

From: Tom Willis <twillis <at> topgunhq.com>
To: 16222 <at> debbugs.gnu.org
Subject: latest js2-mode from elpa causes backtrace during emacs initialization
Date: Tue, 14 Jan 2014 13:16:53 -0500
Apparently it's not js2-mode authors fault. All the details are at
github along with how I fixed it(missing a quote). I have no idea who
maintains that file though.

https://github.com/mooz/js2-mode/issues/129#issuecomment-32290865

Tom Willis




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#16222; Package emacs. (Wed, 15 Jan 2014 05:04:01 GMT) Full text and rfc822 format available.

Message #42 received at 16222 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: Juanma Barranquero <lekktu <at> gmail.com>, 16222 <at> debbugs.gnu.org
Subject: Re: bug#16222: Installing ELPA packages complains about :keywords in
 define-package
Date: Wed, 15 Jan 2014 07:02:53 +0200
Stefan Monnier <monnier <at> IRO.UMontreal.CA> writes:

> By the way, I didn't notice that the problem was introduced by the new
> ":keywords" argument, so we should change it so that its argument is
> quoted (so it works like a function call again).

Done, with 2b96305 in elpa and 116030 in emacs.

Now we need a package rebuild to test it.

I don't really like the solution on the Emacs side (treating :keywords
value specially), but quoting and unquoting every element in extras (in
`package--alist-to-plist' and `package-desc-from-define' respectively)
wouldn't look particularly good to me either.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#16222; Package emacs. (Wed, 15 Jan 2014 15:31:02 GMT) Full text and rfc822 format available.

Message #45 received at 16222 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: Juanma Barranquero <lekktu <at> gmail.com>, 16222 <at> debbugs.gnu.org
Subject: Re: bug#16222: Installing ELPA packages complains about :keywords in
 define-package
Date: Wed, 15 Jan 2014 10:29:57 -0500
> Done, with 2b96305 in elpa and 116030 in emacs.

Thanks.

> Now we need a package rebuild to test it.

Should happen tonight.


        Stefan




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#16222; Package emacs. (Thu, 16 Jan 2014 13:00:02 GMT) Full text and rfc822 format available.

Message #48 received at 16222 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Juanma Barranquero <lekktu <at> gmail.com>, 16222 <at> debbugs.gnu.org
Subject: Re: bug#16222: Installing ELPA packages complains about :keywords
 in define-package
Date: Thu, 16 Jan 2014 14:58:50 +0200
On 15.01.2014 17:29, Stefan Monnier wrote:
>> Now we need a package rebuild to test it.
>
> Should happen tonight.

I'm not sure if you've triggered rebuild for all packages or just 
expected that to happen to the ones pushed after the fix (e.g. company), 
but it didn't work either way.

I've tested the change locally, and it did add a quote before the 
:keywords value, but that didn't happen in company-pkg.el in the 
newly-generated http://elpa.gnu.org/packages/company-0.6.13.tar.

Maybe someone needs to delete all affected -pkg.el files on the server 
first, and then rebuild the containing packages.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#16222; Package emacs. (Thu, 16 Jan 2014 16:19:01 GMT) Full text and rfc822 format available.

Message #51 received at 16222 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: Juanma Barranquero <lekktu <at> gmail.com>, 16222 <at> debbugs.gnu.org
Subject: Re: bug#16222: Installing ELPA packages complains about :keywords in
 define-package
Date: Thu, 16 Jan 2014 11:18:53 -0500
>>> Now we need a package rebuild to test it.
>> Should happen tonight.
> I'm not sure if you've triggered rebuild for all packages or just expected
> that to happen to the ones pushed after the fix (e.g. company), but it
> didn't work either way.

No, I just failed to think.  This morning, when going to check the
result I realized that rebuild wouldn't help, since old packages are
left alone.
So I removed the 2 packages that suffered from this problem (the latest
js2-mode and company) and forced a manual rebuild of them.  At least on
the elpa.gnu.org side, this is fixed now, indeed.

> Maybe someone needs to delete all affected -pkg.el files on the server
> first, and then rebuild the containing packages.

Yup, that's what I had to do.  Sorry for forgetting to turn on my brain.


        Stefan




Reply sent to Dmitry Gutov <dgutov <at> yandex.ru>:
You have taken responsibility. (Thu, 16 Jan 2014 17:05:02 GMT) Full text and rfc822 format available.

Notification sent to Juanma Barranquero <lekktu <at> gmail.com>:
bug acknowledged by developer. (Thu, 16 Jan 2014 17:05:04 GMT) Full text and rfc822 format available.

Message #56 received at 16222-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Juanma Barranquero <lekktu <at> gmail.com>, 16222-done <at> debbugs.gnu.org
Subject: Re: bug#16222: Installing ELPA packages complains about :keywords
 in define-package
Date: Thu, 16 Jan 2014 19:04:07 +0200
On 16.01.2014 18:18, Stefan Monnier wrote:
> So I removed the 2 packages that suffered from this problem (the latest
> js2-mode and company) and forced a manual rebuild of them.  At least on
> the elpa.gnu.org side, this is fixed now, indeed.

Thank you, it looks fine now.

I've made `package-desc-keywords' private so that someone can implement 
a more general solution later, but the immediate issue seems to be fixed.




Reply sent to Dmitry Gutov <dgutov <at> yandex.ru>:
You have taken responsibility. (Thu, 16 Jan 2014 17:05:04 GMT) Full text and rfc822 format available.

Notification sent to Kevin Brubeck Unhammer <unhammer <at> fsfe.org>:
bug acknowledged by developer. (Thu, 16 Jan 2014 17:05:06 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#16222; Package emacs. (Mon, 20 Jan 2014 16:15:01 GMT) Full text and rfc822 format available.

Message #64 received at 16222 <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: 16222 <at> debbugs.gnu.org
Cc: lekktu <at> gmail.com, dgutov <at> yandex.ru
Subject: Re: bug#16222: Installing ELPA packages complains about :keywords in
 define-package
Date: Mon, 20 Jan 2014 11:16:18 -0500
On Thu, 16 Jan 2014 19:04:07 +0200 Dmitry Gutov <dgutov <at> yandex.ru> wrote: 

DG> On 16.01.2014 18:18, Stefan Monnier wrote:
>> So I removed the 2 packages that suffered from this problem (the latest
>> js2-mode and company) and forced a manual rebuild of them.  At least on
>> the elpa.gnu.org side, this is fixed now, indeed.

DG> Thank you, it looks fine now.

DG> I've made `package-desc-keywords' private so that someone can
DG> implement a more general solution later, but the immediate issue seems
DG> to be fixed.

Ideally, a new data format that doesn't look like a funcall, right?

Ted




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#16222; Package emacs. (Tue, 21 Jan 2014 01:59:01 GMT) Full text and rfc822 format available.

Message #67 received at 16222 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Ted Zlatanov <tzz <at> lifelogs.com>, 16222 <at> debbugs.gnu.org
Cc: lekktu <at> gmail.com
Subject: Re: bug#16222: Installing ELPA packages complains about :keywords
 in define-package
Date: Tue, 21 Jan 2014 03:58:28 +0200
On 20.01.2014 18:16, Ted Zlatanov wrote:
> Ideally, a new data format that doesn't look like a funcall, right?

I don't think it's that important. Having the package metadata in a file 
that Emacs wouldn't try to byte-compile would've been better, but we 
can't fix that without breaking compatibility with older Emacs versions.

If we are fine with breaking backward compatibility though, there's a 
much simpler fix for the byte compilation problem: let-bind 
`emacs-lisp-file-regexp' in `package--compile' (or even changing 
`byte-recompile-directory' to always skip `-pkg.el' files if the first 
option doesn't work; I haven't checked).

But as long as the package format stays the same, we might want to try 
to handle the quoting automatically. I.e. without having to quote any 
list value in "extra parameters" manually and then specifically unquote 
before using. But that change can wait until we actually have another 
"extra parameter" whose value is a list.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#16222; Package emacs. (Tue, 21 Jan 2014 13:49:01 GMT) Full text and rfc822 format available.

Message #70 received at 16222 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: lekktu <at> gmail.com, Ted Zlatanov <tzz <at> lifelogs.com>, 16222 <at> debbugs.gnu.org
Subject: Re: bug#16222: Installing ELPA packages complains about :keywords in
 define-package
Date: Tue, 21 Jan 2014 08:48:39 -0500
> simpler fix for the byte compilation problem: let-bind
> emacs-lisp-file-regexp' in `package--compile' (or even changing
> byte-recompile-directory' to always skip `-pkg.el' files if the first option
> doesn't work; I haven't checked).

This fix is still needed, indeed: compiling the -pkg.el is a bug.


        Stefan




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 19 Feb 2014 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 10 years and 40 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.