GNU bug report logs - #16296
subword.el regexps shouldn't be constants

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16296 in the body.
You can then email your comments to 16296 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Phil Sainty <psainty <at> orcon.net.nz>
To: bug-gnu-emacs <at> gnu.org
Subject: subword.el regexps shouldn't be constants
Date: Mon, 30 Dec 2013 12:43:10 +1300

I notice that a recent(ish) change in subword.el changed the two
regexps (subword-forward-regexp and subword-backward-regexp) into
constants.

The reason for splitting them out into variables in the first
place was to help make subword-mode easily adaptable to other
situations where similar functionality was needed, but for different
definitions of 'subword'.

For the situation where the normal subword-forward/backward-function
values are fine and you simply need buffer-local overrides for the
regexps, this newer change would seem to be counter-productive.

Can we please revert it?

-Phil

Message #8 received at 16296 <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Phil Sainty <psainty <at> orcon.net.nz>
Cc: 16296 <at> debbugs.gnu.org
Subject: Re: bug#16296: subword.el regexps shouldn't be constants
Date: Fri, 03 Jan 2014 13:16:54 -0500

On Mon, 30 Dec 2013 12:43:10 +1300 Phil Sainty <psainty <at> orcon.net.nz> wrote: 

PS> I notice that a recent(ish) change in subword.el changed the two
PS> regexps (subword-forward-regexp and subword-backward-regexp) into
PS> constants.

PS> The reason for splitting them out into variables in the first
PS> place was to help make subword-mode easily adaptable to other
PS> situations where similar functionality was needed, but for different
PS> definitions of 'subword'.

PS> For the situation where the normal subword-forward/backward-function
PS> values are fine and you simply need buffer-local overrides for the
PS> regexps, this newer change would seem to be counter-productive.

PS> Can we please revert it?

For reference, you mean this commit?

revno: 113492
fixes bug: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13758
committer: Stefan Monnier <monnier <at> iro.umontreal.ca>
branch nick: trunk
timestamp: Mon 2013-07-22 12:25:32 -0400
message:
  * lisp/progmodes/subword.el: Fix boundary case.
  (subword-forward-regexp): Make it a constant.  Wrap optional \\W in its
  own group.
  (subword-backward-regexp): Make it a constant.
  (subword-forward-internal): Don't treat a trailing capital as the
  beginning of a word.
  * test/automated/subword-tests.el: New file.

Message #11 received at 16296 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Phil Sainty <psainty <at> orcon.net.nz>
Cc: 16296 <at> debbugs.gnu.org
Subject: Re: bug#16296: subword.el regexps shouldn't be constants
Date: Fri, 03 Jan 2014 17:08:08 -0500

>   (subword-forward-regexp): Make it a constant.  Wrap optional \\W in its
>   own group.
>   (subword-backward-regexp): Make it a constant.

If there are reasons for users to change them, then feel free to revert
them to defvars.


        Stefan

Message #14 received at 16296 <at> debbugs.gnu.org (full text, mbox):

From: Phil Sainty <psainty <at> orcon.net.nz>
To: 16296 <at> debbugs.gnu.org
Subject: Re: bug#16296: subword.el regexps shouldn't be constants
Date: Sun, 05 Jan 2014 00:32:25 +1300

[Message part 1 (text/plain, inline)]

On 4/01/2014 11:08, Stefan Monnier wrote:
> If there are reasons for users to change them, then feel free
> to revert them to defvars.

Great, thank you.


On 4/01/2014 07:16, Ted Zlatanov wrote:
> For reference, you mean this commit?
> 
> revno: 113492
> fixes bug: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13758
> committer: Stefan Monnier <monnier <at> iro.umontreal.ca>
> branch nick: trunk
> timestamp: Mon 2013-07-22 12:25:32 -0400
> message:
>   * lisp/progmodes/subword.el: Fix boundary case.
>   (subword-forward-regexp): Make it a constant.  Wrap optional \\W in its
>   own group.
>   (subword-backward-regexp): Make it a constant.
>   (subword-forward-internal): Don't treat a trailing capital as the
>   beginning of a word.
>   * test/automated/subword-tests.el: New file.

Yes, that's the one (although note that I'm not suggesting reverting
that entire commit; just the defvar -> defconst changes).

I've attached a patch.


-Phil

[subword-regexp-vars.patch (text/plain, attachment)]

Message #19 received at 16296-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: 16296-done <at> debbugs.gnu.org
Subject: Re: subword.el regexps shouldn't be constants
Date: Sat, 04 Jan 2014 21:50:20 -0800

I installed that patch; thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.