GNU bug report logs - #16342
24.3.50; RET during search inserts newline in PostScript mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16342 in the body.
You can then email your comments to 16342 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Markus Triska <markus.triska <at> gmx.at>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; RET during search inserts newline in PostScript mode
Date: Sat, 04 Jan 2014 22:09:47 +0100

With "test.ps" which only contains the string "test", when I do:

   $ emacs -Q test.ps

and then search for 'e' with:

   C-s e

and then press RET to stop the search, it unexpectedly inserts a
newline. This does not happen for example in fundamental-mode.


In GNU Emacs 24.3.50.1 (x86_64-apple-darwin10.8.0, X toolkit, Xaw scroll bars)
 of 2014-01-04 on mt-imac.local
Windowing system distributor `The X.Org Foundation', version 11.0.10402000
Configured using:
 `configure --with-xpm=no --with-tiff=no --with-jpeg=no --with-png=no
 CFLAGS=-I/opt/local/include LDFLAGS=-L/opt/local/lib'

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Message #8 received at 16342 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Markus Triska <markus.triska <at> gmx.at>
Cc: 16342 <at> debbugs.gnu.org
Subject: Re: bug#16342: 24.3.50;
 RET during search inserts newline in PostScript mode
Date: Mon, 06 Jan 2014 11:38:14 +0200

> With "test.ps" which only contains the string "test", when I do:
>
>    $ emacs -Q test.ps
>
> and then search for 'e' with:
>
>    C-s e
>
> and then press RET to stop the search, it unexpectedly inserts a
> newline. This does not happen for example in fundamental-mode.

This is because ps-mode.el binds [return] in addition to "\r":

  (define-key ps-mode-map "\r" 'ps-mode-newline)
  (define-key ps-mode-map [return] 'ps-mode-newline)

whereas isearch.el binds only "\r":

  (define-key isearch-mode-map "\r" 'isearch-exit)

We could remove the [return] keybinding from ps-mode.el,
but there are many other places that bind [return] and [backspace]
in the Emacs source tree, external packages as well as in
countless user init files, so maybe better would be to add [return]
and [backspace] keybindings to isearch-mode-map in isearch.el.

Message #11 received at 16342 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Juri Linkov <juri <at> jurta.org>
Cc: 16342 <at> debbugs.gnu.org, Markus Triska <markus.triska <at> gmx.at>
Subject: Re: bug#16342: 24.3.50;
 RET during search inserts newline in PostScript mode
Date: Mon, 06 Jan 2014 10:24:16 -0500

> countless user init files, so maybe better would be to add [return]
> and [backspace] keybindings to isearch-mode-map in isearch.el.

Agreed.  Tho we should *also* remove the `return' binding in ps-mode.el.


        Stefan

Message #16 received at 16342-done <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Markus Triska <markus.triska <at> gmx.at>, 16342-done <at> debbugs.gnu.org
Subject: Re: bug#16342: 24.3.50;
 RET during search inserts newline in PostScript mode
Date: Tue, 07 Jan 2014 09:57:31 +0200

>> countless user init files, so maybe better would be to add [return]
>> and [backspace] keybindings to isearch-mode-map in isearch.el.
>
> Agreed.  Tho we should *also* remove the `return' binding in ps-mode.el.

The revno 115903 fixes this in both isearch.el and ps-mode.el.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.