GNU bug report logs - #16422
24.3.50; Broken git log

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16422 in the body.
You can then email your comments to 16422 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sujith Manoharan <sujith <at> msujith.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; Broken git log
Date: Sun, 12 Jan 2014 12:58:13 +0530

This commit breaks git log using VC for directories:

http://bzr.savannah.gnu.org/lh/emacs/trunk/revision/115934

This happens when invoking vc-print-log on a directory (bound to C-x v l)
in a dired buffer.

For example,

Before this commit: http://msujith.org/dir/emacs/log-no-follow.png
After this commit:  http://msujith.org/dir/emacs/log-follow.png

From the man page for git-log, --follow is an option that is valid
only for single files, so I think this shouldn't be done for directories.


In GNU Emacs 24.3.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.22)
 of 2014-01-11 on nako
Windowing system distributor `The X.Org Foundation', version 11.0.11500000
Configured using:
 `configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib
 --localstatedir=/var --without-sound --without-toolkit-scroll-bars
 --without-xaw3d --without-xim --without-gpm --without-gconf --without-gsettings
 --without-selinux --without-gnutls --without-inotify --with-x-toolkit=gtk2
 --disable-acl --enable-link-time-optimization'

Important settings:
  value of $LC_COLLATE: C
  value of $LANG: en_IN.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Man

Minor modes in effect:
  shell-dirtrack-mode: t
  diff-auto-refine-mode: t
  display-battery-mode: t
  display-time-mode: t
  iswitchb-mode: t
  savehist-mode: t
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  column-number-mode: 1
  line-number-mode: t
  transient-mark-mode: t

Recent input:
l i d <return> o n l y SPC f o r SPC s i n g l e SPC 
f i l e s , SPC s o SPC I SPC t h i n k SPC t h i s 
SPC s h o u l d n ' t b <backspace> SPC b e SPC d o 
n e SPC f o r SPC d i r e c t o r i e s . <return> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> M-x <up> <up> <up> <up> <up> <up> <down> <return> 
<return> C-x b m a n SPC <return> C-x b <return> M-v 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> C-v C-v M-v M-v M-v M-< C-c C-c y y C-g C-g 
C-g C-g <down> <down> <down> <down> <down> <down> <down> 
<down> <up> C-SPC <C-down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> C-x r s 1 C-x k <return> M-x <up> <up> <up> 
<return> <up> <up> <return> M-v M-v M-v M-v M-v M-v 
<up> <up> <up> <up> <up> <down> <down> <down> <down> 
<down> C-SPC <down> <down> <down> <down> <down> <down> 
<up> <up> C-w C-x r i 1 <C-up> <C-up> <C-up> <C-up> 
<return> <up> C-c C-f C-g C-g C-c C-f C-g C-g C-g C-g 
C-g <help-echo> <help-echo> <help-echo> <help-echo> 
<down-mouse-1> C-k M-x s e t - m s u j i <tab> <return> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <return> C-c C-c y y n <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> C-x k <return> M-x <up> C-x 1 <down> <up> 
<return> M-x <up> <up> <up> <down> <return>

Recent messages:
C-c C-f C-g is undefined
Quit
C-c C-f C-g is undefined
Quit [4 times]
Send the message? (y or n)  y
Send this bug report to the Emacs maintainers? (y or n)  y
Is `nil' really your email address? (y or n)  n
report-emacs-bug-hook: Please edit the From address and try again
Beginning of buffer [12 times]
byte-code: Can't expand minibuffer to full frame

Load-path shadows:
/usr/share/emacs/site-lisp/emms/tq hides /usr/share/emacs/24.3.50/lisp/emacs-lisp/tq

Features:
(eieio-opt speedbar sb-image ezimage dframe find-func shadow mailalias vm-reply
emacsbug sh-script smie executable tabify imenu man whitespace pp vc-mtn vc-hg
vc-dir ewoc vc-arch vc-annotate log-view vc-bzr vc-sccs vc-svn vc-cvs vc-rcs vc
vc-dispatcher cc-langs cl cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles
cc-align cc-engine cc-vars cc-defs vc-git shell pcomplete ibuf-ext ibuffer
w3m-form w3m browse-url doc-view jka-compr image-mode timezone w3m-hist w3m-fb
bookmark-w3m w3m-ems w3m-ccl ccl w3m-favicon w3m-image w3m-proc w3m-util vm-w3m
u-vm-color vm-save tapestry vm-sort sendmail vm-rfaddons vm-undo vm-virtual
vm-summary-faces vm-pop utf7 vm-imap vm-thread vm-mime vm-toolbar vm-menu
vm-window vm-folder vm-crypto vm-summary vm-mouse vm-page vm-motion vm-minibuf
vm-message vm-misc vm-macro mairix vm-autoloads vm-vars vm-version vm
emms-info-libtag emms-playlist-limit emms-volume emms-volume-amixer emms-i18n
emms-history emms-score emms-stream-info emms-metaplaylist-mode emms-bookmarks
emms-lastfm-client xml parse-time emms-cue emms-mode-line-icon emms-browser sort
emms-playlist-sort emms-last-played emms-player-xine emms-player-mpd tq
emms-playing-time emms-lyrics emms-url emms-streams emms-tag-editor emms-mark
emms-mode-line emms-cache emms-info-ogginfo emms-info-mp3info emms-info later-do
emms-playlist-mode emms-player-vlc emms-player-mplayer emms-player-simple
emms-source-playlist emms-source-file emms-setup emms emms-compat flyspell
ispell network-stream starttls url-http tls url-gw url-cache url-auth url
url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf
url-util url-parse auth-source eieio eieio-core gnus-util password-cache
url-vars mailcap finder-inf cycbuf misearch multi-isearch mule-util
magit-key-mode magit view help-mode grep compile comint epa derived epg
epg-config diff-mode autorevert filenotify ansi-color git-rebase-mode thingatpt
git-commit-mode log-edit easy-mmode message idna format-spec rfc822 mml mml-sec
mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums
mm-util mail-prsvr mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log
dired-aux info svg-clock-autoloads zenburn-theme-autoloads package warnings
byte-opt bytecomp byte-compile cconv eudcb-ldap ldap eudc cus-edit cus-start
cus-load eudc-vars wid-edit advice help-fns battery time dired-x dired edmacro
kmacro cl-loaddefs cl-lib xcscope ring easymenu zenburn-theme server iswitchb
savehist saveplace time-date tooltip electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow
timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice
loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote make-network-process dbusbind gfilenotify dynamic-setting
font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs)

Message #8 received at 16422 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Sujith Manoharan <sujith <at> msujith.org>
Cc: "Eric S. Raymond" <esr <at> thyrsus.com>, 16422 <at> debbugs.gnu.org
Subject: Re: bug#16422: 24.3.50; Broken git log
Date: Wed, 15 Jan 2014 02:36:06 -0500

Sujith Manoharan wrote:

> This commit breaks git log using VC for directories:
>
> http://bzr.savannah.gnu.org/lh/emacs/trunk/revision/115934

Nor does it fix the original (long-standing) issue that it was made in
connection with (see most recent comments in http://debbugs.gnu.org/8756).

> This happens when invoking vc-print-log on a directory (bound to C-x v l)
> in a dired buffer.
>
> For example,
>
> Before this commit: http://msujith.org/dir/emacs/log-no-follow.png
> After this commit:  http://msujith.org/dir/emacs/log-follow.png
>
> From the man page for git-log, --follow is an option that is valid
> only for single files, so I think this shouldn't be done for directories.

Message #13 received at 16422-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 16422-done <at> debbugs.gnu.org
Subject: Re: bug#16422: 24.3.50; Broken git log
Date: Tue, 21 Jan 2014 21:02:28 -0500

Version: 24.4

No comments in a week, so I've simply taken this out again until someone
fixes http://debbugs.gnu.org/8756 properly.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.