GNU bug report logs - #16595
registers can now end up with non-character names

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16595 in the body.
You can then email your comments to 16595 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: submit <at> debbugs.gnu.org
Subject: registers can now end up with non-character names
Date: Thu, 30 Jan 2014 03:14:41 -0500

Package: emacs
Version: 24.3.50

In Emacs 24.3 under X:

emacs -Q
M-x point-to-register RET <right-arrow>
  -> Non-character input-event

In current trunk under X:

emacs -Q
M-x point-to-register RET <right-arrow>
  -> accepted with no complaints

;; Add a second register to show the list-registers problem.
M-x point-to-register RET a

M-x list-registers
  -> sort: Wrong type argument: number-or-marker-p, right

Message #6 received at 16595 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Leo <sdl.web <at> gmail.com>
Cc: 16595 <at> debbugs.gnu.org
Subject: Re: bug#16595: registers can now end up with non-character names
Date: Thu, 30 Jan 2014 21:51:42 -0500

This is due to register-read-with-preview, which use read-event and does
no sanity checking of the result. Why does it not use read-char?

Also on this subject, register-preview-functions is undocumented and unused.
Does it need to exist? Does it need to be a hook, as opposed to a
-function variable? Should it not exist until there is a use-case for it?

Message #9 received at 16595 <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>,
Cc: Bastien Guerry <bzg <at> altern.org>, 16595 <at> debbugs.gnu.org
Subject: Re: bug#16595: registers can now end up with non-character names
Date: Fri, 31 Jan 2014 14:36:58 +0800

On 2014-01-31 10:51 +0800, Glenn Morris wrote:
> This is due to register-read-with-preview, which use read-event and does
> no sanity checking of the result. Why does it not use read-char?

It is due to handling help-event-list to allow f1 to manually bring up
the preview window, but this may not be important. Changing to read-char
looks fine to me.

> Also on this subject, register-preview-functions is undocumented and
>unused. Does it need to exist? Does it need to be a hook, as opposed to
>a -function variable? Should it not exist until there is a use-case for
>it?

This was left as a hook for registers-list.el (from ELPA). It seems
Bastien was going to do something with it. Bastien, what do you think?

It seems -hook or -function would be a better fit; the latter even
provides more flexibility with add-function

Leo

Message #12 received at 16595 <at> debbugs.gnu.org (full text, mbox):

From: Bastien <bzg <at> altern.org>
To: Leo Liu <sdl.web <at> gmail.com>
Cc: Glenn Morris <rgm <at> gnu.org>, 16595 <at> debbugs.gnu.org
Subject: Re: bug#16595: registers can now end up with non-character names
Date: Fri, 31 Jan 2014 10:59:07 +0100

Hi Leo,

Leo Liu <sdl.web <at> gmail.com> writes:

> This was left as a hook for registers-list.el (from ELPA). It seems
> Bastien was going to do something with it. Bastien, what do you
> think?

My time in the last two months was swallowed by fixing Org bugs,
I didn't have time to integrate features from register-list.el
into register.el.

For now, I suggest register.el should behave independently of
register-list.el, ignoring it completely.

When I've time to merge some features, I'll do so.

-- 
 Bastien

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.