GNU bug report logs - #16671
24.3; cl-lib from ELPA defadvices cl-position into infinite loop

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16671 in the body.
You can then email your comments to 16671 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3; cl-lib from ELPA defadvices cl-position into infinite loop
Date: Thu, 6 Feb 2014 12:44:18 -0500

emacs -Q --eval "(progn (package-initialize t) (package-install
'cl-lib) (require 'cl) (position 1 '(1)))"

*Messages* buffer contains

  apply: Variable binding depth exceeds max-specpdl-size


In GNU Emacs 24.3.1 (i386-mingw-nt6.0.6002)
 of 2013-03-17 on MARVIN

See also: https://github.com/capitaomorte/yasnippet/issues/457 (user
upgrades to 24.3 and doesn't think to uninstall cl-lib, so they hit
this bug).

Message #8 received at 16671 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Noam Postavsky <npostavs <at> users.sourceforge.net>
Cc: 16671 <at> debbugs.gnu.org
Subject: Re: bug#16671: 24.3;
 cl-lib from ELPA defadvices cl-position into infinite loop
Date: Wed, 19 Feb 2014 14:37:53 -0500

> emacs -Q --eval "(progn (package-initialize t) (package-install
> 'cl-lib) (require 'cl) (position 1 '(1)))"
> *Messages* buffer contains
>   apply: Variable binding depth exceeds max-specpdl-size

Indeed.  Could you try the patch below and confirm if it fixes the
problem for you?


        Stefan


diff --git a/packages/cl-lib/cl-lib.el b/packages/cl-lib/cl-lib.el
index 1ea22e0..cf13c56 100644
--- a/packages/cl-lib/cl-lib.el
+++ b/packages/cl-lib/cl-lib.el
@@ -318,25 +327,27 @@
           (message "%S already defined, not rebinding" new))
       (defalias new fun))))
 
-(autoload 'cl-position "cl-seq")
-(defadvice cl-position (around cl-lib (cl-item cl-seq &rest cl-keys) activate)
+(unless (symbolp (symbol-function 'position))
+  (autoload 'cl-position "cl-seq")
+  (defadvice cl-position (around cl-lib (cl-item cl-seq &rest cl-keys) activate)
   (let ((argk (ad-get-args 2)))
     (if (or (null argk) (keywordp (car argk)))
         ;; This is a call to cl-lib's `cl-position'.
         (setq ad-return-value
               (apply #'position (ad-get-arg 0) (ad-get-arg 1) argk))
       ;; Must be a call to cl's old `cl-position'.
-      ad-do-it)))
+      ad-do-it))))
 
-(autoload 'cl-delete-duplicates "cl-seq")
-(defadvice cl-delete-duplicates (around cl-lib (cl-seq &rest cl-keys) activate)
+(unless (symbolp (symbol-function 'delete-duplicates))
+  (autoload 'cl-delete-duplicates "cl-seq")
+  (defadvice cl-delete-duplicates (around cl-lib (cl-seq &rest cl-keys) activate)
   (let ((argk (ad-get-args 1)))
     (if (or (null argk) (keywordp (car argk)))
         ;; This is a call to cl-lib's `cl-delete-duplicates'.
         (setq ad-return-value
               (apply #'delete-duplicates (ad-get-arg 0) argk))
       ;; Must be a call to cl's old `cl-delete-duplicates'.
-      ad-do-it)))
+      ad-do-it))))
 
 (when (or (not (fboundp 'cl-member))
           (eq (symbol-function 'cl-member) #'memq))

Message #11 received at 16671 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 16671 <at> debbugs.gnu.org
Subject: Re: bug#16671: 24.3; cl-lib from ELPA defadvices cl-position into
 infinite loop
Date: Sat, 22 Feb 2014 14:52:00 -0500

On Wed, Feb 19, 2014 at 2:37 PM, Stefan Monnier
<monnier <at> iro.umontreal.ca> wrote:
> Indeed.  Could you try the patch below and confirm if it fixes the
> problem for you?

Yes, looks good. All of position, cl-position, delete-duplicates, and
cl-delete-duplicates succeed with the patch.

Message #16 received at 16671 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Noam Postavsky <npostavs <at> users.sourceforge.net>
Cc: 16671 <at> debbugs.gnu.org
Subject: Re: bug#16671: 24.3;
 cl-lib from ELPA defadvices cl-position into infinite loop
Date: Tue, 25 Feb 2014 16:43:58 -0500

> Yes, looks good. All of position, cl-position, delete-duplicates, and
> cl-delete-duplicates succeed with the patch.

Thanks.  Should appear tomorrow as cl-lib-0.5.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.