GNU bug report logs - #16748
restoring a frameset duplicates existing frames

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16748 in the body.
You can then email your comments to 16748 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: submit <at> debbugs.gnu.org
Subject: restoring a frameset duplicates existing frames
Date: Fri, 14 Feb 2014 01:33:57 -0500

Package: emacs
Version: 24.3.50

Current trunk on GNU/Linux under X:

emacs -Q
C-x C-f 1
M-x make-frame
C-x C-f 2
;; Now we have two frames, one visiting "1", the other "2".
;; Save to register "a":
C-x r f a

M-x make-frame
C-x C-f 3

C-x r j a

This iconifies the existing frames 1, 2, 3, and creates new frames
visiting 1 and 2. These are identical to the ones that previously
existed, so why did it create new copies?
M-x frame-configuration-to-register does not duplicate existing frames
in this way, it simply iconifies frame 3.

Message #6 received at 16748 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 16748 <at> debbugs.gnu.org
Subject: Re: bug#16748: restoring a frameset duplicates existing frames
Date: Fri, 14 Feb 2014 14:26:30 +0100

On Fri, Feb 14, 2014 at 7:33 AM, Glenn Morris <rgm <at> gnu.org> wrote:

> This iconifies the existing frames 1, 2, 3, and creates new frames
> visiting 1 and 2. These are identical to the ones that previously
> existed, so why did it create new copies?
>
> M-x frame-configuration-to-register does not duplicate existing frames
> in this way, it simply iconifies frame 3.

It was an attempt to be compatible with f-c-t-r, though it is
impossible to be identical because f-c-t-r does not recreate deleted
frames. Currently, if you use the prefix,
frame-configuration-to-register does not duplicate frames, it reuses
the existing ones.

Honestly, I do not like the current behavior and would prefer to
switch the meaning of Ctrl-U.

    J

Message #9 received at 16748 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 16748 <at> debbugs.gnu.org
Subject: Re: bug#16748: restoring a frameset duplicates existing frames
Date: Fri, 14 Feb 2014 14:31:33 +0100

On Fri, Feb 14, 2014 at 2:26 PM, Juanma Barranquero <lekktu <at> gmail.com> wrote:

> Currently, if you use the prefix,
> frame-configuration-to-register does not duplicate frames, it reuses
> the existing ones.

and deletes any one remaining that is not restored.

frameset-save/restore supports many options related to which frames to
restore and which ones to keep (look at the docstring of
`frameset-restore'), so we can adapt frameset-to-register to whatever
behavior we want, once it is clearly defined. At most it would mean
passing some more info to registerv-make.

   J

Message #12 received at 16748 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 16748 <at> debbugs.gnu.org
Subject: Re: bug#16748: restoring a frameset duplicates existing frames
Date: Sat, 15 Feb 2014 06:12:21 +0100

On Fri, Feb 14, 2014 at 2:31 PM, Juanma Barranquero <lekktu <at> gmail.com> wrote:

> we can adapt frameset-to-register to whatever
> behavior we want, once it is clearly defined.

After giving it some thought, I think you're right, jump-to-frameset
should be more aggressive reusing frames even when DELETE is nil.

After all, in 24.3

  C-x r f a
  C-x r j a

gives just one frame, while you get two in 24.3.50. I'll fix it.

    J

Message #15 received at 16748 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 16748 <at> debbugs.gnu.org
Subject: Re: bug#16748: restoring a frameset duplicates existing frames
Date: Mon, 17 Feb 2014 17:04:52 +0100

I've committed a change that I think fixes it. Please try and report
any additional trouble.

There's a bug that I'm hitting with

emacs -Q
C-x 3
C-x r f a
C-x 5 2
C-x r j a

=> "Error (frameset): #<window 6> is not a live window"

but it happens inside window-state-put and I think is unrelated to this one.

Message #18 received at 16748 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 16748 <at> debbugs.gnu.org
Subject: Re: bug#16748: restoring a frameset duplicates existing frames
Date: Tue, 18 Feb 2014 13:18:18 -0500

Thanks, works for me.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.