GNU bug report logs - #16749
More informative error when restoring frameset with killed buffer

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16749 in the body.
You can then email your comments to 16749 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: submit <at> debbugs.gnu.org
Subject: More informative error when restoring frameset with killed buffer
Date: Fri, 14 Feb 2014 01:52:55 -0500

Package: emacs
Version: 24.3.50
Severity: minor

Current trunk on GNU/Linux under X.

emacs -Q
C-x C-f 1
C-x r f a
C-x k 1 RET
C-x r j a
   -> jump-to-register: Wrong type argument: stringp, nil

I see that the commentary of frameset.el says it does not restore killed
buffers. That's fine, but a more informative error message would be
better ("Buffer 1 has been killed" or somesuch).

Message #6 received at 16749 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 16749 <at> debbugs.gnu.org
Subject: Re: bug#16749: More informative error when restoring frameset with
 killed buffer
Date: Fri, 14 Feb 2014 02:01:26 -0500

PS Perhaps it should not stop with an error on encountering a dead
buffer, but should continue restoring as much as it can, then give a
summary message/error about dead buffer(s) at the end.

Message #9 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andreas Röhler <andreas.roehler <at> easy-emacs.de>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#16749: More informative error when restoring frameset with
 killed buffer
Date: Fri, 14 Feb 2014 08:42:02 +0100

Am 14.02.2014 08:01, schrieb Glenn Morris:
>
> PS Perhaps it should not stop with an error on encountering a dead
> buffer, but should continue restoring as much as it can,

Suggest an ask before: maybe the killing was deliberately but the jump-key a mistake.

then give a
> summary message/error about dead buffer(s) at the end.
>
>
>
>

Message #14 received at 16749-done <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 16749-done <at> debbugs.gnu.org
Subject: Re: bug#16749: More informative error when restoring frameset with
 killed buffer
Date: Sat, 15 Feb 2014 05:38:13 +0100

On Fri, Feb 14, 2014 at 7:52 AM, Glenn Morris <rgm <at> gnu.org> wrote:

> I see that the commentary of frameset.el says it does not restore killed
> buffers.

That comment refers to window-state-put's functionality, but this bug
is just that I forgot to check that the buffer was live before trying
to restore the point. Fixed now.

> That's fine, but a more informative error message would be
> better ("Buffer 1 has been killed" or somesuch).

At that point, the saved state does not contain the buffer name, just
a marker that points nowhere, so we cannot say "Buffer XXX was killed"
because we don't know that it was called XXX. (Well, strictly speaking
the buffer name is probably somewhere inside frameset-states, but I
don't think digging that info is worth the effort.)

> PS Perhaps it should not stop with an error on encountering a dead
> buffer, but should continue restoring as much as it can, then give a
> summary message/error about dead buffer(s) at the end.

It already restores as much as it can, because that's what
window-state-put does. Dead buffers are ignored and their windows get
another buffer. The current bug does not happen when restoring the
window/buffer, just the selected buffer and point at the end of
jump-to-register.

Also, when using frame-configuration-to-register, jumping to a saved
frame configuration for a deleted frame fails silently. I don't think
jump-to-frameset should be noisier.

   J

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.