GNU bug report logs - #16754
unnecessary requirement of X11 for imagemagick in case of cygwin

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16754 in the body.
You can then email your comments to 16754 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mirek Kaim <mirek.kaim <at> outlook.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: unnecessary requirement of X11 for imagemagick in case of cygwin
Date: Fri, 14 Feb 2014 11:00:01 +0100

i've just compiled the latest version from repo under cygwin. imagemagick installed from cygwin package, with all dependecies - that includes some X-libs, but no X server per se. emacs configured --with-w32. all i did was this:

diff --git a/configure.ac b/configure.ac
index 326d528..bc95daa 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2236,7 +2236,7 @@ if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes"
fi

HAVE_IMAGEMAGICK=no
-if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes"; then
+#if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes"; then
if test "${with_imagemagick}" != "no"; then
## 6.2.8 is the earliest version known to work, but earlier versions
## might work - let us know if you find one.
@@ -2254,7 +2254,7 @@ if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes"
AC_CHECK_FUNCS(MagickExportImagePixels MagickMergeImageLayers)
fi
fi
-fi
+#fi


HAVE_GTK=no

and it works, checked with image-dired and pdf page scaling. obviously, imagemagick is independent from the actual gui used by emacs - as long as there is a gui, it makes sense to link with it. shouldn't it be then:

if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes" || test "${HAVE_W32}" = "yes"; then

or am i missing something? i'm not too familiar with configure and makefile stuff, and i never submitted a patch so i don't have an account, so feel free to patch that. 		 	   		  

Message #8 received at 16754 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Mirek Kaim <mirek.kaim <at> outlook.com>
Cc: 16754 <at> debbugs.gnu.org
Subject: Re: bug#16754: unnecessary requirement of X11 for imagemagick in case
 of cygwin
Date: Sat, 15 Feb 2014 22:02:53 -0500

Mirek Kaim wrote:

> and it works, checked with image-dired and pdf page scaling.

But image-dired does not use the built-in ImageMagick support, it just
calls the external ImageMagick executables. And DocView may do the same
too.

Anyway, what you say sounds plausible to me, but I have no way to test
it myself.

Message #11 received at 16754 <at> debbugs.gnu.org (full text, mbox):

From: Mirek Kaim <mirek.kaim <at> outlook.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: "16754 <at> debbugs.gnu.org" <16754 <at> debbugs.gnu.org>
Subject: RE: bug#16754: unnecessary requirement of X11 for imagemagick in
 case of cygwin
Date: Sun, 16 Feb 2014 09:26:10 +0100

> But image-dired does not use the built-in ImageMagick support, it just
> calls the external ImageMagick executables. And DocView may do the same
> too.

i'm
 not sure if doc-view-scale-internally implies imagemagick, but what i 
do know is that before recompiling emacs with imagemagick support, 
doc-view displayed the pages at the original resolution (depending on 
dpi setting, obviously), while afterwards it started using the 
doc-view-image-width variable, so my guess is that it works (both builds
 were done by me, the only difference was adding imagemagick and dbus 
support).

of course i may be wrong, so any way to check if it works is welcome. 		 	   		  

Message #14 received at 16754 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Mirek Kaim <mirek.kaim <at> outlook.com>
Cc: "16754 <at> debbugs.gnu.org" <16754 <at> debbugs.gnu.org>
Subject: Re: bug#16754: unnecessary requirement of X11 for imagemagick in case
 of cygwin
Date: Sun, 16 Feb 2014 14:33:12 -0500

I think if you simply visit an image type that Emacs does not otherwise
support, eg .bmp, and check that

i) it displays as an image with "Image[imagemagick]" in the mode line.

ii) M-x image-transform-set-rotation RET 45 RET work.

we'll call that good enough. Thanks!

Message #17 received at 16754 <at> debbugs.gnu.org (full text, mbox):

From: Mirek Kaim <mirek.kaim <at> outlook.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: "16754 <at> debbugs.gnu.org" <16754 <at> debbugs.gnu.org>
Subject: RE: bug#16754: unnecessary requirement of X11 for imagemagick in
 case of cygwin
Date: Mon, 17 Feb 2014 10:20:46 +0100

> I think if you simply visit an image type that Emacs does not otherwise
> support, eg .bmp, and check that
>
> i) it displays as an image with "Image[imagemagick]" in the mode line.
>
> ii) M-x image-transform-set-rotation RET 45 RET work.
>
> we'll call that good enough. Thanks!

checked with both .bmp and .tga, it works. setting imagemagick render mode to 1 causes emacs to crash though, but default setting of 0 works fine. 		 	   		  

Message #22 received at 16754-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 16754-done <at> debbugs.gnu.org
Subject: Re: bug#16754: unnecessary requirement of X11 for imagemagick in case
 of cygwin
Date: Mon, 17 Feb 2014 20:47:54 -0500

Version: 24.4

Thanks; applied.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.