GNU bug report logs - #16814
`sql-interactive-mode' overwrites `comint' variables

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16814 in the body.
You can then email your comments to 16814 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Emilio C. Lopes <eclig <at> gmx.net>
To: bug-gnu-emacs <at> gnu.org
Subject: `sql-interactive-mode' overwrites `comint' variables
Date: Wed, 19 Feb 2014 21:05:45 +0100

`sql-interactive-mode' sets the variables `comint-input-ring-separator'
and `comint-input-ring-file-name' without making them buffer-local.

When I use `sql-interactive-mode' and afterwards run
`(comint-read-input-ring)' in `shell-mode' I get an empty
`comint-input-ring'.

Here is a patch:

2012-10-09  Emilio C. Lopes  <eclig <at> gmx.net>

    * progmodes/sql.el (sql-interactive-mode): make variables `comint-input-ring-separator' and
          `comint-input-ring-file-name' buffer-local before setting.


diff --unified lisp/progmodes/sql.el.\~1\~ lisp/progmodes/sql.el
--- lisp/progmodes/sql.el.~1~    2014-02-19 14:31:34.000000000 +0100
+++ lisp/progmodes/sql.el    2014-02-19 14:45:36.000000000 +0100
@@ -3928,8 +3928,8 @@
   ;; People wanting a different history file for each
   ;; buffer/process/client/whatever can change separator and file-name
   ;; on the sql-interactive-mode-hook.
-  (setq comint-input-ring-separator sql-input-ring-separator
-    comint-input-ring-file-name sql-input-ring-file-name)
+  (setq-local comint-input-ring-separator sql-input-ring-separator)
+  (setq-local comint-input-ring-file-name sql-input-ring-file-name)
   ;; Calling the hook before calling comint-read-input-ring allows users
   ;; to set comint-input-ring-file-name in sql-interactive-mode-hook.
   (comint-read-input-ring t))

Diff finished.  Wed Feb 19 14:45:41 2014

Message #10 received at 16814-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 16814-done <at> debbugs.gnu.org
Subject: Re: bug#16814: `sql-interactive-mode' overwrites `comint' variables
Date: Thu, 27 Feb 2014 20:56:19 -0500

Version: 24.4

Emilio C. Lopes wrote:

> `sql-interactive-mode' sets the variables `comint-input-ring-separator'
> and `comint-input-ring-file-name' without making them buffer-local.

You're right about comint-input-ring-separator, but sql-interactive-mode
first calls comint-mode, which makes comint-input-ring-file-name
buffer-local.

> Here is a patch:

Partially applied, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.