GNU bug report logs - #16884
24.3.50; desktop-read should not die on non-existing directories

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16884 in the body.
You can then email your comments to 16884 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sam Steingold <sds <at> gnu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; desktop-read should not die on non-existing directories
Date: Tue, 25 Feb 2014 14:06:22 -0500

In GNU Emacs 24.3.50.6 (x86_64-apple-darwin13.1.0, NS apple-appkit-1265.19)
 of 2014-02-25 on sds-MacBook-Pro.local
Windowing system distributor `Apple', version 10.3.1265
Configured using:
 `configure --with-ns'

when restarting emacs I just got this:

Debugger entered--Lisp error: (file-error "Reading directory" "no such file or directory" "/Users/sds/.emacs.d/auto-saves/*")
  access-file("/Users/sds/.emacs.d/auto-saves/*" "Reading directory")
  insert-directory("/Users/sds/.emacs.d/auto-saves/*" "-als" t nil)
  dired-insert-directory("/Users/sds/.emacs.d/auto-saves/*" "-als" nil t t)
  dired-readin-insert()
  dired-readin()
  dired-internal-noselect("/Users/sds/.emacs.d/auto-saves/*" nil)
  dired-noselect("/Users/sds/.emacs.d/auto-saves/*" nil)
  dired("/Users/sds/.emacs.d/auto-saves/*")
  dired-restore-desktop-buffer(nil "*" ("/Users/sds/.emacs.d/auto-saves/*"))
  #[0 "\f\236A\206\305\300\301\302#\207" [nil "*" ("/Users/sds/.emacs.d/auto-saves/*") desktop-buffer-major-mode desktop-buffer-mode-handlers desktop-restore-file-buffer] 4 "\n\n(fn)"]()
  funcall(#[0 "\f\236A\206\305\300\301\302#\207" [nil "*" ("/Users/sds/.emacs.d/auto-saves/*") desktop-buffer-major-mode desktop-buffer-mode-handlers desktop-restore-file-buffer] 4 "\n\n(fn)"])
  desktop-create-buffer(206 nil "*" dired-mode (rcirc-track-minor-mode) 288 (nil nil) t ("/Users/sds/.emacs.d/auto-saves/*") nil)
  eval-buffer(#<buffer  *load*> nil "/Users/sds/.emacs.d/.emacs.desktop" nil t)  ; Reading at buffer position 8688
  load-with-code-conversion("/Users/sds/.emacs.d/.emacs.desktop" "/Users/sds/.emacs.d/.emacs.desktop" t t)
  load("/Users/sds/.emacs.d/.emacs.desktop" t t t)
  desktop-read()
  #[0 "\303\211\235\203\304\"\301\305!\210\210	\205\306 \210\307\211\207" [command-line-args desktop-save-mode inhibit-startup-screen "--no-desktop" delete 0 desktop-read t] 4 "\n\n(fn)"]()
  run-hooks(after-init-hook)
  command-line()
  normal-top-level()

because I did M-x recover-session RET in the previous incarnation.
I think this error should be caught and either ignored or reported as a message.


Important settings:
  value of $LANG: C
  locale-coding-system: utf-8-unix

Major mode: Emacs-Lisp

Minor modes in effect:
  rcirc-track-minor-mode: t
  which-function-mode: t
  url-handler-mode: t
  show-paren-mode: t
  desktop-save-mode: t
  shell-dirtrack-mode: t
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  abbrev-mode: t

Recent messages:
Running git --no-pager update-index --refresh . in background...
ls does not support --dired; see `dired-use-ls-dired' for more details.
Mark set [12 times]
Desktop: File "/Users/sds/Magnetic/lifespan24/2014-Feb/search-freq-hist.png" no longer exists.
Entering debugger...
Running git --no-pager update-index --refresh . in background... done
Running git --no-pager diff-index --relative -z -M HEAD -- . in background... done
Running git --no-pager ls-files -z -o --directory --no-empty-directory --exclude-standard -- . in background... done
<wheel-right> is undefined
Scanning for dabbrevs...done

Load-path shadows:
None found.

Features:
(shadow sort bbdb-message mailalias cookie1 mail-extr gnus-msg gnus-art
mm-uu mml2015 epg-config mm-view mml-smime smime dig mailcap gnus-sum
nnoo gnus-group gnus-undo nnmail mail-source gnus-start gnus-spec
gnus-int gnus-range gnus-win dabbrev emacsbug message cl-macs gv rfc822
mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 gmm-utils
mailheader sendmail rfc2047 rfc2045 ietf-drums help-mode debug
image-mode goto-addr vc-hg dired-aux dired vc-dir ewoc vc vc-dispatcher
sql view vc-git edit-server-autoloads package midnight warnings gnus
gnus-ems nnheader mail-utils wid-edit bbdb-mua bbdb-com crm mailabbrev
bbdb-loaddefs bbdb bbdb-site timezone rcirc server which-func imenu
url-handlers url-parse auth-source eieio byte-opt bytecomp byte-compile
cconv eieio-core gnus-util mm-util mail-prsvr password-cache url-vars
paren help-at-pt desktop frameset cus-start cus-load ido ess-toolbar
ess-mouse mouseme thingatpt browse-url ess-menu ess-swv ess-noweb
ess-noweb-font-lock-mode ess-bugs-l essd-els ess-sas-d ess-sas-l
ess-sas-a shell pcomplete ess-sta-d ess-sta-l cc-vars cc-defs
make-regexp ess-sp6-d ess-sp3-d ess-julia ess-r-d compile ess-tracebug
format-spec ess-roxy advice hideshow ess-help ess-developer ess-r-args
eldoc help-fns ess-s-l ess ess-inf comint ansi-color ring ess-mode
ess-noweb-mode ess-utils ess-custom executable easymenu ess-compat
ess-site cl cl-loaddefs cl-lib time-date tooltip electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel ns-win tool-bar dnd fontset
image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode
register page menu-bar rfn-eshadow timer select scroll-bar mouse
jit-lock font-lock syntax facemenu font-core frame cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev
minibuffer nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-process
cocoa ns multi-tty emacs)

-- 
Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.1265
http://www.childpsy.net/ http://dhimmi.com http://pmw.org.il
http://think-israel.org http://honestreporting.com http://ffii.org
(let ((a "(let ((a %c%s%c)) (format a 34 a 34))")) (format a 34 a 34))

Message #8 received at 16884 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Sam Steingold <sds <at> gnu.org>
Cc: 16884 <at> debbugs.gnu.org
Subject: Re: bug#16884: 24.3.50;
 desktop-read should not die on non-existing directories
Date: Tue, 25 Feb 2014 22:08:35 +0100

On Tue, Feb 25, 2014 at 8:06 PM, Sam Steingold <sds <at> gnu.org> wrote:

> when restarting emacs I just got this:
>
> Debugger entered--Lisp error: (file-error "Reading directory" "no such file or directory" "/Users/sds/.emacs.d/auto-saves/*")
>   access-file("/Users/sds/.emacs.d/auto-saves/*" "Reading directory")

> because I did M-x recover-session RET in the previous incarnation.
> I think this error should be caught and either ignored or reported as a message.

On Windows I don't see that. If the directory does not exist (either
the auto-saves one or any other directory in a Dired buffer), desktop
just outputs its usual summary line saying that N buffers were
restored, M buffers failed to restore.

Can you reproduce it at will?

    J

Message #11 received at 16884 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: Sam Steingold <sds <at> gnu.org>, 16884 <at> debbugs.gnu.org
Subject: Re: bug#16884: 24.3.50;
 desktop-read should not die on non-existing directories
Date: Wed, 26 Feb 2014 12:28:53 -0500

Note the unusual use of "*" in the backtrace.
The problem is not "non-existing directory" as it says in the subject,
but failure to match a glob pattern.

mkdir /tmp/foo
touch /tmp/foo/1
emacs -Q
M-x dired /tmp/foo/*    ; why not just /tmp/foo ... ?
M-x desktop-save RET /tmp RET
M-x kill-emacs

rm /tmp/foo/1   ; not rm -rf /tmp/foo

emacs -Q
M-: (desktop-read "/tmp")

 -> Debugger entered--Lisp error: (file-error "Reading directory"
    "no such file or directory" "/tmp/foo/*")

Message #14 received at 16884 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: Sam Steingold <sds <at> gnu.org>, 16884 <at> debbugs.gnu.org
Subject: Re: bug#16884: 24.3.50;
 desktop-read should not die on non-existing directories
Date: Wed, 26 Feb 2014 12:35:36 -0500

PS maybe just stick a with-demoted-errors in dired-restore-desktop-buffer.

Message #17 received at 16884 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: Sam Steingold <sds <at> gnu.org>, 16884 <at> debbugs.gnu.org
Subject: Re: bug#16884: 24.3.50;
 desktop-read should not die on non-existing directories
Date: Wed, 26 Feb 2014 18:40:39 +0100

On Wed, Feb 26, 2014 at 6:28 PM, Glenn Morris <rgm <at> gnu.org> wrote:

> mkdir /tmp/foo
> touch /tmp/foo/1
> emacs -Q
> M-x dired /tmp/foo/*    ; why not just /tmp/foo ... ?
> M-x desktop-save RET /tmp RET
> M-x kill-emacs
>
> rm /tmp/foo/1   ; not rm -rf /tmp/foo
>
> emacs -Q
> M-: (desktop-read "/tmp")
>
>  -> Debugger entered--Lisp error: (file-error "Reading directory"
>     "no such file or directory" "/tmp/foo/*")

Doesn't happen on Windows. I get a buffer named "*", with contents:

  c:/Windows/Temp/foo:
  wildcard *
  total used in directory 12 available 57142624
  drwxrwxrwx  1 Administradores None                0 feb 26 18:36 .
  drwxrwxrwx  1 Administradores Administradores 12288 feb 26 18:35 ..

Message #20 received at 16884 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: Sam Steingold <sds <at> gnu.org>, 16884 <at> debbugs.gnu.org
Subject: Re: bug#16884: 24.3.50;
 desktop-read should not die on non-existing directories
Date: Wed, 26 Feb 2014 18:47:18 +0100

On Wed, Feb 26, 2014 at 6:35 PM, Glenn Morris <rgm <at> gnu.org> wrote:

> PS maybe just stick a with-demoted-errors in dired-restore-desktop-buffer.

I don't think it is in fact related to desktop. If I call

  (dired-restore-desktop-buffer nil "*" '("C:/Windows/temp/foo/*"))

it doesn't fail. The problem seems to be that (dired
"/some/path/with/empty/dir/*") is failing for you (y'all, I mean ;-),
while it works on Windows. Can you try this without desktop.el?

Message #23 received at 16884 <at> debbugs.gnu.org (full text, mbox):

From: Sam Steingold <sds <at> gnu.org>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: Glenn Morris <rgm <at> gnu.org>, 16884 <at> debbugs.gnu.org
Subject: Re: bug#16884: 24.3.50;
 desktop-read should not die on non-existing directories
Date: Wed, 26 Feb 2014 13:15:22 -0500

I set debug-on-error to t in .emacs, this might be causing the problem.
however, I think this kind of error reporting should be controlled by
--debug-init and not debug-on-error

On Wed, Feb 26, 2014 at 12:47 PM, Juanma Barranquero <lekktu <at> gmail.com> wrote:
> On Wed, Feb 26, 2014 at 6:35 PM, Glenn Morris <rgm <at> gnu.org> wrote:
>
>> PS maybe just stick a with-demoted-errors in dired-restore-desktop-buffer.
>
> I don't think it is in fact related to desktop. If I call
>
>   (dired-restore-desktop-buffer nil "*" '("C:/Windows/temp/foo/*"))
>
> it doesn't fail. The problem seems to be that (dired
> "/some/path/with/empty/dir/*") is failing for you (y'all, I mean ;-),
> while it works on Windows. Can you try this without desktop.el?



-- 
Sam Steingold <http://sds.podval.org> <http://www.childpsy.net/>

Message #26 received at 16884 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Sam Steingold <sds <at> gnu.org>
Cc: Glenn Morris <rgm <at> gnu.org>, 16884 <at> debbugs.gnu.org
Subject: Re: bug#16884: 24.3.50;
 desktop-read should not die on non-existing directories
Date: Wed, 26 Feb 2014 19:18:33 +0100

On Wed, Feb 26, 2014 at 7:15 PM, Sam Steingold <sds <at> gnu.org> wrote:

> I set debug-on-error to t in .emacs, this might be causing the problem.

Not unless there's an error in the first place.

If you run

  M-: (dired "/Users/sds/.emacs.d/auto-saves/*") <RET>

(assuming that the auto-saves directory is empty), do you get an error?

Message #29 received at 16884 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: rgm <at> gnu.org, sds <at> gnu.org, 16884 <at> debbugs.gnu.org
Subject: Re: bug#16884: 24.3.50;
 desktop-read should not die on non-existing directories
Date: Wed, 26 Feb 2014 20:20:29 +0200

> From: Juanma Barranquero <lekktu <at> gmail.com>
> Date: Wed, 26 Feb 2014 18:47:18 +0100
> Cc: Sam Steingold <sds <at> gnu.org>, 16884 <at> debbugs.gnu.org
> 
> On Wed, Feb 26, 2014 at 6:35 PM, Glenn Morris <rgm <at> gnu.org> wrote:
> 
> > PS maybe just stick a with-demoted-errors in dired-restore-desktop-buffer.
> 
> I don't think it is in fact related to desktop. If I call
> 
>   (dired-restore-desktop-buffer nil "*" '("C:/Windows/temp/foo/*"))
> 
> it doesn't fail. The problem seems to be that (dired
> "/some/path/with/empty/dir/*") is failing for you (y'all, I mean ;-),
> while it works on Windows. Can you try this without desktop.el?

Dired on Windows uses ls-lisp.el, not a real ls program.

Message #32 received at 16884 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Glenn Morris <rgm <at> gnu.org>, Sam Steingold <sds <at> gnu.org>,
 16884 <at> debbugs.gnu.org
Subject: Re: bug#16884: 24.3.50;
 desktop-read should not die on non-existing directories
Date: Wed, 26 Feb 2014 19:28:51 +0100

On Wed, Feb 26, 2014 at 7:20 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:

> Dired on Windows uses ls-lisp.el, not a real ls program.

Yep, you're right. But dired is documented to accept wildcards:

  Dired displays a list of files in dirname (which may also have
  shell wildcards appended to select certain files).

so, in any platform, I wouldn't expect it to throw an error if the
wildcard matches no file.

However, if I set

 (setq insert-directory-program "c:/bin/gnu/bin/ls.exe"
       ls-lisp-use-insert-directory-program t)

then (dired "C:/windows/temp/foo/*") does indeed throw an error.

Is that the expected behavior? It seems like a bug to me (just not in
desktop.el, but dired.el).

Message #35 received at 16884 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: rgm <at> gnu.org, sds <at> gnu.org, 16884 <at> debbugs.gnu.org
Subject: Re: bug#16884: 24.3.50;
 desktop-read should not die on non-existing directories
Date: Wed, 26 Feb 2014 20:34:05 +0200

> From: Juanma Barranquero <lekktu <at> gmail.com>
> Date: Wed, 26 Feb 2014 19:28:51 +0100
> Cc: Glenn Morris <rgm <at> gnu.org>, Sam Steingold <sds <at> gnu.org>, 16884 <at> debbugs.gnu.org
> 
>   Dired displays a list of files in dirname (which may also have
>   shell wildcards appended to select certain files).
> 
> so, in any platform, I wouldn't expect it to throw an error if the
> wildcard matches no file.

Why do you expect an error to be thrown?

Message #38 received at 16884 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Glenn Morris <rgm <at> gnu.org>, Sam Steingold <sds <at> gnu.org>,
 16884 <at> debbugs.gnu.org
Subject: Re: bug#16884: 24.3.50;
 desktop-read should not die on non-existing directories
Date: Wed, 26 Feb 2014 19:36:05 +0100

On Wed, Feb 26, 2014 at 7:34 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:

> Why do you expect an error to be thrown?

I don't expect it. I get it, when using the ls executable, and that's
also what Sam and Glenn are reporting.

Am I missing something?

Message #41 received at 16884 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: Sam Steingold <sds <at> gnu.org>, 16884 <at> debbugs.gnu.org
Subject: Re: bug#16884: 24.3.50;
 desktop-read should not die on non-existing directories
Date: Wed, 26 Feb 2014 13:36:45 -0500

Juanma Barranquero wrote:

> If you run
>
>   M-: (dired "/Users/sds/.emacs.d/auto-saves/*") <RET>
>
> (assuming that the auto-saves directory is empty), do you get an error?

Yes. In just the same way as

M-: (dired "/blargh") RET

throws an error.

This is all fine in normal use.

But dired-restore-desktop-buffer should trap the "glob match fails" case
in just the same way as it traps the "no such directory" case.

Message #44 received at 16884 <at> debbugs.gnu.org (full text, mbox):

From: Sam Steingold <sds <at> gnu.org>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: Glenn Morris <rgm <at> gnu.org>, 16884 <at> debbugs.gnu.org
Subject: Re: bug#16884: 24.3.50;
 desktop-read should not die on non-existing directories
Date: Wed, 26 Feb 2014 13:38:45 -0500

> * Juanma Barranquero <yrxxgh <at> tznvy.pbz> [2014-02-26 19:18:33 +0100]:
>
> On Wed, Feb 26, 2014 at 7:15 PM, Sam Steingold <sds <at> gnu.org> wrote:
>
>> I set debug-on-error to t in .emacs, this might be causing the problem.
>
> Not unless there's an error in the first place.
>
> If you run
>
>   M-: (dired "/Users/sds/.emacs.d/auto-saves/*") <RET>
>
> (assuming that the auto-saves directory is empty), do you get an error?

auto-saves is not empty ATM, but auto-save-list is:

(dired "/Users/sds/.emacs.d/auto-save-list/*")

Debugger entered--Lisp error: (file-error "Reading directory" "no such file or directory" "/Users/sds/.emacs.d/auto-save-list/*")
  access-file("/Users/sds/.emacs.d/auto-save-list/*" "Reading directory")
  insert-directory("/Users/sds/.emacs.d/auto-save-list/*" "-als" t nil)
  dired-insert-directory("/Users/sds/.emacs.d/auto-save-list/*" "-als" nil t t)
  dired-readin-insert()
  dired-readin()
  dired-internal-noselect("/Users/sds/.emacs.d/auto-save-list/*" nil)
  dired-noselect("/Users/sds/.emacs.d/auto-save-list/*" nil)
  dired("/Users/sds/.emacs.d/auto-save-list/*")
  eval((dired "/Users/sds/.emacs.d/auto-save-list/*") nil)
  eval-last-sexp-1(t)
  eval-last-sexp(t)
  eval-print-last-sexp(nil)
  call-interactively(eval-print-last-sexp nil nil)
  command-execute(eval-print-last-sexp)


-- 
Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.1265
http://www.childpsy.net/ http://pmw.org.il http://truepeace.org
http://memri.org http://camera.org http://islamexposedonline.com
Three can keep a secret if two of them are dead.

Message #47 received at 16884 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: Sam Steingold <sds <at> gnu.org>, 16884 <at> debbugs.gnu.org
Subject: Re: bug#16884: 24.3.50;
 desktop-read should not die on non-existing directories
Date: Wed, 26 Feb 2014 19:49:23 +0100

On Wed, Feb 26, 2014 at 7:36 PM, Glenn Morris <rgm <at> gnu.org> wrote:

> Yes. In just the same way as
>
> M-: (dired "/blargh") RET
>
> throws an error.
>
> This is all fine in normal use.

Well, I find it curious that dired of an empty directory or a failing
pattern match should throw an error (as I said, it doesn't on Windows
when using ls-lisp.el), but if that's the usual and time-honored
behavior, who am I to discuss it?

> But dired-restore-desktop-buffer should trap the "glob match fails" case
> in just the same way as it traps the "no such directory" case.

Yes, if (dired "/nonexistent") errors out, we should catch it when
restoring desktop.el. And it shouldn't ever be a with-demoted-errors,
failing to restore buffers in desktop.el is quite silent, just a
message at the end "X frames, Y buffers restored, Z failed to
restore."

Message #50 received at 16884 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: rgm <at> gnu.org, sds <at> gnu.org, 16884 <at> debbugs.gnu.org
Subject: Re: bug#16884: 24.3.50;
 desktop-read should not die on non-existing directories
Date: Wed, 26 Feb 2014 21:04:25 +0200

> From: Juanma Barranquero <lekktu <at> gmail.com>
> Date: Wed, 26 Feb 2014 19:36:05 +0100
> Cc: Glenn Morris <rgm <at> gnu.org>, Sam Steingold <sds <at> gnu.org>, 16884 <at> debbugs.gnu.org
> 
> On Wed, Feb 26, 2014 at 7:34 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
> > Why do you expect an error to be thrown?
> 
> I don't expect it. I get it, when using the ls executable, and that's
> also what Sam and Glenn are reporting.

AFAIK, what happens when a wildcard matches nothing is implementation
defined.

What exactly depends on an error being thrown in this case?

Message #53 received at 16884 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Juanma Barranquero <lekktu <at> gmail.com>, sds <at> gnu.org, 16884 <at> debbugs.gnu.org
Subject: Re: bug#16884: 24.3.50;
 desktop-read should not die on non-existing directories
Date: Wed, 26 Feb 2014 14:09:34 -0500

Eli Zaretskii wrote:

> AFAIK, what happens when a wildcard matches nothing is implementation
> defined.

ls FILE-THAT-DOES-NOT-EXIST

returns non-zero.

ls knows nothing of wildcards, that's the shell's business.

Message #56 received at 16884 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: lekktu <at> gmail.com, sds <at> gnu.org, 16884 <at> debbugs.gnu.org
Subject: Re: bug#16884: 24.3.50;
 desktop-read should not die on non-existing directories
Date: Wed, 26 Feb 2014 21:13:53 +0200

> From: Glenn Morris <rgm <at> gnu.org>
> Cc: Juanma Barranquero <lekktu <at> gmail.com>,  sds <at> gnu.org,  16884 <at> debbugs.gnu.org
> Date: Wed, 26 Feb 2014 14:09:34 -0500
> 
> ls knows nothing of wildcards, that's the shell's business.

Not on Windows, where the wildcards are expanded by the application's
startup code.

Message #59 received at 16884 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: lekktu <at> gmail.com, sds <at> gnu.org, 16884 <at> debbugs.gnu.org
Subject: Re: bug#16884: 24.3.50;
 desktop-read should not die on non-existing directories
Date: Wed, 26 Feb 2014 14:20:09 -0500

Eli Zaretskii wrote:

>> ls knows nothing of wildcards, that's the shell's business.
>
> Not on Windows, where the wildcards are expanded by the application's
> startup code.

I'm shocked, shocked to learn that Windows is dumb.

Message #62 received at 16884 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: Sam Steingold <sds <at> gnu.org>, 16884 <at> debbugs.gnu.org
Subject: Re: bug#16884: 24.3.50;
 desktop-read should not die on non-existing directories
Date: Wed, 26 Feb 2014 14:22:13 -0500

Juanma Barranquero wrote:

>> But dired-restore-desktop-buffer should trap the "glob match fails" case
>> in just the same way as it traps the "no such directory" case.
>
> Yes, if (dired "/nonexistent") errors out, we should catch it when
> restoring desktop.el. And it shouldn't ever be a with-demoted-errors,
> failing to restore buffers in desktop.el is quite silent, just a
> message at the end "X frames, Y buffers restored, Z failed to
> restore."

If you've got time to implement this nicety, go for it.
I just went with with-demoted-errors, with is consistent with the
existing "no such directory" case.

Message #67 received at 16884 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: Sam Steingold <sds <at> gnu.org>, 16884 <at> debbugs.gnu.org
Subject: Re: bug#16884: 24.3.50;
 desktop-read should not die on non-existing directories
Date: Wed, 26 Feb 2014 21:31:24 +0100

On Wed, Feb 26, 2014 at 8:22 PM, Glenn Morris <rgm <at> gnu.org> wrote:

> I just went with with-demoted-errors, with is consistent with the
> existing "no such directory" case.

I'm OK with that. We can change it afterwards if anyone complains.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.