GNU bug report logs - #17325
24.3.90; can not font-lock @ function

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 17325 in the body.
You can then email your comments to 17325 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.90; can not font-lock @ function
Date: Wed, 23 Apr 2014 21:55:08 +0800

Try this code snippet in emacs-lisp-mode and you should see the function
name after @ not font-locked:

(defun who-@-how ()
  )

Message #8 received at 17325 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Leo Liu <sdl.web <at> gmail.com>
Cc: 17325 <at> debbugs.gnu.org
Subject: Re: bug#17325: 24.3.90; can not font-lock @ function
Date: Wed, 23 Apr 2014 10:52:49 -0400

> Try this code snippet in emacs-lisp-mode and you should see the function
> name after @ not font-locked:
> (defun who-@-how ()
>   )


That's because of its "prefix" syntax for use in ,@.
I guess we could change its syntax from "'" to "_ p".
Can someone try it out and install that change if it seems to work well?


        Stefan

Message #11 received at 17325 <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: 17325 <at> debbugs.gnu.org
Subject: Re: bug#17325: 24.3.90; can not font-lock @ function
Date: Wed, 23 Apr 2014 23:27:33 +0800

On 2014-04-23 10:52 -0400, Stefan Monnier wrote:
> That's because of its "prefix" syntax for use in ,@.
> I guess we could change its syntax from "'" to "_ p".
> Can someone try it out and install that change if it seems to work well?

Seems to work well. Since this is a regression, I suppose it should be
in emacs-24? If so I'll take care of this tomorrow.

Leo

Message #14 received at 17325 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Leo Liu <sdl.web <at> gmail.com>
Cc: 17325 <at> debbugs.gnu.org
Subject: Re: bug#17325: 24.3.90; can not font-lock @ function
Date: Wed, 23 Apr 2014 13:35:48 -0400

>> That's because of its "prefix" syntax for use in ,@.
>> I guess we could change its syntax from "'" to "_ p".
>> Can someone try it out and install that change if it seems to work well?
> Seems to work well. Since this is a regression, I suppose it should be
> in emacs-24? If so I'll take care of this tomorrow.

Not sure why you think it's a regression, but yes you can install it in
emacs-24.


        Stefan

Message #17 received at 17325 <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 17325 <at> debbugs.gnu.org
Subject: Re: bug#17325: 24.3.90; can not font-lock @ function
Date: Thu, 24 Apr 2014 09:04:11 +0800

On 2014-04-23 13:35 -0400, Stefan Monnier wrote:
> Not sure why you think it's a regression, but yes you can install it in
> emacs-24.

I mean the code snippet is font-locked correctly in 24.3.

BTW, in emacs-lisp-mode-syntax-table why are all entries end with some
whitespaces i.e. instead of

        (modify-syntax-entry ?@ "'" table)

it uses:

        (modify-syntax-entry ?@ "'   " table)

Leo

Message #20 received at 17325 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Leo Liu <sdl.web <at> gmail.com>
Cc: 17325 <at> debbugs.gnu.org
Subject: Re: bug#17325: 24.3.90; can not font-lock @ function
Date: Thu, 24 Apr 2014 09:20:19 -0400

>> Not sure why you think it's a regression, but yes you can install it in
>> emacs-24.
> I mean the code snippet is font-locked correctly in 24.3.

Aha, didn't realize that.  Not sure why that changed.

> BTW, in emacs-lisp-mode-syntax-table why are all entries end with some
> whitespaces i.e. instead of
>         (modify-syntax-entry ?@ "'" table)
> it uses:
>         (modify-syntax-entry ?@ "'   " table)

It makes no difference, but this style was very common.  It's probably
because syntax strings are "positional" (the first char has a meaning,
the second another one, the rest yet another) so using "'   " is saying
explicitly "no p/b/1/2/3/4".


        Stefan

Message #25 received at 17325-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 17325-done <at> debbugs.gnu.org
Subject: Re: bug#17325: 24.3.90; can not font-lock @ function
Date: Fri, 25 Apr 2014 13:04:23 +0800

Fixed in 24.3.91

On 2014-04-24 09:20 -0400, Stefan Monnier wrote:
> It makes no difference, but this style was very common.  It's probably
> because syntax strings are "positional" (the first char has a meaning,
> the second another one, the rest yet another) so using "'   " is saying
> explicitly "no p/b/1/2/3/4".

Thanks for this info.

Leo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.