GNU bug report logs - #17430
24.4.50; minibuffer history forgets the first entry

Previous Next

Package: emacs;

Reported by: Jarek Czekalski <jarekczek <at> poczta.onet.pl>

Date: Wed, 7 May 2014 11:09:02 UTC

Severity: normal

Merged with 17432

Found in version 24.4.50

Done: Jarek Czekalski <jarekczek <at> poczta.onet.pl>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 17430 in the body.
You can then email your comments to 17430 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#17430; Package emacs. (Wed, 07 May 2014 11:09:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Jarek Czekalski <jarekczek <at> poczta.onet.pl>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 07 May 2014 11:09:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jarek Czekalski <jarekczek <at> poczta.onet.pl>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.4.50; minibuffer history forgets the first entry
Date: Wed, 07 May 2014 13:07:31 +0200
[Message part 1 (text/plain, inline)]
Steps:
1. (read-from-minibuffer "pro: " nil nil nil 'hist)
2. type sth
3. check hist: M-S-: hist

Expected: sth, Actual: nil

The history value is not properly initialized. Seems like r87775
introduced a regression, because histval is not set to nil in minibuf.c.

During some more tests I noticed another faulty behaviour. With empty 
history
(unbound) I get an error message "variable void", when trying to get this
history (arrow up in minibuffer). Let's move the initialization of the 
history
a bit earlier, to prevent this error and receive expected message "Beginning
of history". Previously this initialization was at "add new entry" stage, so
history browsing was failing.

Finally the patch contains a fix for the regression and additionally a 
further
improvement.

Stefan, could you review the patch? If I am to commit this, to which
branch? emacs-24?




In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
 of 2014-05-07 on BONSOFTW7
Repository revision: 117068 
eggert <at> cs.ucla.edu-20140506211337-crc6ozt8y6967wq3
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=d:/program_files/emacs-master'

Configured features:
PNG NOTIFY ACL GNUTLS LIBXML2 ZLIB

Important settings:
  value of $LANG: pl
  locale-coding-system: cp1250

Major mode: Text

Minor modes in effect:
  diff-auto-refine-mode: t
  global-hl-line-mode: t
  recentf-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  size-indication-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<help-echo> C-x C-f j : / l a n g / g n u / e m <tab>
/ h i <tab> 1 <tab> <return> <next> <prior> C-x C-f
<up> <up> <up> <up> <down> <return> <C-end> <up> C-SPC
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up>
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up>
<up> <up> <down> M-w M-x r e p o r t <return>

Recent messages:
[yas] Loading compiled snippets from 
c:/Users/Jarek/AppData/Roaming/.emacs.d/snippets/sql-mode
[yas] Loading compiled snippets from 
c:/Users/Jarek/AppData/Roaming/.emacs.d/snippets/text-mode
Loading 
c:/Users/Jarek/AppData/Roaming/.emacs.d/snippets/text-mode/.yas-compiled-snippets.el 
(source)...done
[yas] Loading snippet files from 
c:/Users/Jarek/AppData/Roaming/.emacs.d/snippets/text-mode
[yas] Loaded ~/.emacs.d/snippets
[yas] Reloaded everything....
Loading hl-line...done
Loading whitespace...done
Loading grep...done
For information about GNU Emacs and the GNU system, type C-h C-a.

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message dired format-spec
rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util mail-prsvr mail-utils diff-mode grep compile comint ansi-color
ring whitespace hl-line cus-start cus-load xml-parse yasnippet derived
easy-mmode edmacro kmacro help-mode folding-isearch folding cl-macs
advice help-fns cl gv bookmark pp recentf tree-widget wid-edit
cl-loaddefs cl-lib easymenu server time-date tooltip electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp
w32-common-fns disp-table w32-win w32-vars tool-bar dnd fontset image
regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register
page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock
font-lock syntax facemenu font-core frame cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew
greek romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process w32notify w32
multi-tty emacs)

Memory information:
((conses 8 150932 5821)
 (symbols 24 22859 0)
 (miscs 20 102 150)
 (strings 16 24546 3867)
 (string-bytes 1 712166)
 (vectors 8 13203)
 (vector-slots 4 417745 4112)
 (floats 8 134 272)
 (intervals 28 363 32)
 (buffers 508 15))
[history_1_01.patch (text/plain, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#17430; Package emacs. (Wed, 07 May 2014 13:57:03 GMT) Full text and rfc822 format available.

Message #8 received at 17430 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Jarek Czekalski <jarekczek <at> poczta.onet.pl>
Cc: 17430 <at> debbugs.gnu.org
Subject: Re: bug#17430: 24.4.50; minibuffer history forgets the first entry
Date: Wed, 07 May 2014 09:55:57 -0400
> The history value is not properly initialized. Seems like r87775
> introduced a regression, because histval is not set to nil in minibuf.c.

Indeed, thanks.

> Stefan, could you review the patch? If I am to commit this, to which
> branch? emacs-24?

Looks good.  Please install on emacs-24.
But please also just initialize the variable directly in its
declaration, as in:

  Lisp_Object histval = find_symbol_value (Vminibuffer_history_variable);


-- Stefan




Reply sent to Jarek Czekalski <jarekczek <at> poczta.onet.pl>:
You have taken responsibility. (Wed, 07 May 2014 15:12:02 GMT) Full text and rfc822 format available.

Notification sent to Jarek Czekalski <jarekczek <at> poczta.onet.pl>:
bug acknowledged by developer. (Wed, 07 May 2014 15:12:03 GMT) Full text and rfc822 format available.

Message #13 received at 17430-done <at> debbugs.gnu.org (full text, mbox):

From: Jarek Czekalski <jarekczek <at> poczta.onet.pl>
To: 17430-done <at> debbugs.gnu.org
Subject: 24.4.50; minibuffer history forgets the first entry
Date: Wed, 07 May 2014 17:10:54 +0200
Applied as r117077 to emacs-24 branch [1]. Will be included in version 24.4.

http://bzr.savannah.gnu.org/lh/emacs/emacs-24/revision/117077





Forcibly Merged 17430 17432. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Wed, 07 May 2014 15:44:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#17430; Package emacs. (Wed, 07 May 2014 19:38:03 GMT) Full text and rfc822 format available.

Message #18 received at 17430 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>, 
 Jarek Czekalski <jarekczek <at> poczta.onet.pl>
Cc: 17430 <at> debbugs.gnu.org, Emacs development discussions <emacs-devel <at> gnu.org>
Subject: Re: [Emacs-diffs] emacs-24 r117077: Fix initialization of minibuffer
 history variable, bug #17430.
Date: Wed, 07 May 2014 12:37:30 -0700
On 05/07/2014 11:30 AM, Stefan Monnier wrote:
> Emacs currently presumes a C version that doesn't allow such 
> "declarations after statements".

Thanks, fixed in emacs-24 bzr 117079.  Indenting fixed too.






bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 05 Jun 2014 11:24:03 GMT) Full text and rfc822 format available.

This bug report was last modified 9 years and 300 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.