GNU bug report logs - #17438
xrandr linking problem on OS X

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 17438 in the body.
You can then email your comments to 17438 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: submit <at> debbugs.gnu.org
Subject: xrandr linking problem on OS X
Date: Thu, 08 May 2014 16:22:10 -0400

Package: emacs
Version: 24.4.50
Severity: important

hydra os x builds are currently failing with:
    
    Undefined symbols:
      "_XRRGetCrtcInfo", referenced from:
          _Fx_display_monitor_attributes_list in xfns.o
etc.

I think this is the first time it happened:
http://hydra.nixos.org/build/10792831       # trunk r117055

I think this is a due to a missing -lXrandr.

It looks like

pkg-config --libs "xrandr > 1.2.2"

returns "", but with exit status 0?


Compare with:
http://hydra.nixos.org/build/10778330   # trunk r117044

where the pkg-config query for xrandr failed, but the old-fashioned
fallback worked and added -lXrandr.

Message #6 received at 17438 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 17438 <at> debbugs.gnu.org
Subject: Re: bug#17438: xrandr linking problem on OS X
Date: Thu, 08 May 2014 16:35:35 -0400

Glenn Morris wrote:

> It looks like
>
> pkg-config --libs "xrandr > 1.2.2"
>
> returns "", but with exit status 0?

Yes; you can see config.log in the latest hydra build.

  pkg-config --exists --print-errors "xrandr > 1.2.2"

returns 0, and

  pkg-config --libs "xrandr > 1.2.2"

seems to return "".

Message #9 received at 17438 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 17438 <at> debbugs.gnu.org
Subject: Re: bug#17438: xrandr linking problem on OS X
Date: Thu, 08 May 2014 16:45:22 -0400

Glenn Morris wrote:

> Yes; you can see config.log in the latest hydra build.
>
>   pkg-config --exists --print-errors "xrandr > 1.2.2"
>
> returns 0, and
>
>   pkg-config --libs "xrandr > 1.2.2"
>
> seems to return "".

Whereas in the latest emacs-24 branch config.log we see:

    configure:14504: checking for xrandr >= 1.2.2
    Package randrproto was not found in the pkg-config search path.
    Perhaps you should add the directory containing `randrproto.pc'
    to the PKG_CONFIG_PATH environment variable
    Package 'randrproto', required by 'Xrandr', not found
    configure:14516: result: no

Message #12 received at 17438 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 17438 <at> debbugs.gnu.org
Subject: Re: bug#17438: xrandr linking problem on OS X
Date: Thu, 08 May 2014 18:00:52 -0400

I think this might be a pkg-config bug, eg

https://bugs.freedesktop.org/show_bug.cgi?id=64674
https://bugs.freedesktop.org/show_bug.cgi?id=43149

Message #15 received at 17438 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 17438 <at> debbugs.gnu.org
Subject: Re: bug#17438: xrandr linking problem on OS X
Date: Fri, 09 May 2014 09:44:06 +0300

> From: Glenn Morris <rgm <at> gnu.org>
> Date: Thu, 08 May 2014 18:00:52 -0400
> 
> 
> I think this might be a pkg-config bug, eg
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=64674
> https://bugs.freedesktop.org/show_bug.cgi?id=43149

That only hits ancient versions of pkg-config, before 0.26.  Do you
indeed have such an old version on Hydra?

Message #18 received at 17438 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 17438 <at> debbugs.gnu.org
Subject: Re: bug#17438: xrandr linking problem on OS X
Date: Fri, 09 May 2014 02:50:18 -0400

Eli Zaretskii wrote:

> That only hits ancient versions of pkg-config, before 0.26.  Do you
> indeed have such an old version on Hydra?

It's not my version, but yes, it is 0.23.

Options to fix this are: to require pkg-config >= 0.26 in autogen.sh
(the requirement in configure would be unchanged); 
or to copy a recent pkg.m4 into the m4 directory in the Emacs repo.
 

Message #21 received at 17438 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: 17438 <at> debbugs.gnu.org
Subject: Re: xrandr linking problem on OS X
Date: Sat, 10 May 2014 19:30:21 -0700

> Options to fix this are: to require pkg-config >= 0.26 in autogen.sh

That's easy enough to try, so I did that in trunk bzr 117081.  If it 
doesn't work I suppose we can try one of the other possibilities.

Message #24 received at 17438 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 17438 <at> debbugs.gnu.org
Subject: Re: bug#17438: xrandr linking problem on OS X
Date: Sat, 10 May 2014 22:34:47 -0400

Paul Eggert wrote:

>> Options to fix this are: to require pkg-config >= 0.26 in autogen.sh
>
> That's easy enough to try, so I did that in trunk bzr 117081.  If it
> doesn't work I suppose we can try one of the other possibilities.

This is going to break all hydra trunk builds (although they are broken
already due to no disk space right now...)
I have no way to update pkg-config on hydra, so would have preferred to
wait till someone replied to my

http://lists.gnu.org/archive/html/hydra-users/2014-05/msg00000.html

question.

Does configure.ac really need to require this version of pkg-config,
or just autogen.sh?

Message #27 received at 17438 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 17438 <at> debbugs.gnu.org
Subject: Re: bug#17438: xrandr linking problem on OS X
Date: Sat, 10 May 2014 20:11:15 -0700

Glenn Morris wrote:
> I have no way to update pkg-config on hydra, so would have preferred to
> wait

Ah, OK, I reverted the change then.

> Does configure.ac really need to require this version of pkg-config, or just autogen.sh?

If the xrandr configuration is failing due to a bug in older pkg-config 
versions, this suggests that configure.ac really needs the newer pkg-config.

I suppose we could go back to the emacs-24 way of doing things, and use 
or own PKG_CHECK_MODULES macro.

Message #30 received at 17438 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 17438 <at> debbugs.gnu.org
Subject: Re: bug#17438: xrandr linking problem on OS X
Date: Sun, 11 May 2014 13:58:15 -0400

Paul Eggert wrote:

>> Does configure.ac really need to require this version of pkg-config, or just autogen.sh?
>
> If the xrandr configuration is failing due to a bug in older
> pkg-config versions, this suggests that configure.ac really needs the
> newer pkg-config.

But it's not failing in that way in the emacs-24 branch on hydra, which
also uses pkg-config 0.23. So the problem is in pkg.m4 that older
pkg-config supply, not the pkg-config program.

I think it's that they don't do the equivalent of

--exists && --cflags && --libs

https://bugs.freedesktop.org/show_bug.cgi?id=29801

> I suppose we could go back to the emacs-24 way of doing things, and
> use or own PKG_CHECK_MODULES macro.

I think this is equivalent to my suggestion of copying pkg.m4 from a
recent pkg-config into our m4 directory.

But assuming we can get a newer pkg-config on hydra, I think it would be
fine to require >= 0.26 in autogen.sh, and leave configure.ac alone.

Message #33 received at 17438 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: eggert <at> cs.ucla.edu, 17438 <at> debbugs.gnu.org
Subject: Re: bug#17438: xrandr linking problem on OS X
Date: Sun, 11 May 2014 21:12:07 +0300

> From: Glenn Morris <rgm <at> gnu.org>
> Date: Sun, 11 May 2014 13:58:15 -0400
> Cc: 17438 <at> debbugs.gnu.org
> 
> But assuming we can get a newer pkg-config on hydra, I think it would be
> fine to require >= 0.26 in autogen.sh, and leave configure.ac alone.

Indeed.  If worse comes to worst, you should be able to install pkg.m4
locally, no?

Message #36 received at 17438 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: eggert <at> cs.ucla.edu, 17438 <at> debbugs.gnu.org
Subject: Re: bug#17438: xrandr linking problem on OS X
Date: Sun, 11 May 2014 14:15:51 -0400

Eli Zaretskii wrote:

>> But assuming we can get a newer pkg-config on hydra, I think it would be
>> fine to require >= 0.26 in autogen.sh, and leave configure.ac alone.
>
> Indeed.  If worse comes to worst, you should be able to install pkg.m4
> locally, no?

Locally where? I have no shell access to hydra.
I can only tweak the build recipe:

http://git.savannah.gnu.org/cgit/hydra-recipes.git/tree/emacs/release.nix

Message #39 received at 17438 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: eggert <at> cs.ucla.edu, 17438 <at> debbugs.gnu.org
Subject: Re: bug#17438: xrandr linking problem on OS X
Date: Sun, 11 May 2014 21:21:53 +0300

> From: Glenn Morris <rgm <at> gnu.org>
> Cc: eggert <at> cs.ucla.edu,  17438 <at> debbugs.gnu.org
> Date: Sun, 11 May 2014 14:15:51 -0400
> 
> I have no shell access to hydra.

Sorry, I didn't know that.

Message #42 received at 17438 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 17438 <at> debbugs.gnu.org
Subject: Re: bug#17438: xrandr linking problem on OS X
Date: Sun, 11 May 2014 12:15:40 -0700

Glenn Morris wrote:
> assuming we can get a newer pkg-config on hydra, I think it would be
> fine to require >= 0.26 in autogen.sh, and leave configure.ac alone.

I'd prefer that too, but in the meantime, as we are already wrapping 
PKG_CHECK_MODULES, our wrapper should be able to work around the 
pkg--config bug.  I gave that a shot in trunk bzr 117087.

If this sort of problem keeps cropping up, though, I'd rather that we 
copy pkg.m4 into our m4 directory.  We've spent a lot of time lately 
working around pkg-config bugs....

Message #45 received at 17438 <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: Glenn Morris <rgm <at> gnu.org>, 17438 <at> debbugs.gnu.org
Subject: Re: bug#17438: xrandr linking problem on OS X
Date: Mon, 12 May 2014 14:26:43 +0900

On Sun, 11 May 2014 12:15:40 -0700, Paul Eggert wrote:
> Glenn Morris wrote:
>> assuming we can get a newer pkg-config on hydra, I think it would be
>> fine to require >= 0.26 in autogen.sh, and leave configure.ac alone.

> I'd prefer that too, but in the meantime, as we are already wrapping
> PKG_CHECK_MODULES, our wrapper should be able to work around the
> pkg--config bug.  I gave that a shot in trunk bzr 117087.

> If this sort of problem keeps cropping up, though, I'd rather that we
> copy pkg.m4 into our m4 directory.  We've spent a lot of time lately
> working around pkg-config bugs....

Now the configure script runs this:

{/usr/bin/pkg-config --atleast-pkgconfig-version 0.26 ||
  {/usr/bin/pkg-config --cflags "RSVG" "librsvg-2.0 >= 2.11.0" &&
   /usr/bin/pkg-config --libs "RSVG" "librsvg-2.0 >= 2.11.0";}}

This causes ``configure: error:''.  But should it be the following?

{/usr/bin/pkg-config --atleast-pkgconfig-version 0.26 ||
  {/usr/bin/pkg-config --cflags "librsvg-2.0 >= 2.11.0" &&
   /usr/bin/pkg-config --libs "librsvg-2.0 >= 2.11.0";}}

--8<---------------cut here---------------start------------->8---
--- configure.ac~	2014-05-11 21:58:26.922779000 +0000
+++ configure.ac	2014-05-12 05:05:26.860889700 +0000
@@ -1366,7 +1366,7 @@
    emacs_check_module_ok=false
    AS_IF([test -n "$PKG_CONFIG" &&
 	  { $PKG_CONFIG --atleast-pkgconfig-version 0.26 ||
-	    { $PKG_CONFIG --cflags "$1" "$2" && $PKG_CONFIG --libs "$1" "$2"; }
+	    { $PKG_CONFIG --cflags "$2" && $PKG_CONFIG --libs "$2"; }
 	  } >/dev/null 2>&AS_MESSAGE_LOG_FD],
      [PKG_CHECK_MODULES([$1], [$2],
 	[$1_CFLAGS=`AS_ECHO(["$$1_CFLAGS"]) | sed -e "$edit_cflags"`
--8<---------------cut here---------------end--------------->8---

In GNU Emacs 24.4.50.1 (i686-pc-cygwin, GTK+ Version 3.10.7)
 of 2014-05-12 on localhost
Repository revision: 117087 eggert <at> cs.ucla.edu-20140511191412-hv0l7yzg3vwh49rq
Windowing system distributor `The Cygwin/X Project', version 11.0.11501000
Configured using:
 `configure --verbose --with-x-toolkit=gtk3'

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK DBUS GCONF GSETTINGS NOTIFY ACL
GNUTLS LIBXML2 FREETYPE XFT ZLIB

Message #48 received at 17438 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Katsumi Yamaoka <yamaoka <at> jpl.org>
Cc: 17438 <at> debbugs.gnu.org
Subject: Re: bug#17438: xrandr linking problem on OS X
Date: Sun, 11 May 2014 23:11:00 -0700

Katsumi Yamaoka wrote:
> -	    { $PKG_CONFIG --cflags "$1" "$2" && $PKG_CONFIG --libs "$1" "$2"; }
> +	    { $PKG_CONFIG --cflags "$2" && $PKG_CONFIG --libs "$2"; }

Thanks for catching that typo.  I installed that fix in your name as 
trunk bzr 117088.

Message #53 received at 17438 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 17438 <at> debbugs.gnu.org
Subject: Re: bug#17438: xrandr linking problem on OS X
Date: Mon, 12 May 2014 19:37:19 -0400

Paul Eggert wrote:

> [...] as we are already wrapping PKG_CHECK_MODULES, our wrapper should
> be able to work around the pkg--config bug. I gave that a shot in
> trunk bzr 117087.

Nice, seems to work. Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.