GNU bug report logs - #17487
Assume C99 or later in trunk

Previous Next

Package: emacs;

Reported by: Paul Eggert <eggert <at> cs.ucla.edu>

Date: Wed, 14 May 2014 01:13:02 UTC

Severity: minor

Tags: patch

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 17487 in the body.
You can then email your comments to 17487 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#17487; Package emacs. (Wed, 14 May 2014 01:13:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Paul Eggert <eggert <at> cs.ucla.edu>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 14 May 2014 01:13:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Emacs bug reports <bug-gnu-emacs <at> gnu.org>
Subject: Assume C99 or later in trunk
Date: Tue, 13 May 2014 18:11:46 -0700
[Message part 1 (text/plain, inline)]
Tags: patch

For some time I have ported Emacs to C89 whenever developers 
inadvertently change the mainline C code to use features like 
declarations-after-statements that C89 prohibits.  It's time for me to 
stop doing this job, as it's no longer useful.  As far as I know, no 
current Emacs target lacks a compiler that supports the relevant 
features.  GCC has supported the features for many years, even decades, 
and key GNU packages such as Coreutils have assumed them for quite some 
time.

To help move this along and to simplify maintenance a bit, I would like 
to install the attached patches into the trunk.  We don't need wholesale 
changes to rewrite Emacs's C code to use C99 features, but on the other 
hand we no longer need to keep porting to C89 and these minimal changes 
will help remind us of that.

The first attached patch is the main one.  The second patch is 
automatically generated by 'admin/merge-gnulib'.
[c99.diff (text/plain, attachment)]
[c99-auto.diff (text/plain, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#17487; Package emacs. (Wed, 14 May 2014 15:18:01 GMT) Full text and rfc822 format available.

Message #8 received at 17487 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: 17487 <at> debbugs.gnu.org
Subject: Re:  Assume C99 or later in trunk
Date: Wed, 14 May 2014 08:17:35 -0700
[Message part 1 (text/plain, inline)]
In further testing I found that Automake complains unless the 
corresponding change is also made to nt/gnulib.mk, so I'll also throw in 
the attached simplification to fix that problem.


[nt.diff (text/plain, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#17487; Package emacs. (Wed, 14 May 2014 15:37:01 GMT) Full text and rfc822 format available.

Message #11 received at 17487 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 17487 <at> debbugs.gnu.org
Subject: Re: bug#17487: Assume C99 or later in trunk
Date: Wed, 14 May 2014 18:36:22 +0300
> Date: Wed, 14 May 2014 08:17:35 -0700
> From: Paul Eggert <eggert <at> cs.ucla.edu>
> 
> In further testing I found that Automake complains unless the 
> corresponding change is also made to nt/gnulib.mk, so I'll also throw in 
> the attached simplification to fix that problem.

Thanks, it looks good to me.




Reply sent to Paul Eggert <eggert <at> cs.ucla.edu>:
You have taken responsibility. (Sat, 17 May 2014 08:16:02 GMT) Full text and rfc822 format available.

Notification sent to Paul Eggert <eggert <at> cs.ucla.edu>:
bug acknowledged by developer. (Sat, 17 May 2014 08:16:02 GMT) Full text and rfc822 format available.

Message #16 received at 17487-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 17487-done <at> debbugs.gnu.org
Subject: Re: bug#17487: Assume C99 or later in trunk
Date: Sat, 17 May 2014 01:14:55 -0700
Eli Zaretskii wrote:
> Thanks, it looks good to me.

Thanks, I tested it and tweaked it a bit more and installed it as trunk 
bzr 117119.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 14 Jun 2014 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 9 years and 316 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.