GNU bug report logs - #17519
[PATCH] take into account QuantumScale when reading imagemagick images

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 17519 in the body.
You can then email your comments to 17519 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Léveillé <nicolas <at> uucidl.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] take into account QuantumScale when reading imagemagick images
Date: Sat, 17 May 2014 15:25:56 +0200

[Message part 1 (text/plain, inline)]

Symptom:
On Macs with a freshly compiled "nexstep" emacs and no rsvg library, the splash screen displays a corrupted picture.

This patch is here corrects the "pixel pushing" (default) method for loading images from ImageMagick to properly interpret pixels from images loaded with ImageMagick compiled with any pixel quantum value. (Q32 for instance)

--

[0001-whitespace-cleanup-removed-tabs.patch (application/octet-stream, attachment)]

[0002-remove-visibility-of-some-variables.patch (application/octet-stream, attachment)]

[0003-properly-scale-pixels-from-pixelmagick.patch (application/octet-stream, attachment)]

[Message part 5 (text/plain, inline)]

Message #8 received at 17519 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Nicolas Léveillé <nicolas <at> uucidl.com>
Cc: 17519 <at> debbugs.gnu.org
Subject: Re: [PATCH] take into account QuantumScale when reading imagemagick
 images
Date: Mon, 19 May 2014 13:04:12 -0700

[Message part 1 (text/plain, inline)]

Thanks for reporting this. Does the attached simpler patch fix the 
problem for you?  Dividing by QuantumRange instead of multiplying by 
QuantumScale avoids potential double-rounding problems in future 
versions of ImageMagick.

[imagemagick.patch (text/x-patch, attachment)]

Message #11 received at 17519 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Léveillé <nicolas <at> uucidl.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 17519 <at> debbugs.gnu.org
Subject: Re: [PATCH] take into account QuantumScale when reading imagemagick
 images
Date: Tue, 20 May 2014 09:37:17 +0200

I'll come back to you once I'll have tested your patch.

Do you object with the other cleanups or is it poor form in this project to clean up code while fixing a bug? (Not sure what the philosophy in this project is, I tend to alway opportunistically do a little clean up (in separate commits/patches) when I fix bugs as a form of low intensity maintenance work)

Cheers,
Nicolas

On 2014-05-19, at 22:04 , Paul Eggert <eggert <at> cs.ucla.edu> wrote:

> Thanks for reporting this. Does the attached simpler patch fix the problem for you?  Dividing by QuantumRange instead of multiplying by QuantumScale avoids potential double-rounding problems in future versions of ImageMagick.
> <imagemagick.patch>

Message #14 received at 17519 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Nicolas Léveillé <nicolas <at> uucidl.com>
Cc: 17519 <at> debbugs.gnu.org
Subject: Re: [PATCH] take into account QuantumScale when reading imagemagick
 images
Date: Tue, 20 May 2014 01:07:37 -0700

Nicolas Léveillé wrote:
> Do you object with the other cleanups or is it poor form in this project to clean up code while fixing a bug?

Neither, but we're in a code freeze now (bug fixes only) and I looked 
only at the bug fix.

Message #17 received at 17519 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Léveillé <nicolas <at> uucidl.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 17519 <at> debbugs.gnu.org
Subject: Re: [PATCH] take into account QuantumScale when reading imagemagick
 images
Date: Wed, 21 May 2014 21:31:32 +0200

I tested this patch on OSX Mavericks, with ImageMagick compiled with a quantum of Q32, and it works

Nicolas

On 2014-05-19, at 22:04 , Paul Eggert <eggert <at> cs.ucla.edu> wrote:

> Thanks for reporting this. Does the attached simpler patch fix the problem for you?  Dividing by QuantumRange instead of multiplying by QuantumScale avoids potential double-rounding problems in future versions of ImageMagick.
> <imagemagick.patch>

Message #22 received at 17519-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Nicolas Léveillé <nicolas <at> uucidl.com>
Cc: 17519-done <at> debbugs.gnu.org
Subject: Re: [PATCH] take into account QuantumScale when reading imagemagick
 images
Date: Wed, 21 May 2014 12:54:07 -0700

Thanks for testing it.  I installed the fix as trunk bzr 117134 and am 
marking the bug as fixed.

Unfortunately this is an old bug and currently the emacs-24 branch is 
accepting fixes only for regressions, so this bug fix is not scheduled 
for the very next release, but it should appear in the release after 
that.  If it's more urgent to fix it for some reason, please let us know.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.