GNU bug report logs - #17695
24.3.91; [REGRESSION] face diff-added disappears in deeper-blue theme

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 17695 in the body.
You can then email your comments to 17695 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.91; [REGRESSION] face diff-added disappears in deeper-blue theme
Date: Thu, 05 Jun 2014 08:16:11 +0800

[Message part 1 (text/plain, inline)]

Note: this bug doesn't happen in emacs 24.3.

1. emacs -Q
2. M-x load-theme RET deeper-blue RET
3. open a patch in diff-mode.

Face: diff-added (sample) (customize this face)

Documentation:
`diff-mode' face used to highlight added lines.

Defined in `diff-mode.el'.

           Family: unspecified
          Foundry: unspecified
            Width: unspecified
           Height: unspecified
           Weight: unspecified
            Slant: unspecified
       Foreground: unspecified
DistantForeground: unspecified
       Background: unspecified
        Underline: unspecified
         Overline: unspecified
   Strike-through: unspecified
              Box: unspecified
          Inverse: unspecified
          Stipple: unspecified
             Font: unspecified
          Fontset: unspecified
          Inherit: unspecified

[deepblue.png (image/png, inline)]

Message #8 received at 17695 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Leo Liu <sdl.web <at> gmail.com>
Cc: 17695 <at> debbugs.gnu.org
Subject: Re: bug#17695: 24.3.91;
 [REGRESSION] face diff-added disappears in deeper-blue theme
Date: Thu, 05 Jun 2014 03:39:04 +0300

> Note: this bug doesn't happen in emacs 24.3.
>
> 1. emacs -Q
> 2. M-x load-theme RET deeper-blue RET
> 3. open a patch in diff-mode.
>
> Face: diff-added (sample) (customize this face)
>
> Documentation:
> `diff-mode' face used to highlight added lines.
>
> Defined in `diff-mode.el'.
>
>            Family: unspecified
>           Foundry: unspecified
>             Width: unspecified
>            Height: unspecified
>            Weight: unspecified
>             Slant: unspecified
>        Foreground: unspecified
> DistantForeground: unspecified
>        Background: unspecified
>         Underline: unspecified
>          Overline: unspecified
>    Strike-through: unspecified
>               Box: unspecified
>           Inverse: unspecified
>           Stipple: unspecified
>              Font: unspecified
>           Fontset: unspecified
>           Inherit: unspecified

This patch should fix it:

=== modified file 'etc/themes/deeper-blue-theme.el'
--- etc/themes/deeper-blue-theme.el	2014-01-01 07:43:34 +0000
+++ etc/themes/deeper-blue-theme.el	2014-06-05 00:38:30 +0000
@@ -40,8 +40,8 @@ (let ((class '((class color) (min-colors
    `(cperl-hash-face ((,class (:foreground "coral1"))))
    `(cursor ((,class (:background "green"))))
    `(default ((,class (:background "#181a26" :foreground "gray80"))))
-   `(diff-added ((,class (nil))))
-   `(diff-changed ((,class (nil))))
+   `(diff-added ((,class (:inherit diff-indicator-added))))
+   `(diff-changed ((,class (:inherit diff-indicator-changed))))
    `(diff-context ((,class (:foreground "seashell4"))))
    `(diff-file-header ((,class (:background "grey60"))))
    `(diff-function ((,class (:inherit diff-header))))
@@ -52,7 +52,7 @@ (let ((class '((class color) (min-colors
    `(diff-indicator-changed ((,class (:foreground "white" :background "dodgerblue4"))))
    `(diff-indicator-removed ((,class (:foreground "white" :background "indianred4"))))
    `(diff-refine-change ((,class (:background "skyblue4"))))
-   `(diff-removed ((,class (nil))))
+   `(diff-removed ((,class (:inherit diff-indicator-removed))))
    `(dired-marked ((,class (:background "dodgerblue3" :foreground "white"))))
    `(ediff-current-diff-A ((,class (:background "green4" :foreground "white"))))
    `(ediff-current-diff-B ((,class (:background "darkorange3" :foreground "white"))))

Message #11 received at 17695 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Leo Liu <sdl.web <at> gmail.com>
Cc: 17695 <at> debbugs.gnu.org
Subject: Re: bug#17695: 24.3.91;
 [REGRESSION] face diff-added disappears in deeper-blue theme
Date: Wed, 04 Jun 2014 21:09:50 -0400

Leo Liu wrote:

> 1. emacs -Q
> 2. M-x load-theme RET deeper-blue RET
> 3. open a patch in diff-mode.
>
> Face: diff-added (sample) (customize this face)

I don't think this is a bug.
The theme specifies attribute "nil" for this face (and some others).
As NEWS says:

  *** Face specs set via Custom themes now replace the `defface' spec
  rather than inheriting from it

So the theme gets what it asked for - every attribute unspecified.

If this was not what the theme author intended, perhaps the theme should
be changed.


(As an aside, what is the difference between "regression" and
"REGRESSION", and what is either supposed to actually mean in practice...)

Message #14 received at 17695 <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: Juri Linkov <juri <at> jurta.org>
Cc: 17695 <at> debbugs.gnu.org
Subject: Re: bug#17695: 24.3.91;
 [REGRESSION] face diff-added disappears in deeper-blue theme
Date: Thu, 05 Jun 2014 10:32:24 +0800

On 2014-06-05 03:39 +0300, Juri Linkov wrote:
> This patch should fix it:

I can confirm the fix.

Cheers,
Leo

Message #17 received at 17695 <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 17695 <at> debbugs.gnu.org
Subject: Re: bug#17695: 24.3.91;
 [REGRESSION] face diff-added disappears in deeper-blue theme
Date: Thu, 05 Jun 2014 10:40:07 +0800

On 2014-06-04 21:09 -0400, Glenn Morris wrote:
> (As an aside, what is the difference between "regression" and
> "REGRESSION", and what is either supposed to actually mean in practice...)

The capitalisation is done by my fingers so they come out randomly. 
I use it to mean something used to work stops working.

Leo

Message #22 received at 17695-done <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Leo Liu <sdl.web <at> gmail.com>
Cc: 17695-done <at> debbugs.gnu.org
Subject: Re: bug#17695: 24.3.91;
 [REGRESSION] face diff-added disappears in deeper-blue theme
Date: Fri, 06 Jun 2014 02:33:43 +0300

>> This patch should fix it:
>
> I can confirm the fix.

Regression is fixed.

Message #25 received at 17695 <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: 17695 <at> debbugs.gnu.org
Cc: juri <at> jurta.org
Subject: Re: bug#17695: 24.3.91;
 [REGRESSION] face diff-added disappears in deeper-blue theme
Date: Fri, 06 Jun 2014 17:28:30 +0800

On 2014-06-06 02:33 +0300, Juri Linkov wrote:
> Regression is fixed.

After some more use, there is still difference between 24.3 and 24.4 for
those faces.

It seems best just remove or comment out those faces.

Thanks,
Leo

Message #28 received at 17695 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Leo Liu <sdl.web <at> gmail.com>
Cc: 17695 <at> debbugs.gnu.org
Subject: Re: bug#17695: 24.3.91;
 [REGRESSION] face diff-added disappears in deeper-blue theme
Date: Sat, 07 Jun 2014 02:07:05 +0300

> After some more use, there is still difference between 24.3 and 24.4 for
> those faces.
>
> It seems best just remove or comment out those faces.

The default faces are good indeed, so removing overridden faces
from the theme makes sense.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.