GNU bug report logs - #17772
[PATCH] Dangling channels' buffer

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 17772 in the body.
You can then email your comments to 17772 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daimrod <daimrod <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Dangling channels' buffer
Date: Fri, 13 Jun 2014 19:41:55 +0900

[Message part 1 (text/plain, inline)]

Hi,

In the attached patch, I propose a fix for the recent change of the
function `rcirc-buffer-process'. This function used to return the rcirc
server process when it existed, or nil. However, since a78d87e7ed it
raises an error.

This is a problem if the user kills the server buffer before it kills
the channels' buffer because it is not possible to kill them after that.
(The function `rcirc-clean-up-buffer' is called via `kill-buffer-hook'
and it calls `rcirc-buffer-process'.)

WDYT?

Regards,

[0001-lisp-net-rcirc.el-rcirc-clean-up-buffer-Explicitly-c.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

--
Daimrod/Greg

Message #8 received at 17772 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Daimrod <daimrod <at> gmail.com>
Cc: Ryan Yeske <rcyeske <at> gmail.com>, Leo Liu <sdl.web <at> gmail.com>,
 17772 <at> debbugs.gnu.org
Subject: Re: bug#17772: [PATCH] Dangling channels' buffer
Date: Fri, 13 Jun 2014 14:36:16 -0400

> server process when it existed, or nil. However, since a78d87e7ed it
> raises an error.

Please avoid using Git references until we actually switch to Git.
Use dates, for example, instead.

> This is a problem if the user kills the server buffer before it kills
> the channels' buffer because it is not possible to kill them after that.
> (The function `rcirc-clean-up-buffer' is called via `kill-buffer-hook'
> and it calls `rcirc-buffer-process'.)

Your patch doesn't look bad, but I wonder if a better option wouldn't be
to try and better preserve the previous behavior.  E.g. with the
patch below.

WDYT?


        Stefan


=== modified file 'lisp/net/rcirc.el'
--- lisp/net/rcirc.el	2014-05-12 16:06:13 +0000
+++ lisp/net/rcirc.el	2014-06-13 18:34:01 +0000
@@ -803,9 +804,8 @@
   "Return the process associated with channel BUFFER.
 With no argument or nil as argument, use the current buffer."
   (let ((buffer (or buffer (if (buffer-live-p rcirc-server-buffer)
-			       rcirc-server-buffer
-			     (error "Server buffer deleted")))))
-    (or (with-current-buffer buffer rcirc-process)
+			       rcirc-server-buffer))))
+    (or (if buffer (with-current-buffer buffer rcirc-process))
 	rcirc-process)))
 
 (defun rcirc-server-name (process)

Message #11 received at 17772 <at> debbugs.gnu.org (full text, mbox):

From: Daimrod <daimrod <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Ryan Yeske <rcyeske <at> gmail.com>, Leo Liu <sdl.web <at> gmail.com>,
 17772 <at> debbugs.gnu.org
Subject: Re: bug#17772: [PATCH] Dangling channels' buffer
Date: Sat, 14 Jun 2014 10:04:04 +0900

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> server process when it existed, or nil. However, since a78d87e7ed it
>> raises an error.
>
> Please avoid using Git references until we actually switch to Git.
> Use dates, for example, instead.

Ok, I'll keep this in mind.

>> This is a problem if the user kills the server buffer before it kills
>> the channels' buffer because it is not possible to kill them after that.
>> (The function `rcirc-clean-up-buffer' is called via `kill-buffer-hook'
>> and it calls `rcirc-buffer-process'.)
>
> Your patch doesn't look bad, but I wonder if a better option wouldn't be
> to try and better preserve the previous behavior.  E.g. with the
> patch below.
>
> WDYT?

Fine for me, but you don't need the `or'.

> === modified file 'lisp/net/rcirc.el'
> --- lisp/net/rcirc.el	2014-05-12 16:06:13 +0000
> +++ lisp/net/rcirc.el	2014-06-13 18:34:01 +0000
> @@ -803,9 +804,8 @@
>    "Return the process associated with channel BUFFER.
>  With no argument or nil as argument, use the current buffer."
>    (let ((buffer (or buffer (if (buffer-live-p rcirc-server-buffer)
> -			       rcirc-server-buffer
> -			     (error "Server buffer deleted")))))
> -    (or (with-current-buffer buffer rcirc-process)
> +			       rcirc-server-buffer))))

+    (if buffer
+        (with-current-buffer buffer rcirc-process)
+      rcirc-process)))

> +    (or (if buffer (with-current-buffer buffer rcirc-process))
>  	rcirc-process)))
>  
>  (defun rcirc-server-name (process)
>

-- 
Daimrod/Greg

Message #14 received at 17772 <at> debbugs.gnu.org (full text, mbox):

From: Daimrod <daimrod <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Ryan Yeske <rcyeske <at> gmail.com>, Leo Liu <sdl.web <at> gmail.com>,
 17772 <at> debbugs.gnu.org
Subject: Re: bug#17772: [PATCH] Dangling channels' buffer
Date: Sat, 14 Jun 2014 10:20:07 +0900

[Message part 1 (text/plain, inline)]

Daimrod <daimrod <at> gmail.com> writes:

> Stefan Monnier <monnier <at> iro.umontreal.ca> writes:
>
>>> server process when it existed, or nil. However, since a78d87e7ed it
>>> raises an error.
>>
>> Please avoid using Git references until we actually switch to Git.
>> Use dates, for example, instead.
>
> Ok, I'll keep this in mind.

Here is a new patch with your proposal:

[0001-lisp-net-rcirc.el-rcirc-buffer-process-Return-the-pr.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Daimrod/Greg

Message #19 received at 17772-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: Daimrod <daimrod <at> gmail.com>
Cc: 17772-done <at> debbugs.gnu.org, Ryan Yeske <rcyeske <at> gmail.com>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#17772: [PATCH] Dangling channels' buffer
Date: Mon, 30 Jun 2014 10:59:32 +0800

Version: 24.5

On 2014-06-14 10:20 +0900, Daimrod wrote:
> Here is a new patch with your proposal:

Committed and thanks,

Leo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.