GNU bug report logs - #18125
file-precious-flag breaks symlinks

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18125 in the body.
You can then email your comments to 18125 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: submit <at> debbugs.gnu.org
Subject: file-precious-flag breaks symlinks
Date: Mon, 28 Jul 2014 02:34:13 -0400

Package: emacs
Version: 24.3.92

touch foo
ln -s foo bar
emacs-24.3.92  -Q --eval '(setq file-precious-flag t)' bar
change bar and save
   -> bar is no longer a symlink

AFAICS, it has always (since at least 22.3) been like this.
Does it have to be, though? Why can't it overwrite the target of the link?

In any case, the doc only mentions breaking hardlinks.

Setting find-file-visit-truename non-nil avoids the problem.

(Cf http://debbugs.gnu.org/454)

Message #6 received at 18125 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 18125 <at> debbugs.gnu.org
Subject: Re: bug#18125: file-precious-flag breaks symlinks
Date: Fri, 04 Dec 2020 12:40:19 +0100

Glenn Morris <rgm <at> gnu.org> writes:

> touch foo
> ln -s foo bar
> emacs-24.3.92  -Q --eval '(setq file-precious-flag t)' bar
> change bar and save
>    -> bar is no longer a symlink
>
> AFAICS, it has always (since at least 22.3) been like this.
> Does it have to be, though? Why can't it overwrite the target of the link?

This behaviour is still present in Emacs 28.

> In any case, the doc only mentions breaking hardlinks.
>
> Setting find-file-visit-truename non-nil avoids the problem.

I'm not sure whether this is a bug or whether it makes sense.  I'm
leaning towards...  bug?  Perhaps?  Anybody got an opinion here?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 18125 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: rgm <at> gnu.org, 18125 <at> debbugs.gnu.org
Subject: Re: bug#18125: file-precious-flag breaks symlinks
Date: Fri, 04 Dec 2020 14:07:50 +0200

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Date: Fri, 04 Dec 2020 12:40:19 +0100
> Cc: 18125 <at> debbugs.gnu.org
> 
> Glenn Morris <rgm <at> gnu.org> writes:
> 
> > touch foo
> > ln -s foo bar
> > emacs-24.3.92  -Q --eval '(setq file-precious-flag t)' bar
> > change bar and save
> >    -> bar is no longer a symlink
> >
> > AFAICS, it has always (since at least 22.3) been like this.
> > Does it have to be, though? Why can't it overwrite the target of the link?
> 
> This behaviour is still present in Emacs 28.
> 
> > In any case, the doc only mentions breaking hardlinks.
> >
> > Setting find-file-visit-truename non-nil avoids the problem.
> 
> I'm not sure whether this is a bug or whether it makes sense.  I'm
> leaning towards...  bug?  Perhaps?  Anybody got an opinion here?

IMO, we could provide the alternative behavior as opt-in, conditioned
on a new option.  It is not clear to me that everyone will want to
overwrite the target, so an incompatible change here must be an
opt-in.

Message #14 received at 18125 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: rgm <at> gnu.org, 18125 <at> debbugs.gnu.org
Subject: Re: bug#18125: file-precious-flag breaks symlinks
Date: Fri, 20 Aug 2021 16:21:52 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

> IMO, we could provide the alternative behavior as opt-in, conditioned
> on a new option.  It is not clear to me that everyone will want to
> overwrite the target, so an incompatible change here must be an
> opt-in.

It's a pretty specialised option (which makes it hard to explain), but I
get your point about being backwards-compatible in this area.

So I've now added the new option and adjusted the code.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.