GNU bug report logs - #18474
trunk; Warning in callproc.c while building for Mac OS X on trunk

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18474 in the body.
You can then email your comments to 18474 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: David Caldwell <david <at> porkrind.org>
To: bug-gnu-emacs <at> gnu.org
Subject: trunk; Warning in callproc.c while building for Mac OS X on trunk
Date: Sat, 13 Sep 2014 22:55:09 -0700

[Message part 1 (text/plain, inline)]

While building on Mac OS X, this code in src/callproc.c (line 1582ish):

#ifdef HAVE_NS
  if (data_dir == 0)
    data_dir == ns_etc_directory () != 0;
#endif

gives a warning:

cc   -c  -Demacs  -I. -I. -I../lib -I../lib                   -MMD -MF
deps/callproc.d -MP   -Wno-switch
-Wno-tautological-constant-out-of-range-compare -Wno-pointer-sign  -g3
-O2  callproc.c

callproc.c:1582:14: warning: comparison between pointer and integer
('int' and 'const char *')
    data_dir == ns_etc_directory () != 0;
    ~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~
callproc.c:1582:37: warning: inequality comparison result unused
[-Wunused-comparison]
    data_dir == ns_etc_directory () != 0;
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~

2 warnings generated.

Maybe s/==/=/ ?

Looks like it was added in bzr r117829 (the huge alloca() patch).

-David

[smime.p7s (application/pkcs7-signature, attachment)]

Message #10 received at 18474-done <at> debbugs.gnu.org (full text, mbox):

From: Jan Djärv <jan.h.d <at> swipnet.se>
To: David Caldwell <david <at> porkrind.org>
Cc: 18474-done <at> debbugs.gnu.org
Subject: Re: bug#18474: trunk;
 Warning in callproc.c while building for Mac OS X on trunk
Date: Sun, 14 Sep 2014 10:24:43 +0200

Hello.

14 sep 2014 kl. 07:55 skrev David Caldwell <david <at> porkrind.org>:

> 
> While building on Mac OS X, this code in src/callproc.c (line 1582ish):
> 
> #ifdef HAVE_NS
>  if (data_dir == 0)
>    data_dir == ns_etc_directory () != 0;
> #endif
> 
> gives a warning:
> 
> cc   -c  -Demacs  -I. -I. -I../lib -I../lib                   -MMD -MF
> deps/callproc.d -MP   -Wno-switch
> -Wno-tautological-constant-out-of-range-compare -Wno-pointer-sign  -g3
> -O2  callproc.c
> 
> callproc.c:1582:14: warning: comparison between pointer and integer
> ('int' and 'const char *')
>    data_dir == ns_etc_directory () != 0;
>    ~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~
> callproc.c:1582:37: warning: inequality comparison result unused
> [-Wunused-comparison]
>    data_dir == ns_etc_directory () != 0;
>    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
> 
> 2 warnings generated.
> 
> Maybe s/==/=/ ?
> 
> Looks like it was added in bzr r117829 (the huge alloca() patch).

An obvious typo, fixed now.  Thanks.

	Jan D.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.