GNU bug report logs - #18496
24.4.50; RefTeX modes should use font-lock-face instead of face

Previous Next

Package: emacs;

Reported by: Sebastian Wiesner <swiesner <at> lunaryorn.com>

Date: Thu, 18 Sep 2014 09:34:01 UTC

Severity: normal

Found in version 24.4.50

Done: Tassilo Horn <tsdh <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18496 in the body.
You can then email your comments to 18496 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#18496; Package emacs. (Thu, 18 Sep 2014 09:34:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Sebastian Wiesner <swiesner <at> lunaryorn.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 18 Sep 2014 09:34:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sebastian Wiesner <swiesner <at> lunaryorn.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.4.50; RefTeX modes should use font-lock-face instead of face
Date: Thu, 18 Sep 2014 11:32:37 +0200
The following RefTeX modes should use the font-lock-face text property
instead of face:

- reftex-toc-mode
- reftex-select-label-mode
- reftex-select-bib-mode

Using face directly breaks fontification if special minor modes are
enabled that add extra fontification.

Originally reported for rainbow-delimiters, see
https://github.com/jlr/rainbow-delimiters/issues/31 and
https://github.com/jlr/rainbow-delimiters/pull/38

On a related note, it seems as if these modes should probably inherit
special-mode, shouldn't they?




Reply sent to Tassilo Horn <tsdh <at> gnu.org>:
You have taken responsibility. (Sun, 21 Sep 2014 09:37:02 GMT) Full text and rfc822 format available.

Notification sent to Sebastian Wiesner <swiesner <at> lunaryorn.com>:
bug acknowledged by developer. (Sun, 21 Sep 2014 09:37:02 GMT) Full text and rfc822 format available.

Message #10 received at 18496-done <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tsdh <at> gnu.org>
To: Sebastian Wiesner <swiesner <at> lunaryorn.com>
Cc: 18496-done <at> debbugs.gnu.org
Subject: Re: bug#18496: 24.4.50;
 RefTeX modes should use font-lock-face instead of face
Date: Sun, 21 Sep 2014 11:36:08 +0200
Sebastian Wiesner <swiesner <at> lunaryorn.com> writes:

> The following RefTeX modes should use the font-lock-face text property
> instead of face:
>
> - reftex-toc-mode
> - reftex-select-label-mode
> - reftex-select-bib-mode
>
> Using face directly breaks fontification if special minor modes are
> enabled that add extra fontification.

Indeed, thanks for the hint.

> On a related note, it seems as if these modes should probably inherit
> special-mode, shouldn't they?

Yes, right.

I've done both in revision 117907.

Thanks,
Tassilo




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 19 Oct 2014 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 9 years and 204 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.