GNU bug report logs - #18575
package-test-signed should use skip-unless, not expected-result

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18575 in the body.
You can then email your comments to 18575 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: submit <at> debbugs.gnu.org
Subject: package-test-signed should use skip-unless, not expected-result
Date: Sat, 27 Sep 2014 15:00:39 -0400

Package: emacs
Version: 24.4.50
Severity: minor

package-test-signed should use skip-unless rather than expected-result.
The latter can lead to false "failures" when the test succeeds, eg

https://hydra.nixos.org/build/14915239/log/raw

Message #6 received at 18575 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 18575 <at> debbugs.gnu.org
Subject: Re: bug#18575: package-test-signed should use skip-unless,
 not expected-result
Date: Sat, 27 Sep 2014 18:01:42 -0400

Glenn Morris wrote:

> package-test-signed should use skip-unless rather than expected-result.
> The latter can lead to false "failures" when the test succeeds, eg
>
> https://hydra.nixos.org/build/14915239/log/raw

The fact that the test can pass even when epg-check-configuration fails
probably indicates that is the wrong thing to test anyway. The cause on
hydra is probably that HOME does not exist, which causes gpg
--list-config to fail:

  HOME=/tmp/foo/bar  gpg --with-colons --list-config
  gpg: fatal: can't create directory `/tmp/foo/bar/.gnupg': No such file or directory

Perhaps tests should bind epg-gpg-home-directory to a suitable value.

Message #9 received at 18575 <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 18575 <at> debbugs.gnu.org
Subject: Re: bug#18575: package-test-signed should use skip-unless,
 not expected-result
Date: Tue, 30 Sep 2014 09:18:28 -0400

On Sat, 27 Sep 2014 18:01:42 -0400 Glenn Morris <rgm <at> gnu.org> wrote: 

GM> Glenn Morris wrote:
>> package-test-signed should use skip-unless rather than expected-result.
>> The latter can lead to false "failures" when the test succeeds, eg
>> 
>> https://hydra.nixos.org/build/14915239/log/raw

GM> The fact that the test can pass even when epg-check-configuration fails
GM> probably indicates that is the wrong thing to test anyway. The cause on
GM> hydra is probably that HOME does not exist, which causes gpg
GM> --list-config to fail:

GM>   HOME=/tmp/foo/bar  gpg --with-colons --list-config
GM>   gpg: fatal: can't create directory `/tmp/foo/bar/.gnupg': No such file or directory

GM> Perhaps tests should bind epg-gpg-home-directory to a suitable value.

`package-refresh-contents` should create this directory and set it as
the EPG context's homedir. That does not depend, in theory, on
`epg-gpg-home-directory` because `package-refresh-contents` calls
`package-import-keyring` which does:

  (let ((context (epg-make-context 'OpenPGP))
	(homedir (expand-file-name "gnupg" package-user-dir)))
    (make-directory homedir t)
    (epg-context-set-home-directory context homedir)
    ...

Ted

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.