GNU bug report logs -
#18599
erc-input-ring-setup: do not reset the ring when there already is one
Previous Next
Reported by: Ivan Shmakov <ivan <at> siamics.net>
Date: Thu, 2 Oct 2014 05:12:01 UTC
Severity: normal
Fixed in version 24.5
Done: Ivan Shmakov <ivan <at> siamics.net>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18599 in the body.
You can then email your comments to 18599 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
erc-discuss <at> gnu.org, music.kashish <at> gmail.com, bug-gnu-emacs <at> gnu.org
:
bug#18599
; Package
emacs
.
(Thu, 02 Oct 2014 05:12:01 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Ivan Shmakov <ivan <at> siamics.net>
:
New bug report received and forwarded. Copy sent to
erc-discuss <at> gnu.org, music.kashish <at> gmail.com, bug-gnu-emacs <at> gnu.org
.
(Thu, 02 Oct 2014 05:12:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Package: emacs
X-Debbugs-Cc: erc-discuss <at> gnu.org, Kashish Sharma <music.kashish <at> gmail.com>
>>>>> Kashish Sharma <music.kashish <at> gmail.com> writes:
[…]
> 2. (what seems like another bug -) Input history is lost if one
> disconnects/reconnects.
Please consider the patch MIMEd.
(This one was also recently pointed out on IRC, BTW.)
> Wishlist - input history remembered across Emacs sessions. Perhaps
> with the option of setting the history size.
[…]
--
FSF associate member #7257 http://boycottsystemd.org/ … 3013 B6A0 230E 334A
[Message part 2 (text/diff, inline)]
--- a/lisp/erc/erc-ring.el
+++ b/lisp/erc/erc-ring.el
@@ -67,7 +67,8 @@
(defun erc-input-ring-setup ()
"Do the setup required so that we can use comint style input rings.
Call this function when setting up the mode."
- (setq erc-input-ring (make-ring comint-input-ring-size))
+ (unless (ring-p erc-input-ring)
+ (setq erc-input-ring (make-ring comint-input-ring-size)))
(setq erc-input-ring-index nil))
(defun erc-add-to-input-ring (s)
Reply sent
to
Ivan Shmakov <ivan <at> siamics.net>
:
You have taken responsibility.
(Fri, 21 Nov 2014 19:33:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
Ivan Shmakov <ivan <at> siamics.net>
:
bug acknowledged by developer.
(Fri, 21 Nov 2014 19:33:02 GMT)
Full text and
rfc822 format available.
Message #10 received at 18599-done <at> debbugs.gnu.org (full text, mbox):
Version: 24.5
I no longer observe the issue (as of 2014-11-18 build,
cb4f666ade76.) Per my reading of the Git log, it was fixed in
Git master back this October:
commit 3af2917c91e4eb863e1cec92a68ccb3acf940dae
Author: Ivan Shmakov <ivan <at> siamics.net>
AuthorDate: Thu Oct 2 07:31:56 2014 -0400
Commit: Kelvin White <kwhite <at> gnu.org>
CommitDate: Thu Oct 2 07:31:56 2014 -0400
Do not reset input ring if one exists
Fixes: debbugs:18599
In emacs-24, this bug was fixed as part of the following
“backport” change:
commit d1036d288de1e047f7f6043188a1063f0d6b044d
Author: l3thal <l3thal <at> debian>
AuthorDate: Sat Nov 8 20:51:43 2014 -0500
Commit: l3thal <l3thal <at> debian>
CommitDate: Sat Nov 8 20:51:43 2014 -0500
backport: erc bugfixes
--
FSF associate member #7257 http://boycottsystemd.org/ … 3013 B6A0 230E 334A
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Sat, 20 Dec 2014 12:24:05 GMT)
Full text and
rfc822 format available.
This bug report was last modified 9 years and 150 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.