GNU bug report logs - #18631
[PATCH] dfa: return NULL as can't find any predicates

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18631 in the body.
You can then email your comments to 18631 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: bug-grep <at> gnu.org
Subject: [PATCH] dfa: return NULL as can't find any predicates
Date: Sun, 05 Oct 2014 12:33:45 +0900

[Message part 1 (text/plain, inline)]

find_pred function is return an address to NULL pointer, but I think we
don't hope it.  So fix it.

BTW, it could never happen, as the syntax is checked in regex prior to it.

[0001-dfa-return-NULL-as-can-t-find-any-predicates.patch (text/plain, attachment)]

Message #8 received at 18631 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: 18631 <at> debbugs.gnu.org
Cc: 18631 <at> debbugs.gnu.org
Subject: Re: bug#18631: [PATCH] dfa: return NULL as can't find any predicates
Date: Sun, 07 Dec 2014 23:06:17 +0900

[Message part 1 (text/plain, inline)]

On Sun, 05 Oct 2014 12:33:45 +0900
Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:

> find_pred function is return an address to NULL pointer, but I think we
> don't hope it.  So fix it.
> 
> BTW, it could never happen, as the syntax is checked in regex prior to it.

I wrote and added a test driver for this bug which uses a program
`dfa-match-aux' added for tests recently.

The program will generate a core dump before the change.

[0001-dfa-return-NULL-as-can-t-find-any-predicates.patch (text/plain, attachment)]

Message #13 received at 18631-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 18631-done <at> debbugs.gnu.org
Subject: Re: bug#18631: [PATCH] dfa: return NULL as can't find any predicates
Date: Sat, 25 Apr 2015 12:48:46 -0700

[Message part 1 (text/plain, inline)]

On Sun, Dec 7, 2014 at 6:06 AM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
> On Sun, 05 Oct 2014 12:33:45 +0900
> Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
>
>> find_pred function is return an address to NULL pointer, but I think we
>> don't hope it.  So fix it.
>>
>> BTW, it could never happen, as the syntax is checked in regex prior to it.
>
> I wrote and added a test driver for this bug which uses a program
> `dfa-match-aux' added for tests recently.
>
> The program will generate a core dump before the change.

Thank you for the patch.
I have added to the commit log and adjusted the Makefile.am change
to insert the new test name in alphabetical order. I will push this shortly:

[0001-dfa-make-find_pred-return-NULL-for-an-invalid-predic.patch (application/octet-stream, attachment)]

Message #16 received at 18631-done <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: Jim Meyering <jim <at> meyering.net>
Cc: 18631-done <at> debbugs.gnu.org
Subject: Re: bug#18631: [PATCH] dfa: return NULL as can't find any predicates
Date: Mon, 27 Apr 2015 07:29:54 +0900

On Sat, 25 Apr 2015 12:48:46 -0700
Jim Meyering <jim <at> meyering.net> wrote:

> Thank you for the patch.
> I have added to the commit log and adjusted the Makefile.am change
> to insert the new test name in alphabetical order. I will push this shortly:

Thanks for review and ajustment.  I confirmed them.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.