GNU bug report logs - #18685
[PATCH] dfa: treat a multibyte character even with constraints

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18685 in the body.
You can then email your comments to 18685 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: bug-grep <at> gnu.org
Subject: [PATCH] dfa: treat a multibyte character even with constraints
Date: Sat, 11 Oct 2014 12:11:02 +0900

[Message part 1 (text/plain, inline)]

Set constraint, may be caused wrong result in non-UTF8 locales.  Below
fails in a current master.

  $ pattern=$(printf '^x\|\244\263')
  $ printf '\263\244\263\244\n' |
     env LC_ALL=ja_JP.eucJP src/grep "$pattern" && echo FAIL

skip_remains_mb runs in only state 0, but it's wrong.  Set constraint,
may transit to a state besides state 0 after failure.

[0001-dfa-treat-a-multibyte-character-even-with-constraint.patch (text/plain, attachment)]

Message #8 received at 18685 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: 18685 <at> debbugs.gnu.org
Subject: Re: bug#18685: [PATCH] dfa: treat a multibyte character even with
 constraints
Date: Sat, 11 Oct 2014 12:42:12 +0900

[Message part 1 (text/plain, inline)]

I added a news entry to a previous patch.

[0001-dfa-treat-a-multibyte-character-even-with-constraint.patch (text/plain, attachment)]

Message #11 received at 18685 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: 18685 <at> debbugs.gnu.org
Subject: Re: bug#18685: [PATCH] dfa: treat a multibyte character even with
 constraints
Date: Mon, 13 Oct 2014 21:36:22 +0900

[Message part 1 (text/plain, inline)]

Sorry, I found and fixed a bug in a previous patch.  A context should be
checked for a previous wide character instead of a next after skip.

[0001-dfa-treat-a-multibyte-character-even-with-constraint.patch (text/plain, attachment)]

Message #14 received at 18685 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 18685 <at> debbugs.gnu.org
Subject: Re: bug#18685: [PATCH] dfa: treat a multibyte character even with
 constraints
Date: Sat, 25 Oct 2014 19:54:58 -0700

[Message part 1 (text/plain, inline)]

Thank you for that patch.  I have made wording changes to comments
and logs in the attached patch. Please read them carefully and let us
know if you see a way to improve anything.

A note about commit logs: I changed the WCP parameter-adding entry so that it
says only "add a new parameter".  The description of how the new parameter
actually works belongs in the top-of-function comments in the code.  However,
since none of the parameters were described, I've gone ahead and added
descriptions for them as well as for your new one.

[0001-dfa-avoid-false-match-in-a-non-UTF8-multibyte-locale.patch (application/octet-stream, attachment)]

Message #17 received at 18685 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: Jim Meyering <jim <at> meyering.net>
Cc: 18685 <at> debbugs.gnu.org
Subject: Re: bug#18685: [PATCH] dfa: treat a multibyte character even with
 constraints
Date: Sun, 26 Oct 2014 15:39:38 +0900

[Message part 1 (text/plain, inline)]

Thanks for the review and changes.  I agree them, but I fixed a typo in
commit log.

[0001-dfa-avoid-false-match-in-a-non-UTF8-multibyte-locale.patch (text/plain, attachment)]

Message #22 received at 18685-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 18685-done <at> debbugs.gnu.org
Subject: Re: bug#18685: [PATCH] dfa: treat a multibyte character even with
 constraints
Date: Sun, 26 Oct 2014 08:06:51 -0700

> Thanks for the review and changes.  I agree them, but I fixed a typo in
> commit log.

Thanks.  FYI, it was a doubled "is", s/is is/is/.
Good reason for me to ensure flyspell-mode is enabled
all the time: it would have highlighted that.
Pushed.

On Sat, Oct 25, 2014 at 11:39 PM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
> Thanks for the review and changes.  I agree them, but I fixed a typo in
> commit log.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.