GNU bug report logs - #18707
[PATCH] dfa: print detail of DFA states in a debug mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18707 in the body.
You can then email your comments to 18707 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: bug-grep <at> gnu.org
Subject: [PATCH] dfa: print detail of DFA states in a debug mode
Date: Mon, 13 Oct 2014 19:39:21 +0900

[Message part 1 (text/plain, inline)]

If compile grep with -DDEBUG option, it outputs tokens etc.  In addition
to them, DFA states and transitions are output by this patch.  Debugging
them, the patch will be very useful.

BTW, the patch doesn't make any changes without -DDEBUG option.

[0001-dfa-print-detail-of-DFA-states-in-a-debug-mode.patch (text/plain, attachment)]

Message #8 received at 18707 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 18707 <at> debbugs.gnu.org
Subject: Re: bug#18707: [PATCH] dfa: print detail of DFA states in a debug mode
Date: Tue, 25 Nov 2014 09:26:42 +0900

[Message part 1 (text/plain, inline)]

On Mon, 13 Oct 2014 19:39:21 +0900
Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
> If compile grep with -DDEBUG option, it outputs tokens etc.  In addition
> to them, DFA states and transitions are output by this patch.  Debugging
> them, the patch will be very useful.
> 
> BTW, the patch doesn't make any changes without -DDEBUG option.

I fixed some warnings output in compilation, and rebased it.

[0001-dfa-print-detail-of-DFA-states-in-a-debug-mode.patch (application/octet-stream, attachment)]

Message #11 received at 18707 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 18707 <at> debbugs.gnu.org
Subject: Re: bug#18707: [PATCH] dfa: print detail of DFA states in a debug mode
Date: Sun, 19 Jul 2015 14:59:41 -0700

[Message part 1 (text/plain, inline)]

On Mon, Nov 24, 2014 at 4:26 PM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
> On Mon, 13 Oct 2014 19:39:21 +0900
> Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
>> If compile grep with -DDEBUG option, it outputs tokens etc.  In addition
>> to them, DFA states and transitions are output by this patch.  Debugging
>> them, the patch will be very useful.
>>
>> BTW, the patch doesn't make any changes without -DDEBUG option.
>
> I fixed some warnings output in compilation, and rebased it.

Thank you for your patience.
I applied this, changed many %zd to %zu (to ensure compilation
succeeded with -DDEBUG also when configured with
--enable-gcc-warnings) and adjusted the commit log entry. Will push
once you've ACK'd the result.

[0001-dfa-DEBUG-print-detail-of-DFA-states.patch (text/x-patch, attachment)]

Message #14 received at 18707 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: Jim Meyering <jim <at> meyering.net>
Cc: 18707 <at> debbugs.gnu.org
Subject: Re: bug#18707: [PATCH] dfa: print detail of DFA states in a debug mode
Date: Mon, 20 Jul 2015 10:33:34 +0900

On Sun, 19 Jul 2015 14:59:41 -0700
Jim Meyering <jim <at> meyering.net> wrote:

> On Mon, Nov 24, 2014 at 4:26 PM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
> > On Mon, 13 Oct 2014 19:39:21 +0900
> > Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
> >> If compile grep with -DDEBUG option, it outputs tokens etc.  In addition
> >> to them, DFA states and transitions are output by this patch.  Debugging
> >> them, the patch will be very useful.
> >>
> >> BTW, the patch doesn't make any changes without -DDEBUG option.
> >
> > I fixed some warnings output in compilation, and rebased it.
> 
> Thank you for your patience.
> I applied this, changed many %zd to %zu (to ensure compilation
> succeeded with -DDEBUG also when configured with
> --enable-gcc-warnings) and adjusted the commit log entry. Will push
> once you've ACK'd the result.

Thanks for changes and adjustment.  I agree all of them.

Message #19 received at 18707-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 18707-done <at> debbugs.gnu.org
Subject: Re: bug#18707: [PATCH] dfa: print detail of DFA states in a debug mode
Date: Sun, 19 Jul 2015 20:17:40 -0700

On Sun, Jul 19, 2015 at 6:33 PM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
> On Sun, 19 Jul 2015 14:59:41 -0700
> Jim Meyering <jim <at> meyering.net> wrote:
>
>> On Mon, Nov 24, 2014 at 4:26 PM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
>> > On Mon, 13 Oct 2014 19:39:21 +0900
>> > Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
>> >> If compile grep with -DDEBUG option, it outputs tokens etc.  In addition
>> >> to them, DFA states and transitions are output by this patch.  Debugging
>> >> them, the patch will be very useful.
>> >>
>> >> BTW, the patch doesn't make any changes without -DDEBUG option.
>> >
>> > I fixed some warnings output in compilation, and rebased it.
>>
>> Thank you for your patience.
>> I applied this, changed many %zd to %zu (to ensure compilation
>> succeeded with -DDEBUG also when configured with
>> --enable-gcc-warnings) and adjusted the commit log entry. Will push
>> once you've ACK'd the result.
>
> Thanks for changes and adjustment.  I agree all of them.

Thanks. Pushed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.