GNU bug report logs - #18760
24.4; Encoding problem in about-emacs

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18760 in the body.
You can then email your comments to 18760 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lars Ljung <lars <at> matholka.se>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.4; Encoding problem in about-emacs
Date: Sat, 18 Oct 2014 11:54:36 +0200

Hi,

The title of the tutorial is translated in the start-up screen. In the
case of Windows XP with a Swedish locale the title is in UTF-8 but the
buffer is in iso-8859-1. So "ä" in "användarhandledning" is shown as "ä".

The buffer is using UTF-8 on GNU/Linux so it's not a problem there.

Kind regards,
Lars Ljung

Message #8 received at 18760 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ljung <lars <at> matholka.se>
Cc: 18760 <at> debbugs.gnu.org
Subject: Re: bug#18760: 24.4; Encoding problem in about-emacs
Date: Sat, 18 Oct 2014 14:13:41 +0300

> Date: Sat, 18 Oct 2014 11:54:36 +0200
> From: Lars Ljung <lars <at> matholka.se>
> 
> The title of the tutorial is translated in the start-up screen. In the
> case of Windows XP with a Swedish locale the title is in UTF-8 but the
> buffer is in iso-8859-1. So "ä" in "användarhandledning" is shown as "ä".

Is that a GUI session or a -nw text-mode session?

Message #11 received at 18760 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ljung <lars <at> matholka.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 18760 <at> debbugs.gnu.org
Subject: Re: bug#18760: 24.4; Encoding problem in about-emacs
Date: Sat, 18 Oct 2014 13:24:54 +0200

Den 2014-10-18 13:13, Eli Zaretskii skrev:
>> Date: Sat, 18 Oct 2014 11:54:36 +0200
>> From: Lars Ljung <lars <at> matholka.se>
>>
>> The title of the tutorial is translated in the start-up screen. In the
>> case of Windows XP with a Swedish locale the title is in UTF-8 but the
>> buffer is in iso-8859-1. So "ä" in "användarhandledning" is shown as "ä".
> 
> Is that a GUI session or a -nw text-mode session?
> 

Only in the GUI. I looked at it a bit and my guess is that the encoding
is not properly detected when extracting the title using
(with-temp-buffer (insert-file-contents ... when defining
fancy-startup-text.

/Lars

Message #14 received at 18760 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ljung <lars <at> matholka.se>
Cc: 18760 <at> debbugs.gnu.org
Subject: Re: bug#18760: 24.4; Encoding problem in about-emacs
Date: Sat, 18 Oct 2014 15:24:55 +0300

> Date: Sat, 18 Oct 2014 13:24:54 +0200
> From: Lars Ljung <lars <at> matholka.se>
> CC: 18760 <at> debbugs.gnu.org
> 
> I looked at it a bit and my guess is that the encoding is not
> properly detected when extracting the title using (with-temp-buffer
> (insert-file-contents ... when defining fancy-startup-text.

But how can this happen, when the tutorial states that it's encoded in
UTF-8?

I just typed that form manually in a locale that also defaults to
Latin-1, and I see no problem at all.

Message #17 received at 18760 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ljung <lars <at> matholka.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 18760 <at> debbugs.gnu.org
Subject: Re: bug#18760: 24.4; Encoding problem in about-emacs
Date: Sat, 18 Oct 2014 14:36:50 +0200

Den 2014-10-18 14:24, Eli Zaretskii skrev:
>> Date: Sat, 18 Oct 2014 13:24:54 +0200
>> From: Lars Ljung <lars <at> matholka.se>
>> CC: 18760 <at> debbugs.gnu.org
>>
>> I looked at it a bit and my guess is that the encoding is not
>> properly detected when extracting the title using (with-temp-buffer
>> (insert-file-contents ... when defining fancy-startup-text.
> 
> But how can this happen, when the tutorial states that it's encoded in
> UTF-8?
> 
> I just typed that form manually in a locale that also defaults to
> Latin-1, and I see no problem at all.
> 

Perhaps since the encoding is specified at the end of the file but only
the first 256 bytes are read when extracting the title?

/Lars

Message #20 received at 18760 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ljung <lars <at> matholka.se>
Cc: 18760 <at> debbugs.gnu.org
Subject: Re: bug#18760: 24.4; Encoding problem in about-emacs
Date: Sat, 18 Oct 2014 15:57:22 +0300

> Date: Sat, 18 Oct 2014 14:36:50 +0200
> From: Lars Ljung <lars <at> matholka.se>
> CC: 18760 <at> debbugs.gnu.org
> 
> Den 2014-10-18 14:24, Eli Zaretskii skrev:
> >> Date: Sat, 18 Oct 2014 13:24:54 +0200
> >> From: Lars Ljung <lars <at> matholka.se>
> >> CC: 18760 <at> debbugs.gnu.org
> >>
> >> I looked at it a bit and my guess is that the encoding is not
> >> properly detected when extracting the title using (with-temp-buffer
> >> (insert-file-contents ... when defining fancy-startup-text.
> > 
> > But how can this happen, when the tutorial states that it's encoded in
> > UTF-8?
> > 
> > I just typed that form manually in a locale that also defaults to
> > Latin-1, and I see no problem at all.
> > 
> 
> Perhaps since the encoding is specified at the end of the file but only
> the first 256 bytes are read when extracting the title?

Where do you see that we only read the first 256 bytes?

Oh, you mean fancy-about-text?  I thought you were talking about
fancy-startup-text, where we read the entire file.

Yes, you are right, that's the bug.  Thanks.

Message #23 received at 18760 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>, Glenn Morris <rgm <at> gnu.org>
Cc: lars <at> matholka.se, 18760 <at> debbugs.gnu.org
Subject: Re: bug#18760: 24.4; Encoding problem in about-emacs
Date: Sat, 18 Oct 2014 16:01:38 +0300

> Date: Sat, 18 Oct 2014 15:57:22 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> Cc: 18760 <at> debbugs.gnu.org
> 
> > Perhaps since the encoding is specified at the end of the file but only
> > the first 256 bytes are read when extracting the title?
> 
> Where do you see that we only read the first 256 bytes?
> 
> Oh, you mean fancy-about-text?  I thought you were talking about
> fancy-startup-text, where we read the entire file.
> 
> Yes, you are right, that's the bug.  Thanks.

So, should we fix this on the emacs-24 branch?  Stefan?  Glenn?

Message #26 received at 18760 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ljung <lars <at> matholka.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 18760 <at> debbugs.gnu.org
Subject: Re: bug#18760: 24.4; Encoding problem in about-emacs
Date: Sat, 18 Oct 2014 15:02:23 +0200

Den 2014-10-18 14:24, Eli Zaretskii skrev:
>> Date: Sat, 18 Oct 2014 13:24:54 +0200
>> From: Lars Ljung <lars <at> matholka.se>
>> CC: 18760 <at> debbugs.gnu.org
>>
>> I looked at it a bit and my guess is that the encoding is not
>> properly detected when extracting the title using (with-temp-buffer
>> (insert-file-contents ... when defining fancy-startup-text.
> 
> But how can this happen, when the tutorial states that it's encoded in
> UTF-8?
> 
> I just typed that form manually in a locale that also defaults to
> Latin-1, and I see no problem at all.
> 

My mistake. The fault is in fancy-about-text, not fancy-startup-text. I
didn't realise there are two similar texts.

The code for fancy-startup-text used to have the same problem but it was
fixed in revision 109165. The same fix could probably be used in
fancy-about-text.

/Lars

Message #29 received at 18760 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: lars <at> matholka.se, Stefan Monnier <monnier <at> iro.umontreal.ca>,
 18760 <at> debbugs.gnu.org
Subject: Re: bug#18760: 24.4; Encoding problem in about-emacs
Date: Sat, 18 Oct 2014 13:26:50 -0400

Eli Zaretskii wrote:

> So, should we fix this on the emacs-24 branch?  Stefan?  Glenn?

Is this new in Emacs 24.4? (I guess not?)
Is it a major problem? (I guess not?)
So, my initial feeling is no.

(I'm going to be out of contact for the next ~ 24 hours, so I defer to
whatever the rest of you decide.)

Message #32 received at 18760 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: lars <at> matholka.se, monnier <at> iro.umontreal.ca, 18760 <at> debbugs.gnu.org
Subject: Re: bug#18760: 24.4; Encoding problem in about-emacs
Date: Sat, 18 Oct 2014 20:37:51 +0300

> From: Glenn Morris <rgm <at> gnu.org>
> Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>,  lars <at> matholka.se,  18760 <at> debbugs.gnu.org
> Date: Sat, 18 Oct 2014 13:26:50 -0400
> 
> Eli Zaretskii wrote:
> 
> > So, should we fix this on the emacs-24 branch?  Stefan?  Glenn?
> 
> Is this new in Emacs 24.4? (I guess not?)

No, 24.3 also has it.

> Is it a major problem? (I guess not?)

More like a minor annoyance (and no one complained before, so probably
not many people even try "Help->About Emacs".

Message #35 received at 18760 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Glenn Morris <rgm <at> gnu.org>, lars <at> matholka.se, 18760 <at> debbugs.gnu.org
Subject: Re: bug#18760: 24.4; Encoding problem in about-emacs
Date: Sat, 18 Oct 2014 15:19:49 -0400

> So, should we fix this on the emacs-24 branch?

Yes, but after 24.4 is released.


        Stefan

Message #40 received at 18760-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: rgm <at> gnu.org, lars <at> matholka.se, 18760-done <at> debbugs.gnu.org
Subject: Re: bug#18760: 24.4; Encoding problem in about-emacs
Date: Thu, 23 Oct 2014 19:34:01 +0300

> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Cc: Glenn Morris <rgm <at> gnu.org>,  lars <at> matholka.se,  18760 <at> debbugs.gnu.org
> Date: Sat, 18 Oct 2014 15:19:49 -0400
> 
> > So, should we fix this on the emacs-24 branch?
> 
> Yes, but after 24.4 is released.

Done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.