GNU bug report logs - #19094
Clean doc/{stamp-vti,version.texi}

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 19094 in the body.
You can then email your comments to 19094 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Santiago Ruano Rincón <santiago <at> debian.org>
To: bug-grep <at> gnu.org
Subject: Clean doc/{stamp-vti,version.texi}
Date: Tue, 18 Nov 2014 15:35:43 +0100

[Message part 1 (text/plain, inline)]

Hello,

Please, tell automake to clean doc/stamp-vti and doc/version.texi files.

I've come to this minor patch to make it possible to build the grep
debian package twice in a row (to build it over an already built
directory).

Thanks,

Santiago

[grep-doc-makefile-clean-files.patch (text/x-diff, attachment)]

Message #8 received at 19094 <at> debbugs.gnu.org (full text, mbox):

From: Eric Blake <eblake <at> redhat.com>
To: Santiago Ruano Rincón <santiago <at> debian.org>,
 19094 <at> debbugs.gnu.org
Subject: Re: bug#19094: Clean doc/{stamp-vti,version.texi}
Date: Tue, 18 Nov 2014 08:30:32 -0700

[Message part 1 (text/plain, inline)]

On 11/18/2014 07:35 AM, Santiago Ruano Rincón wrote:
> Hello,
> 
> Please, tell automake to clean doc/stamp-vti and doc/version.texi files.
> 

Sadly, this is not going to work.  These files are intentionally
distributed as part of the tarball so that users don't have to have all
the non-standard tools required to rebuild them; nuking them as part of
'make clean' would negate that benefit.  Nuking them during 'make
maintainer-clean' would be okay, but doesn't automake already do that?

> I've come to this minor patch to make it possible to build the grep
> debian package twice in a row (to build it over an already built
> directory).

What is the error you are seeing without this patch?  I'd rather fix the
root cause than poke at symptoms.

>  EXTRA_DIST = grep.in.1
> -CLEANFILES = grep.1 egrep.1 fgrep.1
> +CLEANFILES = grep.1 egrep.1 fgrep.1 stamp-vti version.texi
>  
>  grep.1: grep.in.1
>  	$(AM_V_GEN)rm -f $@-t $@
> diff --git a/gnulib b/gnulib
> index 46d015f..8415b67 160000
> --- a/gnulib
> +++ b/gnulib
> @@ -1 +1 @@
> -Subproject commit 46d015f9c3c959d2d9b9c3b9e9c99f3f420277b0
> +Subproject commit 8415b6792e53f9aa309caedda799f9d9f3dffc53

Also, your patch incorrectly changes the gnulib submodule.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[signature.asc (application/pgp-signature, attachment)]

Message #13 received at 19094-done <at> debbugs.gnu.org (full text, mbox):

From: Santiago Ruano Rincón <santiago <at> debian.org>
To: Eric Blake <eblake <at> redhat.com>
Cc: 19094-done <at> debbugs.gnu.org
Subject: Re: bug#19094: Clean doc/{stamp-vti,version.texi}
Date: Fri, 21 Nov 2014 12:14:05 +0100

El 18/11/14 a las 08:30, Eric Blake escribió:
> On 11/18/2014 07:35 AM, Santiago Ruano Rincón wrote:
> > Hello,
> > 
> > Please, tell automake to clean doc/stamp-vti and doc/version.texi files.
> > 
> 
> Sadly, this is not going to work.  These files are intentionally
> distributed as part of the tarball so that users don't have to have all
> the non-standard tools required to rebuild them; nuking them as part of
> 'make clean' would negate that benefit.  Nuking them during 'make
> maintainer-clean' would be okay, but doesn't automake already do that?
> 

make regenerates them. And yes, the problem is with the debian packaging
system, it doesn't like if changes in upstream sources are not included
in "known" patches. I've found a more debian suitable solution.

> > I've come to this minor patch to make it possible to build the grep
> > debian package twice in a row (to build it over an already built
> > directory).
> 
> What is the error you are seeing without this patch?  I'd rather fix the
> root cause than poke at symptoms.
> 
> >  EXTRA_DIST = grep.in.1
> > -CLEANFILES = grep.1 egrep.1 fgrep.1
> > +CLEANFILES = grep.1 egrep.1 fgrep.1 stamp-vti version.texi
> >  
> >  grep.1: grep.in.1
> >  	$(AM_V_GEN)rm -f $@-t $@
> > diff --git a/gnulib b/gnulib
> > index 46d015f..8415b67 160000
> > --- a/gnulib
> > +++ b/gnulib
> > @@ -1 +1 @@
> > -Subproject commit 46d015f9c3c959d2d9b9c3b9e9c99f3f420277b0
> > +Subproject commit 8415b6792e53f9aa309caedda799f9d9f3dffc53

Ouuch, I overlooked that!

Regards,

Santiago

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.