GNU bug report logs - #20337
authors.el needs updating before 25.1

Previous Next

Package: emacs;

Reported by: Glenn Morris <rgm <at> gnu.org>

Date: Wed, 15 Apr 2015 16:58:02 UTC

Severity: normal

Tags: notabug

Found in version 25.0.50

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 20337 in the body.
You can then email your comments to 20337 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#20337; Package emacs. (Wed, 15 Apr 2015 16:58:02 GMT) Full text and rfc822 format available.

Message #3 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: submit <at> debbugs.gnu.org
Subject: authors.el needs updating before 25.1
Date: Wed, 15 Apr 2015 12:57:28 -0400
Package: emacs
Version: 25.0.50

authors.el will need updating before the next release.
There's a FIXME comment, but I doubt that will get any attention.

I suspect the main problem is going be that was previously eg "files.el"
in the ChangeLog is now "lisp/files.el", which is going to make
authors.el think it refers to two separate files. Things like
authors-renamed-files-alist are set up on the basis of file names being
relative to the old per-directory C'logs. The fact that old and
new-style entries are mixed in the top-level ChangeLog.1 file is
probably going to be especially problematic.




Added indication that bug 20337 blocks19759 Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Wed, 15 Apr 2015 16:59:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#20337; Package emacs. (Mon, 25 Jan 2016 17:01:02 GMT) Full text and rfc822 format available.

Message #8 received at 20337 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 20337 <at> debbugs.gnu.org
Subject: Re: bug#20337: authors.el needs updating before 25.1
Date: Mon, 25 Jan 2016 12:00:04 -0500
Since authors.el is getting some attention of late, I just wanted to
remind about the following.

Glenn Morris wrote:

> authors.el will need updating before the next release.
> There's a FIXME comment, but I doubt that will get any attention.
>
> I suspect the main problem is going be that was previously eg "files.el"
> in the ChangeLog is now "lisp/files.el", which is going to make
> authors.el think it refers to two separate files. Things like
> authors-renamed-files-alist are set up on the basis of file names being
> relative to the old per-directory C'logs.

[...]

> The fact that old and new-style entries are mixed in the top-level
> ChangeLog.1 file is probably going to be especially problematic.

This last point no longer applies.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#20337; Package emacs. (Mon, 25 Jan 2016 21:51:02 GMT) Full text and rfc822 format available.

Message #11 received at 20337 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Petton <nicolas <at> petton.fr>
To: Glenn Morris <rgm <at> gnu.org>, 20337 <at> debbugs.gnu.org
Subject: Re: bug#20337: authors.el needs updating before 25.1
Date: Mon, 25 Jan 2016 22:50:21 +0100
[Message part 1 (text/plain, inline)]
Glenn Morris <rgm <at> gnu.org> writes:

> Since authors.el is getting some attention of late, I just wanted to
> remind about the following.

Thanks, I'll be careful about this and fix authors.el if needed.

Nico
[signature.asc (application/pgp-signature, inline)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#20337; Package emacs. (Mon, 25 Jan 2016 23:22:02 GMT) Full text and rfc822 format available.

Message #14 received at 20337 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Nicolas Petton <nicolas <at> petton.fr>
Cc: 20337 <at> debbugs.gnu.org
Subject: Re: bug#20337: authors.el needs updating before 25.1
Date: Mon, 25 Jan 2016 18:20:55 -0500
Thanks, it's good of you to look at this. (I'm not sure how easy it will be...)




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#20337; Package emacs. (Fri, 05 Feb 2016 17:12:01 GMT) Full text and rfc822 format available.

Message #17 received at 20337 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Petton <nicolas <at> petton.fr>
To: Glenn Morris <rgm <at> gnu.org>, 20337 <at> debbugs.gnu.org
Subject: Re: bug#20337: authors.el needs updating before 25.1
Date: Fri, 05 Feb 2016 18:11:10 +0100
[Message part 1 (text/plain, inline)]
Glenn Morris <rgm <at> gnu.org> writes:

>> authors.el will need updating before the next release.
>> There's a FIXME comment, but I doubt that will get any attention.
>>
>> I suspect the main problem is going be that was previously eg "files.el"
>> in the ChangeLog is now "lisp/files.el", which is going to make
>> authors.el think it refers to two separate files.

I updated etc/AUTHORS last week with authors.el, and double-checked
this, but I couldn't find any issue with the generated file.

Nico
[signature.asc (application/pgp-signature, inline)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#20337; Package emacs. (Fri, 05 Feb 2016 21:54:02 GMT) Full text and rfc822 format available.

Message #20 received at 20337 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Nicolas Petton <nicolas <at> petton.fr>
Cc: 20337 <at> debbugs.gnu.org
Subject: Re: bug#20337: authors.el needs updating before 25.1
Date: Fri, 05 Feb 2016 16:52:53 -0500
Nicolas Petton wrote:

> Glenn Morris <rgm <at> gnu.org> writes:
>
>>> I suspect the main problem is going be that was previously eg "files.el"
>>> in the ChangeLog is now "lisp/files.el", which is going to make
>>> authors.el think it refers to two separate files.
>
> I updated etc/AUTHORS last week with authors.el, and double-checked
> this, but I couldn't find any issue with the generated file.

I'm surprised, but maybe authors-canonical-file-name means it works
itself out? If a test with a dummy tree with only two separate
ChangeLogs, one in lisp/ containing an entry for "files.el", and
one in top-level with an entry for "lisp/files.el", results in an
AUTHORS file with just a single changed file, then maybe it all Just
Works...




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#20337; Package emacs. (Sun, 07 Feb 2016 17:12:02 GMT) Full text and rfc822 format available.

Message #23 received at 20337 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Petton <nicolas <at> petton.fr>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 20337 <at> debbugs.gnu.org
Subject: Re: bug#20337: authors.el needs updating before 25.1
Date: Sun, 07 Feb 2016 18:11:35 +0100
[Message part 1 (text/plain, inline)]
Glenn Morris <rgm <at> gnu.org> writes:

> Nicolas Petton wrote:
>
>> Glenn Morris <rgm <at> gnu.org> writes:
>>
>>>> I suspect the main problem is going be that was previously eg "files.el"
>>>> in the ChangeLog is now "lisp/files.el", which is going to make
>>>> authors.el think it refers to two separate files.
>>
>> I updated etc/AUTHORS last week with authors.el, and double-checked
>> this, but I couldn't find any issue with the generated file.
>
> I'm surprised, but maybe authors-canonical-file-name means it works
> itself out? If a test with a dummy tree with only two separate
> ChangeLogs, one in lisp/ containing an entry for "files.el", and
> one in top-level with an entry for "lisp/files.el", results in an
> AUTHORS file with just a single changed file, then maybe it all Just
> Works...

It seems to be the case, for instance, in lisp/ChangeLog.17 contains:

    2015-04-05  Pete Williamson  <petewil <at> chromium.org>  (tiny-change)
    
    	Fix .emacs and .emacs.d/init file recursion problem for NaCl
    	* files.el (file-truename): Add NaCl to the exception list ms-dos uses.

and ChangeLog also has many references to lisp/files.el, like the
following one:

    2016-01-16  Artur Malabarba  <bruce.connor.am <at> gmail.com>

	* lisp/files.el (dir-locals--all-files): Respect absolute file-names

	* lisp/help-fns.el (describe-variable): Fix a left-over parenthesis


The resulting etc/AUTHORS file contains the following entries:

    Artur Malabarba: wrote character-fold-tests.el faces-tests.el
      isearch-tests.el let-alist.el simple-test.el sort-tests.el
      tabulated-list-test.el
    and changed package.el isearch.el character-fold.el files.el
      tabulated-list.el package-test.el faces.el files-x.el menu-bar.el
      replace.el align.el bytecomp.el help-fns.el cl-lib-tests.el custom.el
      custom.texi map.el simple.el subr-tests.el variables.texi bindings.el
      and 37 other files

   [...]
   
    Pete Williamson: changed configure.ac files.el leim/Makefile.in
      lib-src/Makefile.in lisp/Makefile.in

Nico
[signature.asc (application/pgp-signature, inline)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#20337; Package emacs. (Mon, 08 Feb 2016 18:27:03 GMT) Full text and rfc822 format available.

Message #26 received at 20337 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Nicolas Petton <nicolas <at> petton.fr>
Cc: 20337 <at> debbugs.gnu.org
Subject: Re: bug#20337: authors.el needs updating before 25.1
Date: Mon, 08 Feb 2016 12:43:49 -0500
Well, I must have been worried about nothing.
Thank you for checking, and I'm sorry for the noise.




Added tag(s) notabug. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Mon, 08 Feb 2016 18:27:05 GMT) Full text and rfc822 format available.

bug closed, send any further explanations to 20337 <at> debbugs.gnu.org and Glenn Morris <rgm <at> gnu.org> Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Mon, 08 Feb 2016 18:27:05 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 08 Mar 2016 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 8 years and 22 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.