GNU bug report logs - #21273
[PATCH] grep: avoid use of uninitialized variable

Previous Next

Package: grep;

Reported by: Norihiro Tanaka <noritnk <at> kcn.ne.jp>

Date: Sun, 16 Aug 2015 02:19:02 UTC

Severity: normal

Tags: patch

Done: Jim Meyering <jim <at> meyering.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 21273 in the body.
You can then email your comments to 21273 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-grep <at> gnu.org:
bug#21273; Package grep. (Sun, 16 Aug 2015 02:19:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Norihiro Tanaka <noritnk <at> kcn.ne.jp>:
New bug report received and forwarded. Copy sent to bug-grep <at> gnu.org. (Sun, 16 Aug 2015 02:19:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: <bug-grep <at> gnu.org>
Subject: [PATCH] grep: avoid use of uninitialized variable
Date: Sun, 16 Aug 2015 11:17:52 +0900

[Message part 1 (text/plain, inline)]
Uninitialized value of variable BACKREF is referred in EGexecute.  It
does not cause wrong result, but regex may be used even when it is not
needed.  It may lead grep to slowdown.

By the way, gawk initializes the variable already, so it does not have
to be fixed.

[0001-grep-avoid-use-of-uninitialized-variable.patch (text/plain, attachment)]
Reply sent to Jim Meyering <jim <at> meyering.net>:
You have taken responsibility. (Thu, 20 Aug 2015 00:02:02 GMT) Full text and rfc822 format available.
Notification sent to Norihiro Tanaka <noritnk <at> kcn.ne.jp>:
bug acknowledged by developer. (Thu, 20 Aug 2015 00:02:03 GMT) Full text and rfc822 format available.

Message #10 received at 21273-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 21273-done <at> debbugs.gnu.org
Subject: Re: bug#21273: [PATCH] grep: avoid use of uninitialized variable
Date: Wed, 19 Aug 2015 17:00:41 -0700

On Sat, Aug 15, 2015 at 7:17 PM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
> Uninitialized value of variable BACKREF is referred in EGexecute.  It
> does not cause wrong result, but regex may be used even when it is not
> needed.  It may lead grep to slowdown.
>
> By the way, gawk initializes the variable already, so it does not have
> to be fixed.

Thank you for that fix. I have determined that the problem was
introduced since the latest release, so this does not require a
NEWS entry, then added that info and a paraphrasing of your
comment above to the commit log. Pushed here:

  http://git.savannah.gnu.org/cgit/grep.git/commit/?id=8a33cdeba4ba0
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 17 Sep 2015 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 8 years and 231 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.