GNU bug report logs - #21805
25.0.50; feature proposal: change vc-hg-annotate-command to something better readable

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 21805 in the body.
You can then email your comments to 21805 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Uwe Brauer <oub <at> mat.ucm.es>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50;
 feature proposal: change vc-hg-annotate-command to something better
 readable
Date: Sun, 01 Nov 2015 17:40:41 +0000

Hello

the current form of vc-hg-annotate-command leads to 


138 Tue Oct 20 16:49:01 2015 +0300 Trns/P1-Met/p1-met.tex: \usepackage[latin1]{inputenc} 
145 Sun Oct 25 17:10:38 2015 +0200 Trns/P1-Met/p1-met.tex: %\usepackage[T1]{fontenc}
138 Tue Oct 20 16:49:01 2015 +0300 Trns/P1-Met/p1-met.tex: \usepackage[spanish]{babel} 
153 Tue Oct 27 12:37:31 2015 +0000 Trns/P1-Met/p1-met.tex: %\usepackage{helvet}        

which is very difficult to read on not too wide screens. The reason is
the "-d" and the "-f" or "--follow" option.

So I propose to use 

(defun vc-hg-annotate-command (file buffer &optional revision)
  "Execute \"hg annotate\" on FILE, inserting the contents in BUFFER.
Optional arg REVISION is a revision to annotate from."
  (apply #'vc-hg-command buffer 0 file "annotate" "-dq" "-n" "-u"
	 (append (vc-switches 'hg 'annotate)
                 (if revision (list (concat "-r" revision))))))

Here "-u" is denotes the user "-dq" is the short date option, moreover
optionally --follow if this possible

the output would be 

oub 138 2015-10-20: \usepackage[latin1]{inputenc}
oub 145 2015-10-20: %\usepackage[T1]{fontenc}
oub 138 2015-10-20:\usepackage[spanish]{babel}
oub 153 2015-10-20: %\usepackage{helvet}


In order that the coloring would work, one should also modify the
regexp:

(defconst vc-hg-annotate-re ;org 
  "^[ \t]*\\([0-9]+\\) \\(.\\{30\\}\\)\\(?:\\(: \\)\\|\\(?: +\\([^:\n]+\\(?::\\(?:[^: \n][^:\n]*\\)?\\)*\\): \\)\\)")


Thanks

Uwe Brauer 

Message #10 received at 21805-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Uwe Brauer <oub <at> mat.ucm.es>, 21805-done <at> debbugs.gnu.org
Subject: Re: bug#21805: 25.0.50; feature proposal: change
 vc-hg-annotate-command to something better readable
Date: Sun, 10 Jan 2016 04:15:59 +0300

Version: 25.1

> Here "-u" is denotes the user "-dq" is the short date option, moreover
> optionally --follow if this possible

Made it to use "-dq", and moved "-u" and "--follow" to the default 
vc-hg-annotate-switches value, in c71e1e8.

You can customize that variable to remove "--follow", for instance.

Message #13 received at 21805-done <at> debbugs.gnu.org (full text, mbox):

From: Uwe Brauer <oub <at> mat.ucm.es>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: Uwe Brauer <oub <at> mat.ucm.es>, 21805-done <at> debbugs.gnu.org
Subject: Re: bug#21805: 25.0.50;
 feature proposal: change vc-hg-annotate-command to something better
 readable
Date: Wed, 20 Jan 2016 13:26:31 +0000

>>> "Dmitry" == Dmitry Gutov <dgutov <at> yandex.ru> writes:

   > Version: 25.1
   >> Here "-u" is denotes the user "-dq" is the short date option, moreover
   >> optionally --follow if this possible

   > Made it to use "-dq", and moved "-u" and "--follow" to the default
   > vc-hg-annotate-switches value, in c71e1e8.

   > You can customize that variable to remove "--follow", for instance.

Great, I tested it. Works as expected. I indeed removed the --follow
option.

Thanks

Uwe 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.