GNU bug report logs - #2603
defalias - doc string copied to definition

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 2603 in the body.
You can then email your comments to 2603 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: David Reitter <david.reitter <at> gmail.com>
To: emacs-pretest-bug <at> gnu.org
Subject: defalias - doc string copied to definition 
Date: Sun, 8 Mar 2009 19:40:43 -0400

[Message part 1 (text/plain, inline)]

It seems that a `defalias' call such as (defalias foo bar) will, in  
certain circumstances, set the doc string of BAR to the one of FOO,  
even though it should only set the doc string of FOO.  It also  
contains "[Missing arglist.  Please make a bug report.]".

This happens in case where FOO is a Lisp function, BAR is a Lisp  
accessor to a function defined in C source, and the defalias occurs in  
a preloaded (?) file in lisp/term.

The concrete example is in ns-win.el, for `ns-popup-font-panel'.  With  
the defalias in place, the `ns-popup-font-panel' DOC string will be  
the one previously assigned to `generate-fontset-menu'.


Note that the DOC file appears to contain the right (original) DOC  
strings for all functions.

Setting the doc string directly using defalias will result in BAR  
having the defined doc string, but FOO's doc string will still be  
overwritten.



;; Set to use font panel instead
(declare-function ns-popup-font-panel "nsfns.m" (&optional frame))
(defalias 'generate-fontset-menu 'ns-popup-font-panel "Pop up the font  
panel.
This function has been overloaded in NS.")
(defalias 'mouse-set-font 'ns-popup-font-panel "Pop up the font panel.
This function has been overloaded in NS.")

[smime.p7s (application/pkcs7-signature, attachment)]

Message #8 received at 2603 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> gnu.org>
To: David Reitter <david.reitter <at> gmail.com>
Cc: 2603 <at> debbugs.gnu.org
Subject: Re: bug#2603: defalias - doc string copied to definition
Date: Mon, 06 Feb 2012 21:46:24 +0800

David Reitter <david.reitter <at> gmail.com> writes:

> It seems that a `defalias' call such as (defalias foo bar) will, in
> certain circumstances, set the doc string of BAR to the one of FOO,
> even though it should only set the doc string of FOO.  It also
> contains "[Missing arglist.  Please make a bug report.]".
>
> This happens in case where FOO is a Lisp function, BAR is a Lisp
> accessor to a function defined in C source, and the defalias occurs in
> a preloaded (?) file in lisp/term.

I've committed a fix.  Thanks for the bug report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.