GNU bug report logs - #3462
Auto-fill VC log contents

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 3462 in the body.
You can then email your comments to 3462 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Lluis Vilanova <vilanova <at> ac.upc.edu>
To: bug-gnu-emacs <at> gnu.org
Subject: Auto-fill VC log contents
Date: Wed, 3 Jun 2009 21:17:29 +0200

I've written a simple `log-edit-fill' command that automatically fills the
`VC-log' by means of `add-change-log-entry-other-window'
(`diff-add-change-log-entries-other-window', in fact, so improvements on that
come for free in `log-edit-fill').

Although the function is currently very tied to my needs, I think other people
can also benefit from it. I know, I can always push the diff info into the
Changelog file and after that import it into VC-log, but:

    1) `log-edit-fill' streamlines this process

    2) I do not keep Changelog files on my projects

For people who keep a Changelog file, I think it would be more comfortable to:

    1) Import all changes into the log message (I think that modifying
       `add-change-log-entry' and related functions to accept a destination
       buffer instead of a file would be valuable, so changes can be directly
       pushed into the `VC-log' buffer)

    2) On log pre-commit push the editions in the log message into the Changelog
       file, write it to disk and add to commit set.

Of course, the other way around is also possible: commiting from VC can open the
Changelog with newly added entries, then writing it (or a specific command)
triggers the extraction of newly written information into the log message.

Multiple options are available, all depends on the desired flow of actions.

Just hope it could be integrated into VC in a way that maintains my renegation
from Changelog files, so I can delete that snippet from my initialization files
:)

In any case, I hope it can save some typing to you.

Ah! The code...
    http://www.emacswiki.org/emacs/log-edit-fill

Read you,
     Lluis

PS: I've tested this code only in debian's emacs-snapshot

-- 
 "And it's much the same thing with knowledge, for whenever you learn
 something new, the whole world becomes that much richer."
 -- The Princess of Pure Reason, as told by Norton Juster in The Phantom
 Tollbooth

Message #10 received at 3462 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Lluis Vilanova <vilanova <at> ac.upc.edu>
Cc: 3462 <at> debbugs.gnu.org
Subject: Re: bug#3462: Auto-fill VC log contents
Date: Thu, 04 Jun 2009 12:14:47 -0400

> (I think that modifying `add-change-log-entry' and related functions
> to accept a destination buffer instead of a file would be valuable, so
> changes can be directly pushed into the `VC-log' buffer)

Thank you.  Indeed, making add-log use the *VC-log* buffer (when it
exists and when there's no ChangeLog file) would be a very welcome
addition.  I believe it would provide the same functionality as your
log-edit-fill, but more generic and better integrated.

If you can cook up a patch for it, we would definitely consider it for
inclusion in Emacs-23.2


        Stefan

Message #15 received at 3462 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Lluis Vilanova <vilanova <at> ac.upc.edu>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 3462 <at> debbugs.gnu.org
Subject: Re: bug#3462: Auto-fill VC log contents
Date: Sun, 14 Jun 2009 22:58:10 +0200

[Message part 1 (text/plain, inline)]

El Thu, Jun 04, 2009 at 12:14:47PM -0400, Stefan Monnier ens deleit� amb les seg�ents paraules:
> > (I think that modifying `add-change-log-entry' and related functions
> > to accept a destination buffer instead of a file would be valuable, so
> > changes can be directly pushed into the `VC-log' buffer)
> 
> Thank you.  Indeed, making add-log use the *VC-log* buffer (when it
> exists and when there's no ChangeLog file) would be a very welcome
> addition.  I believe it would provide the same functionality as your
> log-edit-fill, but more generic and better integrated.
> 
> If you can cook up a patch for it, we would definitely consider it for
> inclusion in Emacs-23.2

Yay! Attached is a patch to both add-log and log-edit. Note that a few TODO's
are marked along add-log code where I couldn't understand what the code was
doing (just started to learn elisp... well, in fact just switched into emacs :)).

The major show-stoppers right now are:

* Couldn't get change-log-minor-mode to highlight the text as in
  change-log-mode.
* Would be nice to allow adding entries to the bottom of current change log
  block instead of the top.
* diff-add-change-log-entries-other-window has a somewhat strange behaviour and
  ends up showing two windows with the same Changelog/VC-log buffer (I think the
  bug was already there).

See that some changes were made into log-edit to seamlessly integrate with this
new feature in add-log.

As always, comments are welcome.

apa!

-- 
 "And it's much the same thing with knowledge, for whenever you learn
 something new, the whole world becomes that much richer."
 -- The Princess of Pure Reason, as told by Norton Juster in The Phantom
 Tollbooth

[change-log-use-buffer.patch (text/x-diff, attachment)]

Message #22 received at 3462 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Lluis Vilanova <vilanova <at> ac.upc.edu>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 3462 <at> debbugs.gnu.org
Subject: Re: bug#3462: Auto-fill VC log contents
Date: Wed, 11 Apr 2012 14:54:24 +0200

Lluis Vilanova <vilanova <at> ac.upc.edu> writes:

>> > (I think that modifying `add-change-log-entry' and related functions
>> > to accept a destination buffer instead of a file would be valuable, so
>> > changes can be directly pushed into the `VC-log' buffer)
>> 
>> Thank you.  Indeed, making add-log use the *VC-log* buffer (when it
>> exists and when there's no ChangeLog file) would be a very welcome
>> addition.  I believe it would provide the same functionality as your
>> log-edit-fill, but more generic and better integrated.
>> 
>> If you can cook up a patch for it, we would definitely consider it for
>> inclusion in Emacs-23.2

Well, it's now 24.2 time...  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Message #25 received at 3462 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Lluis Vilanova <vilanova <at> ac.upc.edu>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 3462 <at> debbugs.gnu.org
Subject: Re: bug#3462: Auto-fill VC log contents
Date: Sun, 24 Nov 2013 20:52:03 +0200

Hey Lluis,

Lluis Vilanova <vilanova <at> ac.upc.edu> writes:

> Yay! Attached is a patch to both add-log and log-edit. Note that a few TODO's
> are marked along add-log code where I couldn't understand what the code was
> doing (just started to learn elisp... well, in fact just switched into
> emacs :)).

Are you still interested in this feature? Do you have copyright
assignment papers signed? Your preliminary patch goes over the 15-line
limit, so we can't use it otherwise.

Message #28 received at 3462 <at> debbugs.gnu.org (full text, mbox):

From: Lluís Vilanova <vilanova <at> ac.upc.edu>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 3462 <at> debbugs.gnu.org
Subject: Re: bug#3462: Auto-fill VC log contents
Date: Tue, 26 Nov 2013 13:02:43 +0100

Dmitry Gutov writes:

> Hey Lluis,
> Lluis Vilanova <vilanova <at> ac.upc.edu> writes:

>> Yay! Attached is a patch to both add-log and log-edit. Note that a few TODO's
>> are marked along add-log code where I couldn't understand what the code was
>> doing (just started to learn elisp... well, in fact just switched into
>> emacs :)).

> Are you still interested in this feature? Do you have copyright > assignment papers signed? Your preliminary patch goes over the 2015-line
> limit, so we can't use it otherwise.

I don't think it's appropriate to accept it. AFAIR, detection of the "root"
directory was not working properly. I started re-implementing it from scratch,
but never got to finish it.


Lluis

-- 
 "And it's much the same thing with knowledge, for whenever you learn
 something new, the whole world becomes that much richer."
 -- The Princess of Pure Reason, as told by Norton Juster in The Phantom
 Tollbooth

Message #31 received at 3462 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Lluís Vilanova <vilanova <at> ac.upc.edu>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 3462 <at> debbugs.gnu.org
Subject: Re: bug#3462: Auto-fill VC log contents
Date: Tue, 26 Nov 2013 14:20:47 +0200

On 26.11.2013 14:02, Lluís Vilanova wrote:
>> Are you still interested in this feature? Do you have copyright > assignment papers signed? Your preliminary patch goes over the 2015-line
>> limit, so we can't use it otherwise.
>
> I don't think it's appropriate to accept it. AFAIR, detection of the "root"
> directory was not working properly. I started re-implementing it from scratch,
> but never got to finish it.

Maybe I'll finish this feature myself, using your patch as a start. But 
even that requires copyright assignment on your part, AFAIK.

Message #34 received at 3462 <at> debbugs.gnu.org (full text, mbox):

From: Lluís Vilanova <vilanova <at> ac.upc.edu>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 3462 <at> debbugs.gnu.org
Subject: Re: bug#3462: Auto-fill VC log contents
Date: Tue, 26 Nov 2013 14:15:10 +0100

Dmitry Gutov writes:

> On 26.11.2013 14:02, Lluís Vilanova wrote:
>>> Are you still interested in this feature? Do you have copyright > assignment papers signed? Your preliminary patch goes over the 2015-line
>>> limit, so we can't use it otherwise.
>> 
>> I don't think it's appropriate to accept it. AFAIR, detection of the "root"
>> directory was not working properly. I started re-implementing it from scratch,
>> but never got to finish it.

> Maybe I'll finish this feature myself, using your patch as a start. But even
> that requires copyright assignment on your part, AFAIK.

Ok, any pointer for instructions?


-- 
 "And it's much the same thing with knowledge, for whenever you learn
 something new, the whole world becomes that much richer."
 -- The Princess of Pure Reason, as told by Norton Juster in The Phantom
 Tollbooth

Message #37 received at 3462 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Lluís Vilanova <vilanova <at> ac.upc.edu>
Cc: 3462 <at> debbugs.gnu.org, Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#3462: Auto-fill VC log contents
Date: Tue, 26 Nov 2013 14:38:13 -0500

Lluís Vilanova wrote:

>> Maybe I'll finish this feature myself, using your patch as a start.
>> But even that requires copyright assignment on your part, AFAIK.
>
> Ok, any pointer for instructions?

I'll send you them off-list. Thanks!

Message #40 received at 3462 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: Dmitry Gutov <dgutov <at> yandex.ru>,
 Lluís Vilanova <vilanova <at> ac.upc.edu>, 3462 <at> debbugs.gnu.org
Subject: Re: bug#3462: Auto-fill VC log contents
Date: Mon, 29 Feb 2016 14:42:06 +1100

Glenn Morris <rgm <at> gnu.org> writes:

> Lluís Vilanova wrote:
>
>>> Maybe I'll finish this feature myself, using your patch as a start.
>>> But even that requires copyright assignment on your part, AFAIK.
>>
>> Ok, any pointer for instructions?
>
> I'll send you them off-list. Thanks!

That was a few years ago, and the copyright papers don't seem to have
arrived, so I'm closing this bug report...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.