GNU bug report logs - #4941
hexl mode update

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 4941 in the body.
You can then email your comments to 4941 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at quiet <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Vivek Dasmohapatra <vivek <at> etla.org>
To: quiet <at> debbugs.gnu.org
Subject: Re: hexl mode update
Date: Tue, 21 Jul 2009 01:44:58 +0100 (BST)

[Message part 1 (text/plain, inline)]

Severity: wishlist
Tags: patch

[ Resent from
 http://lists.gnu.org/archive/html/emacs-devel/2009-07/msg01028.html ]

On Thu, 16 Jul 2009, Stefan Monnier wrote:

>>> Now would be a good time to submit it,
>> Ok. Is there any particular branch/repo/etc you'd like a patch against?
>
> CVS trunk.  Note that I haven't looked at your code yet.  Please send it
> to emacs-devel <at> gnu.org.

Here it is. The user can select the "word size" hexl will use with defcustom
(it currently screws up if you change this size behind hexl's back, ie 
after hexlifying a buffer but before unhexlifying it: this could be fixed 
by saving the word size used in a a local variable in the hexl buffer,
let me know if you think this is important enough to add). Other than that, 
the hexl code doesn't seem to have changed since I last updated the patch
from emacs 22 to emacs 23.

The word-size could also be chosen at invocation time via a prefix arg, but 
I have not done this yet either: Again, let me know if you think it's
worth adding.

I originally prepared this patch for a friend who was debugging something 
and needed other word sizes: Upon investigation I discovered that the
hexl binary had support for the word sizes 8, 16, 32 and 64 bits but the
hexl mode code only supported one of those - hence this patch.

[hexl.variable-word-size.2009-07-21.patch (text/x-diff, attachment)]

Message #8 received at 4941 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Vivek Dasmohapatra <vivek <at> etla.org>
To: 4941 <at> debbugs.gnu.org
Subject: hexl mode update (variable word size in hexl mode)
Date: Wed, 16 Dec 2009 13:20:34 +0000 (GMT)

So, is anyone going to look at this? Vaguely encouraging noises were made 
the first time I submitted it, but that was many months (possibly even a 
few years) ago now, and no-one seems to have taken any interest in it since:
I don't mind if it's not wanted, but I'd rather know one way or another.

Message #11 received at 4941 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Vivek Dasmohapatra <vivek <at> etla.org>
Cc: 4941 <at> debbugs.gnu.org
Subject: Re: bug#4941: hexl mode update (variable word size in hexl mode)
Date: Wed, 23 Dec 2009 22:32:12 -0500

> So, is anyone going to look at this? Vaguely encouraging noises were made
> the first time I submitted it, but that was many months (possibly even a few
> years) ago now, and no-one seems to have taken any interest in it since:
> I don't mind if it's not wanted, but I'd rather know one way or another.

Sorry, I think this should be installed, but since we're already in
feature freeze again, we can't do it now.  As soon as we open up the
Emacs-24 branch (which should be real soon now, really), please come
back with a vengeance.  Say around end of January.


        Stefan

Message #14 received at 4941 <at> debbugs.gnu.org (full text, mbox):

From: Vivek Dasmohapatra <vivek <at> etla.org>
To: 4941 <at> debbugs.gnu.org
Subject: Re: bug#4941: hexl mode update (variable word size in hexl mode)
Date: Thu, 24 Dec 2009 18:23:13 +0000 (GMT)

Ok, I'll keep an eye out for the 24 branch.

Message #17 received at 4941 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: Vivek Dasmohapatra <vivek <at> etla.org>, 4941 <at> debbugs.gnu.org
Subject: Re: bug#4941: hexl mode update (variable word size in hexl mode)
Date: Wed, 11 Apr 2012 15:56:39 +0200

Stefan Monnier <monnier <at> IRO.UMontreal.CA> writes:

>> So, is anyone going to look at this? Vaguely encouraging noises were made
>> the first time I submitted it, but that was many months (possibly even a few
>> years) ago now, and no-one seems to have taken any interest in it since:
>> I don't mind if it's not wanted, but I'd rather know one way or another.
>
> Sorry, I think this should be installed, but since we're already in
> feature freeze again, we can't do it now.  As soon as we open up the
> Emacs-24 branch (which should be real soon now, really), please come
> back with a vengeance.  Say around end of January.

Vengeance apparently kinda slow, but perhaps now is the time?

The patch still mostly applies cleanly (one block fails), but I'm not a
hexl user, so I can't really test the result with great confidence.

Vivek, would it be possible for you to re-spin the patch (and test), and
then I can apply it.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Message #20 received at 4941 <at> debbugs.gnu.org (full text, mbox):

From: Vivek Dasmohapatra <vivek <at> etla.org>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: Stefan Monnier <monnier <at> IRO.UMontreal.CA>, 4941 <at> debbugs.gnu.org
Subject: Re: bug#4941: hexl mode update (variable word size in hexl mode)
Date: Wed, 11 Apr 2012 16:02:44 +0100 (BST)

[Message part 1 (text/plain, inline)]

On Wed, 11 Apr 2012, Lars Magne Ingebrigtsen wrote:

> Vengeance apparently kinda slow, but perhaps now is the time?
>
> The patch still mostly applies cleanly (one block fails), but I'm not a
> hexl user, so I can't really test the result with great confidence.
>
> Vivek, would it be possible for you to re-spin the patch (and test), and
> then I can apply it.

I've done some preliminary testing, seems to work (updated patch
is against master, but most of the relevant changes seem to have
happened during the emacs 23.x time frame anyway)

It's currently controlled by a defcustom, but maybe it should be
a prefix arg to hexl-find-file or hexl-mode instead? I don't
use hexl a huge amount myself so I'm not sure what its users
would prefer.

[0001-Allow-hexl-mode-to-use-8-16-32-or-64-bit-hexl-word-s.patch (text/x-diff, attachment)]

Message #23 received at 4941 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Vivek Dasmohapatra <vivek <at> etla.org>
Cc: Stefan Monnier <monnier <at> IRO.UMontreal.CA>, 4941 <at> debbugs.gnu.org
Subject: Re: bug#4941: hexl mode update (variable word size in hexl mode)
Date: Thu, 12 Apr 2012 18:00:14 +0200

Vivek Dasmohapatra <vivek <at> etla.org> writes:

> It's currently controlled by a defcustom, but maybe it should be
> a prefix arg to hexl-find-file or hexl-mode instead? I don't
> use hexl a huge amount myself so I'm not sure what its users
> would prefer.

`-mode' functions don't usually take additional arguments to control
setup, so I think having a defcustom here is fine.  I've applied your
patch to the Emacs trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Message #30 received at 4941 <at> debbugs.gnu.org (full text, mbox):

From: Vivek Dasmohapatra <vivek <at> etla.org>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: Stefan Monnier <monnier <at> IRO.UMontreal.CA>, 4941 <at> debbugs.gnu.org
Subject: Re: bug#4941: hexl mode update (variable word size in hexl mode)
Date: Thu, 12 Apr 2012 17:02:23 +0100 (BST)

> `-mode' functions don't usually take additional arguments to control
> setup, so I think having a defcustom here is fine.  I've applied your
> patch to the Emacs trunk.

One of the people I asked to test found a bug - as soon as he's verified the 
fix, I'll post a supplementary patch.

Message #33 received at 4941 <at> debbugs.gnu.org (full text, mbox):

From: Vivek Dasmohapatra <vivek <at> etla.org>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: Stefan Monnier <monnier <at> IRO.UMontreal.CA>, 4941 <at> debbugs.gnu.org
Subject: Re: bug#4941: hexl mode update (variable word size in hexl mode)
Date: Fri, 13 Apr 2012 01:39:51 +0100 (BST)

[Message part 1 (text/plain, inline)]

> `-mode' functions don't usually take additional arguments to control
> setup, so I think having a defcustom here is fine.  I've applied your
> patch to the Emacs trunk.

As I noted earlier, a user found a bug in the display code when
editing files in hexl - the hex portion of the display would get
scrambled when the word size was <> 16 bits.

The attached patch should fix that problem.

[hexl-editing.patch (text/x-diff, attachment)]

Message #36 received at 4941 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Vivek Dasmohapatra <vivek <at> etla.org>
Cc: Stefan Monnier <monnier <at> IRO.UMontreal.CA>, 4941 <at> debbugs.gnu.org
Subject: Re: bug#4941: hexl mode update (variable word size in hexl mode)
Date: Sat, 14 Apr 2012 13:08:15 +0200

Vivek Dasmohapatra <vivek <at> etla.org> writes:

> As I noted earlier, a user found a bug in the display code when
> editing files in hexl - the hex portion of the display would get
> scrambled when the word size was <> 16 bits.
>
> The attached patch should fix that problem.

Thanks; applied.

-- 
(domestic pets only, the antidote for overdose, milk.)
  http://lars.ingebrigtsen.no  *  Sent from my Rome

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.