GNU bug report logs - #5338
[PATCH] Make a new fortune dat file in compile time if dat file not exist

Previous Next

Package: emacs;

Reported by: Juanma Barranquero <lekktu <at> gmail.com>

Date: Fri, 8 Jan 2010 10:13:02 UTC

Severity: minor

Tags: patch

Fixed in version 24.4

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5338 in the body.
You can then email your comments to 5338 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to owner <at> debbugs.gnu.org, catap <at> catap.ru, bug-gnu-emacs <at> gnu.org:
bug#5338; Package emacs. (Fri, 08 Jan 2010 10:13:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Juanma Barranquero <lekktu <at> gmail.com>:
New bug report received and forwarded. Copy sent to catap <at> catap.ru, bug-gnu-emacs <at> gnu.org. (Fri, 08 Jan 2010 10:13:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Make a new fortune dat file in compile time if dat file not 
	exist
Date: Fri, 8 Jan 2010 11:12:25 +0100

Package: emacs
Severity: minor
tags: patch
X-Debbugs-CC: Kirill A. Korinskiy <catap <at> catap.ru>


---------- Forwarded message ----------
From: Kirill A. Korinskiy <catap <at> catap.ru>
Date: Fri, Jan 8, 2010 at 03:20
Subject: [PATCH] Make a new fortune dat file in compile time if dat
file not exist
To: emacs-devel <at> gnu.org
Cc: "Kirill A. Korinskiy" <catap <at> catap.ru>


---
 lisp/play/fortune.el |   24 +++++++++++++++---------
 1 files changed, 15 insertions(+), 9 deletions(-)

diff --git a/lisp/play/fortune.el b/lisp/play/fortune.el
index 3b895c7..0f92085 100644
--- a/lisp/play/fortune.el
+++ b/lisp/play/fortune.el
@@ -245,15 +245,21 @@ the value of `fortune-file'.  This currently
cannot handle directories."
  (let* ((fortune-file (expand-file-name (substitute-in-file-name file)))
        (fortune-dat (expand-file-name
                      (substitute-in-file-name
-                       (concat fortune-file fortune-database-extension)))))
-  (cond ((file-exists-p fortune-file)
-        (if (file-exists-p fortune-dat)
-            (cond ((file-newer-than-file-p fortune-file fortune-dat)
-                   (message "Compiling new fortune database %s" fortune-dat)
-                   (shell-command
-                    (concat fortune-strfile fortune-strfile-options
-                            " " fortune-file
fortune-quiet-strfile-options))))))
-       (t (error "Can't compile fortune file %s" fortune-file)))))
+                       (concat fortune-file fortune-database-extension))))
+        (fortune-file-exist (file-exists-p fortune-file))
+        (fortune-dat-exist (file-exists-p fortune-dat))
+        (fortune-file-newer (file-newer-than-file-p
+                             fortune-file fortune-dat)))
+    (cond
+     (fortune-file-exist
+      (if (or (not fortune-dat-exist)
+             (and fortune-dat-exist
+                  fortune-file-newer))
+         (message "Compiling new fortune database %s" fortune-dat)
+       (shell-command
+        (concat fortune-strfile fortune-strfile-options
+                " " fortune-file fortune-quiet-strfile-options))))
+     (t (error "Can't compile fortune file %s" fortune-file)))))


 ;;; **************
--
1.6.2
Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#5338; Package emacs. (Sun, 03 Jul 2011 19:38:01 GMT) Full text and rfc822 format available.

Message #8 received at 5338 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: "Kirill A. Korinskiy" <catap <at> catap.ru>,
	Juanma Barranquero <lekktu <at> gmail.com>, 5338 <at> debbugs.gnu.org
Subject: Re: [PATCH] Make a new fortune dat file in compile time if dat file
	not exist
Date: Sun, 03 Jul 2011 21:33:02 +0200

Juanma Barranquero <lekktu <at> gmail.com> writes:

> From: Kirill A. Korinskiy <catap <at> catap.ru>
> Date: Fri, Jan 8, 2010 at 03:20
> Subject: [PATCH] Make a new fortune dat file in compile time if dat
> file not exist
> To: emacs-devel <at> gnu.org, 5338 <at> debbugs.gnu.org
> Cc: "Kirill A. Korinskiy" <catap <at> catap.ru>

[...]

> +                       (concat fortune-file fortune-database-extension))))
> +        (fortune-file-exist (file-exists-p fortune-file))
> +        (fortune-dat-exist (file-exists-p fortune-dat))

The patch looks correct to me, but I haven't used fortune.el in a long
while.

However, since this is more than 10 lines of new code, we need copyright
assignment papers from the author.

Do we have copyright assignment papers from Kirill A. Korinskiy on file?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/
Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#5338; Package emacs. (Mon, 04 Jul 2011 02:41:02 GMT) Full text and rfc822 format available.

Message #11 received at 5338 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: Juanma Barranquero <lekktu <at> gmail.com>,
	"Kirill A. Korinskiy" <catap <at> catap.ru>, 5338 <at> debbugs.gnu.org
Subject: Re: bug#5338: [PATCH] Make a new fortune dat file in compile time if
	dat file not exist
Date: Sun, 03 Jul 2011 22:40:27 -0400

Lars Magne Ingebrigtsen <larsi <at> gnus.org> writes:

> Do we have copyright assignment papers from Kirill A. Korinskiy on file?

No.
Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#5338; Package emacs. (Mon, 04 Jul 2011 09:39:02 GMT) Full text and rfc822 format available.

Message #14 received at 5338 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: "Kirill A. Korinskiy" <catap <at> catap.ru>
Cc: Juanma Barranquero <lekktu <at> gmail.com>, Chong Yidong <cyd <at> stupidchicken.com>,
	5338 <at> debbugs.gnu.org
Subject: Re: bug#5338: [PATCH] Make a new fortune dat file in compile time if
	dat file not exist
Date: Mon, 04 Jul 2011 11:38:22 +0200

"Kirill A. Korinskiy" <catap <at> catap.ru> writes:

> Sorry, but what do you mean by copyright assignment papers?

The Free Software Foundation needs to have the copyright of all the code
in Emacs assigned to them.  Would you be willing to sign such papers?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/
Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#5338; Package emacs. (Mon, 04 Jul 2011 11:19:03 GMT) Full text and rfc822 format available.

Message #17 received at 5338 <at> debbugs.gnu.org (full text, mbox):

From: "Kirill A. Korinskiy" <catap <at> catap.ru>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: Juanma Barranquero <lekktu <at> gmail.com>,
	Lars Magne Ingebrigtsen <larsi <at> gnus.org>, 5338 <at> debbugs.gnu.org
Subject: Re: bug#5338: [PATCH] Make a new fortune dat file in compile time if
	dat file not exist
Date: Mon, 4 Jul 2011 11:53:32 +0400

[Message part 1 (text/plain, inline)]
On Mon, Jul 4, 2011 at 06:40, Chong Yidong <cyd <at> stupidchicken.com> wrote:

> Lars Magne Ingebrigtsen <larsi <at> gnus.org> writes:
>
> > Do we have copyright assignment papers from Kirill A. Korinskiy on file?
>
> No.
>

Sorry, but what do you mean by copyright assignment papers?

-- 
wbr, Kirill

[Message part 2 (text/html, inline)]
Reply sent to Glenn Morris <rgm <at> gnu.org>:
You have taken responsibility. (Wed, 13 Feb 2013 08:13:02 GMT) Full text and rfc822 format available.
Notification sent to Juanma Barranquero <lekktu <at> gmail.com>:
bug acknowledged by developer. (Wed, 13 Feb 2013 08:13:02 GMT) Full text and rfc822 format available.

Message #22 received at 5338-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 5338-done <at> debbugs.gnu.org
Subject: Re: bug#5338: [PATCH] Make a new fortune dat file in compile time if
	dat file not exist
Date: Wed, 13 Feb 2013 03:11:52 -0500

Version: 24.4

Sorry for the delay. At last applied.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 13 Mar 2013 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 11 years and 52 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.