GNU bug report logs - #6082
[PATCH] rcirc: rcirc-browse-url: Use only URLs before point and exclude consecutive duplicate URLs

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6082 in the body.
You can then email your comments to 6082 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Deniz Dogan <deniz.a.m.dogan <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Ryan Yeske <rcyeske <at> gmail.com>
Subject: [PATCH] rcirc: rcirc-browse-url: Use only URLs before point and 
	exclude consecutive duplicate URLs
Date: Mon, 3 May 2010 01:09:24 +0200

[Message part 1 (text/plain, inline)]

Attached is a patch which does the following:

Modifies rcirc-browse-url to only complete to buffers that are before
point in the current buffer. To accomplish this, the structure of
rcirc-urls has changed from being just a list of strings to a list of
strings and buffer positions.

Modifies rcirc-markup-urls to conform to the new structure of
rcirc-urls and so that any URL that is already the latest recognized
URL is not added to the list of URLs. This prevents "consecutive
duplicate URLs" from being stored.

[rcirc-browse-url-deniz-dogan.diff (text/plain, attachment)]

Message #8 received at 6082 <at> debbugs.gnu.org (full text, mbox):

From: Deniz Dogan <deniz <at> dogan.se>
To: 6082 <at> debbugs.gnu.org
Subject: Re: [PATCH] rcirc: rcirc-browse-url: Use only URLs before point and
	exclude consecutive duplicate URLs
Date: Tue, 04 Dec 2012 23:54:02 +0100

I am nowadays maintaining rcirc and since no one has responded in nearly 
three years, is it okay to implement this change?

Deniz

Message #11 received at 6082 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> gnu.org>
To: Deniz Dogan <deniz <at> dogan.se>
Cc: 6082 <at> debbugs.gnu.org
Subject: Re: bug#6082: [PATCH] rcirc: rcirc-browse-url: Use only URLs before
	point and exclude consecutive duplicate URLs
Date: Wed, 05 Dec 2012 11:36:20 +0800

Deniz Dogan <deniz <at> dogan.se> writes:

> I am nowadays maintaining rcirc and since no one has responded in
> nearly three years, is it okay to implement this change?

If you are maintaining rcirc, you make the call, i.e. go ahead.  (On the
trunk, of course, not on emacs-24.)

Message #14 received at 6082 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Deniz Dogan <deniz <at> dogan.se>
Cc: 6082 <at> debbugs.gnu.org
Subject: Re: bug#6082: [PATCH] rcirc: rcirc-browse-url: Use only URLs before
	point and exclude consecutive duplicate URLs
Date: Tue, 04 Dec 2012 22:47:52 -0500

> I am nowadays maintaining rcirc and since no one has responded in nearly
> three years, is it okay to implement this change?

You're the maintainer!


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.