GNU bug report logs - #7895
24.0.50; `image-dired-list-tags' should use `find-file-noselect', not `find-file'

Previous Next

Package: emacs;

Reported by: "Drew Adams" <drew.adams <at> oracle.com>

Date: Sun, 23 Jan 2011 17:55:02 UTC

Severity: normal

Found in version 24.0.50

Done: Chong Yidong <cyd <at> stupidchicken.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 7895 in the body.
You can then email your comments to 7895 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#7895; Package emacs. (Sun, 23 Jan 2011 17:55:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to "Drew Adams" <drew.adams <at> oracle.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 23 Jan 2011 17:55:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 24.0.50; `image-dired-list-tags' should use `find-file-noselect', not
	`find-file'
Date: Sun, 23 Jan 2011 10:01:07 -0800

Subject line says it all.  Use find-file-noselect plus `with-current-buffer' or
`set-buffer'.
 
In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
 of 2011-01-17 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4) --no-opt --cflags
-Ic:/imagesupport/include'
Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#7895; Package emacs. (Sun, 23 Jan 2011 18:34:02 GMT) Full text and rfc822 format available.

Message #8 received at 7895 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <7895 <at> debbugs.gnu.org>
Subject: RE: bug#7895: 24.0.50;
	`image-dired-list-tags' should use `find-file-noselect',
	not`find-file'
Date: Sun, 23 Jan 2011 10:40:49 -0800

> Use find-file-noselect plus `with-current-buffer' or
> `set-buffer'.

Same thing for `image-dired-get-comment', `image-dired-remove-tag',
`image-dired-mark-tagged-files', and `image-dired-create-gallery-lists'.

IOW, _all_ occurrences of `find-file' in `image-dired.el' are misguided.  They
should use `find-file-noselect', or in some other way not display the file.
Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#7895; Package emacs. (Mon, 08 Aug 2011 18:24:01 GMT) Full text and rfc822 format available.

Message #11 received at 7895 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 7895 <at> debbugs.gnu.org
Subject: Re: bug#7895: 24.0.50;
	`image-dired-list-tags' should use `find-file-noselect',
	not`find-file'
Date: Mon, 08 Aug 2011 14:22:12 -0400

>> Use find-file-noselect plus `with-current-buffer' or `set-buffer'.
>
> Same thing for `image-dired-get-comment', `image-dired-remove-tag',
> `image-dired-mark-tagged-files', and `image-dired-create-gallery-lists'.
>
> IOW, _all_ occurrences of `find-file' in `image-dired.el' are
> misguided.  They should use `find-file-noselect', or in some other way
> not display the file.

Fixed; thanks for the bug report.
bug closed, send any further explanations to 7895 <at> debbugs.gnu.org and "Drew Adams" <drew.adams <at> oracle.com> Request was from Chong Yidong <cyd <at> stupidchicken.com> to control <at> debbugs.gnu.org. (Mon, 08 Aug 2011 18:24:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 06 Sep 2011 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 12 years and 258 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.