GNU bug report logs - #8853
24.0.50; regression: doc string of `special-display-popup-frame'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 8853 in the body.
You can then email your comments to 8853 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 24.0.50; regression: doc string of `special-display-popup-frame'
Date: Mon, 13 Jun 2011 10:11:36 -0700

This regression was introduced in release 23.1.  Prior to that release,
the doc string said, correctly,
"If ARGS is a list whose car is a symbol, use (car ARGS) as a function
to do the work.  Pass it BUFFER as first arg, and (cdr ARGS) as the
rest of its args."
 
Now it says, incorrectly,
"If ARGS is a list whose car is a symbol, use (car ARGS) as a
function to do the work.  Pass it BUFFER as first argument,
and (cdr ARGS) as second."
 
If ARGS is a list whose car is a symbol `f', then
`special-display-popup-frame' invokes `f', passing it as arguments,
BUFFER followed by all of the elements in (cdr ARGS).  The arity of `f'
is the length of ARGS, not just 2.  We do not pass `f' (cdr ARGS) as a
second argument.
 

In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
 of 2011-06-13 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.5) --no-opt --cflags
-Ic:/build/include'
 

Message #8 received at 8853 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 8853 <at> debbugs.gnu.org
Subject: Re: bug#8853: 24.0.50;
	regression: doc string of `special-display-popup-frame'
Date: Tue, 14 Jun 2011 11:15:24 +0200

> This regression was introduced in release 23.1.  Prior to that release,
> the doc string said, correctly,
> "If ARGS is a list whose car is a symbol, use (car ARGS) as a function
> to do the work.  Pass it BUFFER as first arg, and (cdr ARGS) as the
> rest of its args."
>  
> Now it says, incorrectly,
> "If ARGS is a list whose car is a symbol, use (car ARGS) as a
> function to do the work.  Pass it BUFFER as first argument,
> and (cdr ARGS) as second."
>  
> If ARGS is a list whose car is a symbol `f', then
> `special-display-popup-frame' invokes `f', passing it as arguments,
> BUFFER followed by all of the elements in (cdr ARGS).  The arity of `f'
> is the length of ARGS, not just 2.  We do not pass `f' (cdr ARGS) as a
> second argument.

Indeed.  Could someone please restore the old doc-string in Emacs 23?

martin

Message #11 received at 8853 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 8853 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#8853: 24.0.50;
	regression: doc string of `special-display-popup-frame'
Date: Sun, 19 Jun 2011 15:05:24 -0400

martin rudalics <rudalics <at> gmx.at> writes:

>> This regression was introduced in release 23.1.  Prior to that release,
>> the doc string said, correctly,
>> "If ARGS is a list whose car is a symbol, use (car ARGS) as a function
>> to do the work.  Pass it BUFFER as first arg, and (cdr ARGS) as the
>> rest of its args."
>>  Now it says, incorrectly,
>> "If ARGS is a list whose car is a symbol, use (car ARGS) as a
>> function to do the work.  Pass it BUFFER as first argument,
>> and (cdr ARGS) as second."
>>  If ARGS is a list whose car is a symbol `f', then
>> `special-display-popup-frame' invokes `f', passing it as arguments,
>> BUFFER followed by all of the elements in (cdr ARGS).  The arity of `f'
>> is the length of ARGS, not just 2.  We do not pass `f' (cdr ARGS) as a
>> second argument.
>
> Indeed.  Could someone please restore the old doc-string in Emacs 23?

Fixed.

Message #18 received at 8853 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Chong Yidong'" <cyd <at> stupidchicken.com>,
	"'martin rudalics'" <rudalics <at> gmx.at>
Cc: 8853 <at> debbugs.gnu.org
Subject: RE: bug#8853: 24.0.50;
	regression: doc string of `special-display-popup-frame'
Date: Wed, 29 Jun 2011 09:58:00 -0700

> >> This regression was introduced in release 23.1.  Prior to 
> >> that release, the doc string said, correctly,
> >> "If ARGS is a list whose car is a symbol, use (car ARGS) 
> >> as a function to do the work.  Pass it BUFFER as first arg,
> >> and (cdr ARGS) as the rest of its args."

What's important here is "as the _rest_ of its args".

> >> Now it says, incorrectly, "If ARGS is a list whose car
> >> is a symbol, use (car ARGS) as a function to do the work.
> >> Pass it BUFFER as first argument, and (cdr ARGS) as second."
> >>
> >> If ARGS is a list whose car is a symbol `f', then
> >> `special-display-popup-frame' invokes `f', passing it as
> >> arguments, BUFFER followed by all of the elements in
> >> (cdr ARGS).  The arity of `f' is the length of ARGS, not
> >> just 2.  We do not pass `f' (cdr ARGS) as a second argument.
> >
> > Indeed.  Could someone please restore the old doc-string in 
> > Emacs 23?
> 
> Fixed.

No, I do not see this fixed in the latest Windows build of Emacs 24:

In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
 of 2011-06-27 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.5) --no-opt --cflags
-Ic:/build/include'

It still says: "Pass it BUFFER as first argument, and (cdr ARGS) as second."

The point of the bug fix should be to replace "as second" by "as the rest of its
args" or equivalent.  Thx.

Message #23 received at 8853-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 8853-done <at> debbugs.gnu.org
Subject: Re: bug#8853: 24.0.50;
	regression: doc string of `special-display-popup-frame'
Date: Wed, 29 Jun 2011 19:16:00 -0400

> > > Indeed.  Could someone please restore the old doc-string in Emacs 23?
> > 
> > Fixed.
> 
> No, I do not see this fixed in the latest Windows build of Emacs 24:

As indicated, it was fixed in the emacs-23 branch. This and other
changes will be merged to trunk in due course. Please be less eager to
reopen bugs.

Message #24 received at 8853-done <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Glenn Morris'" <rgm <at> gnu.org>, <8853-done <at> debbugs.gnu.org>
Subject: RE: bug#8853: 24.0.50;
	regression: doc string of `special-display-popup-frame'
Date: Thu, 30 Jun 2011 08:02:53 -0700

> > > Fixed.
> > 
> > No, I do not see this fixed in the latest Windows build of Emacs 24:
> 
> As indicated, it was fixed in the emacs-23 branch. This and other
> changes will be merged to trunk in due course. Please be less eager to
> reopen bugs.

OK, got it; thanks.

I didn't understand that I should not necessarily see the fix in the latest
Emacs 24 build.

Message #33 received at 8853 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Glenn Morris'" <rgm <at> gnu.org>, <8853 <at> debbugs.gnu.org>
Subject: RE: bug#8853: 24.0.50;
	regression: doc string of `special-display-popup-frame'
Date: Fri, 10 Aug 2012 09:47:23 -0700

FYI - I got an archived response for my report, so I went ahead and unarchived &
reopened it.

Message #36 received at 8853 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> gnu.org>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 'martin rudalics' <rudalics <at> gmx.at>, 8853 <at> debbugs.gnu.org
Subject: Re: bug#8853: 24.0.50;
	regression: doc string of `special-display-popup-frame'
Date: Sun, 16 Sep 2012 12:45:01 +0800

"Drew Adams" <drew.adams <at> oracle.com> writes:

>> > Indeed.  Could someone please restore the old doc-string in 
>> > Emacs 23?
>> 
>> Fixed.
>
> No, I do not see this fixed in the latest Windows build of Emacs 24:

The doc-string in Emacs 23 was wrong too, so restoring it did not fix
things.  Should be fixed now, sorry for the confusion.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.