GNU bug report logs - #8874
Redisplay confusion in Info, due to recentering fix

Previous Next

Package: emacs;

Reported by: Chong Yidong <cyd <at> stupidchicken.com>

Date: Wed, 15 Jun 2011 20:23:02 UTC

Severity: normal

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 8874 in the body.
You can then email your comments to 8874 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#8874; Package emacs. (Wed, 15 Jun 2011 20:23:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Chong Yidong <cyd <at> stupidchicken.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 15 Jun 2011 20:23:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Redisplay confusion in Info, due to recentering fix
Date: Wed, 15 Jun 2011 16:22:34 -0400
Recipe to reproduce:

emacs -q
M-: (setq scroll-conservatively 300) RET
C-h i
m CC mode RET
C-s k&r
C-s C-s C-s C-s

Emacs redisplay now shows a garbage window with no cursor.  C-l redraws
the window correctly.

This is caused by the recentering changes from March (revision 103792).
Reverting it eliminates the bug.




Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#8874; Package emacs. (Thu, 16 Jun 2011 15:52:02 GMT) Full text and rfc822 format available.

Message #8 received at 8874 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: 8874 <at> debbugs.gnu.org
Subject: Re: bug#8874: Redisplay confusion in Info, due to recentering fix
Date: Thu, 16 Jun 2011 18:49:08 +0300
> From: Chong Yidong <cyd <at> stupidchicken.com>
> Date: Wed, 15 Jun 2011 16:22:34 -0400
> 
> Recipe to reproduce:
> 
> emacs -q
> M-: (setq scroll-conservatively 300) RET
> C-h i
> m CC mode RET
> C-s k&r
> C-s C-s C-s C-s
> 
> Emacs redisplay now shows a garbage window with no cursor.  C-l redraws
> the window correctly.

Confirmed.

How urgent is it to fix this?  Can it be postponed until I'm done with
bidi reordering of display strings, and we enter code freeze?




Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#8874; Package emacs. (Fri, 17 Jun 2011 03:00:03 GMT) Full text and rfc822 format available.

Message #11 received at 8874 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Chong Yidong <cyd <at> stupidchicken.com>, 8874 <at> debbugs.gnu.org
Subject: Re: bug#8874: Redisplay confusion in Info, due to recentering fix
Date: Thu, 16 Jun 2011 22:58:57 -0400
> bidi reordering of display strings, and we enter code freeze?

Feature freeze is close, but code freeze is still far.


        Stefan




Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#8874; Package emacs. (Fri, 17 Jun 2011 07:06:02 GMT) Full text and rfc822 format available.

Message #14 received at 8874 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: cyd <at> stupidchicken.com, 8874 <at> debbugs.gnu.org
Subject: Re: bug#8874: Redisplay confusion in Info, due to recentering fix
Date: Fri, 17 Jun 2011 10:03:22 +0300
> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Cc: Chong Yidong <cyd <at> stupidchicken.com>,  8874 <at> debbugs.gnu.org
> Date: Thu, 16 Jun 2011 22:58:57 -0400
> 
> > bidi reordering of display strings, and we enter code freeze?
> 
> Feature freeze is close, but code freeze is still far.

So is it a yes or a no to my question?




Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#8874; Package emacs. (Fri, 17 Jun 2011 14:02:01 GMT) Full text and rfc822 format available.

Message #17 received at 8874 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: cyd <at> stupidchicken.com, 8874 <at> debbugs.gnu.org
Subject: Re: bug#8874: Redisplay confusion in Info, due to recentering fix
Date: Fri, 17 Jun 2011 09:23:46 -0400
>> > bidi reordering of display strings, and we enter code freeze?
>> Feature freeze is close, but code freeze is still far.
> So is it a yes or a no to my question?

I think it's OK to delay bug-fixing in order to get the missing
bidi-features installed sooner.


        Stefan




Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#8874; Package emacs. (Sat, 18 Jun 2011 18:08:01 GMT) Full text and rfc822 format available.

Message #20 received at 8874 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 8874 <at> debbugs.gnu.org
Subject: Re: bug#8874: Redisplay confusion in Info, due to recentering fix
Date: Sat, 18 Jun 2011 14:07:10 -0400
Eli Zaretskii <eliz <at> gnu.org> writes:

> How urgent is it to fix this?  Can it be postponed until I'm done with
> bidi reordering of display strings, and we enter code freeze?

The bidi work is more urgent, so feel free to postphone the fix for this
until you have the time.

FWIW, I took a quick look, and it appears that the following should do
the trick.  But it can wait till you have time to double-check the code.

*** src/xdisp.c	2011-06-14 18:57:19 +0000
--- src/xdisp.c	2011-06-18 18:03:55 +0000
***************
*** 14391,14397 ****
  	      if (pt_offset)
  		centering_position -= pt_offset;
  	      centering_position -=
! 		FRAME_LINE_HEIGHT (f) * (1 + margin + (last_line_misfit != 0));
  	      /* Don't let point enter the scroll margin near top of
  		 the window.  */
  	      if (centering_position < margin * FRAME_LINE_HEIGHT (f))
--- 14391,14397 ----
  	      if (pt_offset)
  		centering_position -= pt_offset;
  	      centering_position -=
! 		FRAME_LINE_HEIGHT (f) * (2 + margin + (last_line_misfit != 0));
  	      /* Don't let point enter the scroll margin near top of
  		 the window.  */
  	      if (centering_position < margin * FRAME_LINE_HEIGHT (f))




Reply sent to Eli Zaretskii <eliz <at> gnu.org>:
You have taken responsibility. (Tue, 23 Aug 2011 10:50:02 GMT) Full text and rfc822 format available.

Notification sent to Chong Yidong <cyd <at> stupidchicken.com>:
bug acknowledged by developer. (Tue, 23 Aug 2011 10:50:03 GMT) Full text and rfc822 format available.

Message #25 received at 8874-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: 8874-done <at> debbugs.gnu.org
Subject: Re: bug#8874: Redisplay confusion in Info, due to recentering fix
Date: Tue, 23 Aug 2011 13:40:00 +0300
> From: Chong Yidong <cyd <at> stupidchicken.com>
> Cc: 8874 <at> debbugs.gnu.org
> Date: Sat, 18 Jun 2011 14:07:10 -0400
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > How urgent is it to fix this?  Can it be postponed until I'm done with
> > bidi reordering of display strings, and we enter code freeze?
> 
> The bidi work is more urgent, so feel free to postphone the fix for this
> until you have the time.
> 
> FWIW, I took a quick look, and it appears that the following should do
> the trick.  But it can wait till you have time to double-check the code.

The problem was with the header line that Info uses by default, and
which was not accounted for when computing the new window start
position.  (If you set Info-use-header-line to nil, the bug goes
away.)

I fixed (in trunk revision 105541) the calculation of the window start
to account for the header line when it's present, and that solves the
bug.

Thanks.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 20 Sep 2011 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 12 years and 183 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.