GNU bug report logs - #9066
cleanup: remove conditional preprocessor code that depends on __STDC__

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 9066 in the body.
You can then email your comments to 9066 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dan Nicolaescu <dann <at> gnu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: cleanup: remove conditional preprocessor code that depends on
	__STDC__ 
Date: Wed, 13 Jul 2011 11:03:36 -0400

The source now assumes standard C, there are a few places that test __STDC__, 
those tests are not needed anymore.

Message #10 received at 9066 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Dan Nicolaescu <dann <at> gnu.org>
Cc: 9066 <at> debbugs.gnu.org
Subject: Re: cleanup: remove conditional preprocessor code that depends on
	__STDC__
Date: Thu, 14 Jul 2011 20:27:10 +0200

Dan Nicolaescu <dann <at> gnu.org> writes:

> The source now assumes standard C, there are a few places that test __STDC__, 
> those tests are not needed anymore.

This was marked "notabug" by...  somebody...  so I'm closing the report.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Message #13 received at 9066 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: Dan Nicolaescu <dann <at> gnu.org>, 9066 <at> debbugs.gnu.org
Subject: Re: bug#9066: cleanup: remove conditional preprocessor code that
	depends on __STDC__
Date: Thu, 14 Jul 2011 14:57:41 -0400

Lars Magne Ingebrigtsen wrote:

> Dan Nicolaescu <dann <at> gnu.org> writes:
>
>> The source now assumes standard C, there are a few places that test __STDC__, 
>> those tests are not needed anymore.
>
> This was marked "notabug" by...  somebody...  so I'm closing the report.

Closing is not appropriate. I marked it as notabug, because it isn't an
actual "bug", IMO. But it is a TODO item, and this tracker is used for
keeping track of those as well. So it should stay open, and actually get
fixed after the feature freeze ends.

I mean personally I wouldn't file this kind of trivia as a tracker item,
but if people want to...

Message #18 received at 9066 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: Dan Nicolaescu <dann <at> gnu.org>, 9066 <at> debbugs.gnu.org
Subject: Re: bug#9066: cleanup: remove conditional preprocessor code that
	depends on __STDC__
Date: Thu, 14 Jul 2011 21:06:16 +0200

Glenn Morris <rgm <at> gnu.org> writes:

> Closing is not appropriate. I marked it as notabug, because it isn't an
> actual "bug", IMO. But it is a TODO item, and this tracker is used for
> keeping track of those as well. So it should stay open, and actually get
> fixed after the feature freeze ends.

I'm thinking "notabug" is what other bug tracking systems say is
"invalid".  That is, the report talks of something that is the way it
should be, a la, "doctor, when I poke a finger in my eye it hurts".

I'll reopen the bug.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Message #21 received at 9066 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: Dan Nicolaescu <dann <at> gnu.org>, 9066 <at> debbugs.gnu.org
Subject: Re: bug#9066: cleanup: remove conditional preprocessor code that
	depends on __STDC__
Date: Thu, 14 Jul 2011 15:27:05 -0400

Lars Magne Ingebrigtsen wrote:

> I'm thinking "notabug" is what other bug tracking systems say is
> "invalid".

To me, notabug means... "this is not a bug".

Maybe "wontfix" + "notabug" = "invalid".

Message #24 received at 9066 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: Dan Nicolaescu <dann <at> gnu.org>, 9066 <at> debbugs.gnu.org
Subject: Re: bug#9066: cleanup: remove conditional preprocessor code that
	depends on __STDC__
Date: Thu, 14 Jul 2011 21:29:00 +0200

Glenn Morris <rgm <at> gnu.org> writes:

> To me, notabug means... "this is not a bug".
>
> Maybe "wontfix" + "notabug" = "invalid".

It's not a bug, but we won't fix it anyway?  Yes, that sounds pretty
invalid.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Message #27 received at 9066 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Dan Nicolaescu <dann <at> gnu.org>
Cc: 9066 <at> debbugs.gnu.org, emacs-devel <at> gnu.org
Subject: Re: cleanup: remove conditional preprocessor code that depends on
	__STDC__
Date: Sun, 17 Jul 2011 02:36:36 +0200

Dan Nicolaescu <dann <at> gnu.org> writes:

> The source now assumes standard C, there are a few places that test __STDC__, 
> those tests are not needed anymore.

I've had a peek at these, and they seem pretty trivial.

But is the time for cleanups like this now, or should they wait until
after the next release?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Message #30 received at 9066 <at> debbugs.gnu.org (full text, mbox):

From: Dan Nicolaescu <dann <at> gnu.org>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: 9066 <at> debbugs.gnu.org, emacs-devel <at> gnu.org
Subject: Re: cleanup: remove conditional preprocessor code that depends on
	__STDC__
Date: Mon, 18 Jul 2011 01:56:59 -0400

Lars Magne Ingebrigtsen <larsi <at> gnus.org> writes:

> Dan Nicolaescu <dann <at> gnu.org> writes:
>
>> The source now assumes standard C, there are a few places that test __STDC__, 
>> those tests are not needed anymore.
>
> I've had a peek at these, and they seem pretty trivial.
>
> But is the time for cleanups like this now, or should they wait until
> after the next release?

IMO, just wait until the next release, they are not worth the risk.

Message #33 received at 9066 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 9066 <at> debbugs.gnu.org
Subject: Re: bug#9066: cleanup: remove conditional preprocessor code that
	depends on __STDC__
Date: Thu, 14 Feb 2013 03:10:44 -0500

Dan Nicolaescu wrote:

> The source now assumes standard C, there are a few places that test
> __STDC__, those tests are not needed anymore.

The only ones left are in

  src/w32term.c
  nt/inc/ms-w32.h

OK to remove, or still needed?

Message #36 received at 9066 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 9066 <at> debbugs.gnu.org
Subject: Re: bug#9066: cleanup: remove conditional preprocessor code that
	depends	on __STDC__
Date: Sat, 16 Feb 2013 16:01:53 +0200

> From: Glenn Morris <rgm <at> gnu.org>
> Date: Thu, 14 Feb 2013 03:10:44 -0500
> 
> Dan Nicolaescu wrote:
> 
> > The source now assumes standard C, there are a few places that test
> > __STDC__, those tests are not needed anymore.
> 
> The only ones left are in
> 
>   src/w32term.c
>   nt/inc/ms-w32.h
> 
> OK to remove, or still needed?

I removed the first one, but the 2nd one has to stay.  I made it clear
it is only used for the MS compiler, though; GCC doesn't need it.

Trunk revision 111805.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.