GNU bug report logs - #9360
24.0.50; emacs-lisp-mode-abbrev-table neglected in emacs-lisp-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 9360 in the body.
You can then email your comments to 9360 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Seweryn Kokot <sewkokot <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.50; emacs-lisp-mode-abbrev-table neglected in emacs-lisp-mode
Date: Wed, 24 Aug 2011 15:09:36 +0200

When in a buffer in emacs-lisp-mode, emacs 24 neglects
emacs-lisp-mode-abbrev-table. It uses lisp-mode-abbrev-table only. I
think the elisp manual should tell us more about the difference between
the three lisp abbrev tables:
emacs-lisp-mode-abbrev-table, lisp-interaction-mode-abbrev-table and
lisp-mode-abbrev-table. I add that in emacs 23
emacs-lisp-mode-abbrev-table worked was taken into account when in
emacs-lisp-mode buffer.


In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
 of 2011-08-22 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.5) --no-opt'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ENG
  value of $XMODIFIERS: nil
  locale-coding-system: cp1252
  default enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<escape> x r e p o r t <tab> <return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr message format-spec rfc822 mml easymenu
mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mailabbrev mail-utils gmm-utils mailheader
emacsbug time-date tooltip ediff-hook vc-hooks lisp-float-type mwheel
dos-w32 disp-table ls-lisp w32-win w32-vars tool-bar dnd fontset image
fringe lisp-mode register page menu-bar rfn-eshadow timer select
scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham
georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese hebrew greek romanian slovak czech european ethiopic
indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple
abbrev minibuffer button faces cus-face files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process multi-tty emacs)

Message #8 received at 9360 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Seweryn Kokot <sewkokot <at> gmail.com>
Cc: 9360 <at> debbugs.gnu.org
Subject: Re: bug#9360: 24.0.50;
	emacs-lisp-mode-abbrev-table neglected in emacs-lisp-mode
Date: Wed, 24 Aug 2011 16:21:45 -0400

Seweryn Kokot wrote:

> When in a buffer in emacs-lisp-mode, emacs 24 neglects
> emacs-lisp-mode-abbrev-table. It uses lisp-mode-abbrev-table only. I
> think the elisp manual should tell us more about the difference between
> the three lisp abbrev tables:
> emacs-lisp-mode-abbrev-table, lisp-interaction-mode-abbrev-table and
> lisp-mode-abbrev-table. I add that in emacs 23
> emacs-lisp-mode-abbrev-table worked was taken into account when in
> emacs-lisp-mode buffer.

I don't see that emacs-lisp-mode-abbrev-table has ever had an effect.
In 23.1 it is void. In 23.2 and on it is defined (by define-derived-mode)
but not used. `add-mode-abbrev' in an Emacs Lisp mode buffer adds to
lisp-mode-abbrev-table. Adding an entry to emacs-lisp-mode-abbrev-table
in abbrev_defs has no effect.

This is because emacs-lisp-mode calls lisp-mode-variables, which
explicitly sets the abbrev-table to lisp-mode-abbrev-table.

To me, the bug looks like the fact that emacs-lisp-mode-abbrev-table is
defined at all. If it's never going to be used, the definition of
emacs-lisp-mode should specify an :abbrev-table.

> In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
>  of 2011-08-22 on 3249CTO

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Seweryn Kokot <sewkokot <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#9360:
	24.0.50;	emacs-lisp-mode-abbrev-table
	neglected in emacs-lisp-mode
Date: Thu, 25 Aug 2011 06:26:56 +0000 (UTC)

Glenn Morris <rgm <at> gnu.org> writes:

> 
> Seweryn Kokot wrote:
> 
> > When in a buffer in emacs-lisp-mode, emacs 24 neglects
> > emacs-lisp-mode-abbrev-table. It uses lisp-mode-abbrev-table only. I
> > think the elisp manual should tell us more about the difference between
> > the three lisp abbrev tables:
> > emacs-lisp-mode-abbrev-table, lisp-interaction-mode-abbrev-table and
> > lisp-mode-abbrev-table. I add that in emacs 23
> > emacs-lisp-mode-abbrev-table worked was taken into account when in
> > emacs-lisp-mode buffer.
> 
> I don't see that emacs-lisp-mode-abbrev-table has ever had an effect.
> In 23.1 it is void. In 23.2 and on it is defined (by define-derived-mode)
> but not used. `add-mode-abbrev' in an Emacs Lisp mode buffer adds to
> lisp-mode-abbrev-table. Adding an entry to emacs-lisp-mode-abbrev-table
> in abbrev_defs has no effect.
> 
> This is because emacs-lisp-mode calls lisp-mode-variables, which
> explicitly sets the abbrev-table to lisp-mode-abbrev-table.
> 
> To me, the bug looks like the fact that emacs-lisp-mode-abbrev-table is
> defined at all. If it's never going to be used, the definition of
> emacs-lisp-mode should specify an :abbrev-table.

I'm using msf-abbrev [1] library which uses emacs-lisp-mode-abbrev-table for 
emacs-lisp-mode and this mechanism worked in emacs 23.2 and not in emacs 
24.0.50. Now I modified msf-abbrev settings to use lisp-mode-abbrev-table but 
in fact it can be misleading to see emacs-lisp-mode-abbrev-table not working 
with emacs-lisp-mode. It's better to remove this table or explain how to use 
this abbrev table in emacs and elisp manuals. 

Thanks,
Regards,
Seweryn

[1] http://www.emacswiki.org/emacs/MsfAbbrev

> 
> > In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
> >  of 2011-08-22 on 3249CTO
> 
> 

Message #14 received at 9360 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Seweryn Kokot <sewkokot <at> gmail.com>
Cc: 9360 <at> debbugs.gnu.org
Subject: Re: bug#9360: 24.0.50;
	emacs-lisp-mode-abbrev-table neglected in emacs-lisp-mode
Date: Fri, 26 Aug 2011 22:33:15 -0400

> in fact it can be misleading to see emacs-lisp-mode-abbrev-table not working 
> with emacs-lisp-mode. It's better to remove this table or explain how to use 
> this abbrev table in emacs and elisp manuals. 

The right thing to do is to make emacs-lisp-mode-abbrev-table work in
emacs-lisp-mode.


        Stefan

Message #17 received at 9360 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> gnu.org>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: Seweryn Kokot <sewkokot <at> gmail.com>, 9360 <at> debbugs.gnu.org
Subject: Re: bug#9360: 24.0.50;
	emacs-lisp-mode-abbrev-table neglected in emacs-lisp-mode
Date: Sun, 29 Jan 2012 12:49:02 +0800

Stefan Monnier <monnier <at> IRO.UMontreal.CA> writes:

>> in fact it can be misleading to see emacs-lisp-mode-abbrev-table not working 
>> with emacs-lisp-mode. It's better to remove this table or explain how to use 
>> this abbrev table in emacs and elisp manuals. 
>
> The right thing to do is to make emacs-lisp-mode-abbrev-table work in
> emacs-lisp-mode.

I've checked in a fix.  Note that emacs-lisp-mode-abbrev-table now takes
lisp-mode-abbrev-table as its parent, in order for existing abbrevs to
continue working.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.